From: Dan Carpenter <dan.carpenter@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
John Stultz <john.stultz@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] clocksource: acpi_pm: fix return value of __setup handler
Date: Wed, 9 Mar 2022 11:56:18 +0300 [thread overview]
Message-ID: <20220309085618.GR3315@kadam> (raw)
In-Reply-To: <20220309040301.25087-1-rdunlap@infradead.org>
On Tue, Mar 08, 2022 at 08:03:01PM -0800, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) environment strings.
>
> The __setup() handler interface isn't meant to handle negative return
> values -- they are non-zero, so they mean "handled" (like a return
> value of 1 does), but that's just a quirk. So return 1 from
> parse_pmtmr(). Also print a warning message if kstrtouint() returns
> an error.
Everyone probably predicted that this API was/is going to cause bugs?
Smatch treats every (struct obs_kernel_param)->setup_func function as
the same so it's impossible to write a static checker for this because
in do_early_param() it expects zero on success and obsolete_checksetup()
has expects 1 on success and also on failure.
init/main.c
732 static int __init do_early_param(char *param, char *val,
733 const char *unused __always_unused,
734 void *arg __always_unused)
735 {
736 const struct obs_kernel_param *p;
737
738 for (p = __setup_start; p < __setup_end; p++) {
739 if ((p->early && parameq(param, p->str)) ||
740 (strcmp(param, "console") == 0 &&
741 strcmp(p->str, "earlycon") == 0)
742 ) {
743 if (p->setup_func(val) != 0)
744 pr_warn("Malformed early option '%s'\n", param);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
745 }
746 }
747 /* We accept everything at this stage. */
748 return 0;
749 }
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-09 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 4:03 [PATCH] clocksource: acpi_pm: fix return value of __setup handler Randy Dunlap
2022-03-09 8:56 ` Dan Carpenter [this message]
2022-03-12 7:09 ` Dan Carpenter
2022-03-12 19:23 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309085618.GR3315@kadam \
--to=dan.carpenter@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.