From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BCBAC433EF for ; Wed, 9 Mar 2022 12:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dMtOIpdQloZU7bbKQjuPrG/M1QkwWyV2w8pygyDmzpE=; b=aF4Octee03pC53 D0unLaRaBqDjLf9b6FS/EtpD13uKgSOrCbk4JBsmi6PJNirYh1PgAd9hPbvbnd6mjXwxdq8f6mS64 sJMgmEkOmZp+qytxqrZpy2lcXw4Aw4lPr56aRnUjsXvlJWcCJR9RPMkThct2+K4eGfBH5LhDvZ5Z/ gpHFezFmunaHYvtWiVxT7MwkO1GvN4CC4a0AnBlx+4+yy90Ue4+xMvZlOLYBt4LZyNr1I2Dv1UHXC otnt4YbmDM50O8e4PIzrlIm8ZQcWSqBI54gvdzR+w9jJ/I55r/VLzAQ+oQdmy/T644YKtw6nBHPbD ONPUiwysuKAnXbdBFCpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRvCx-008WbT-3w; Wed, 09 Mar 2022 12:14:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRvCo-008WYe-PW for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 12:14:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4862D61890; Wed, 9 Mar 2022 12:14:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 258D1C340EE; Wed, 9 Mar 2022 12:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646828053; bh=vbWl00FMpJ/3EBFaeAs4CNR9SWaNahzQLfs2mkVoCjI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qM5mreLTYttozz54nv2q5wfnRTnb54AzqMdUYYmBqxUqNZuBPdk2ZZW/HHolaZDR5 AfeDlqbYHKRxjdt6W/uankcuxozrLnGJwJhcB0aMmiHFGNzSEh501IciowS/S96mOF a0SSCmOEdXMHYOTH1qHEeLWYpMBmOGAdzGO3C4X5zxcPMniwTF/Rigl/3zl2P3sVLZ 3gK1ESdgDU2ssYrY1PpJFNY7Io5VbK58iPRcE665pSxRUUW1WP1w/6yI/BG7IXneZU fLatDqZN3uGz9KIhVXUoE7U+qTaYArC2Cd0Ejb7dG53qNPX1mRHqcb66Ens9rB5pMv ZNU3c0/HvHUaw== Date: Wed, 9 Mar 2022 12:14:08 +0000 From: Will Deacon To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, kernel-team@android.com, pcc@google.com, nd@arm.com, mark.rutland@arm.com, sfr@canb.auug.org.au Subject: Re: [PATCH v1 -next] kasan: fix a missing header include of static_keys.h Message-ID: <20220309121408.GB397@willie-the-truck> References: <20220301154518.19456-1-joey.gouly@arm.com> <164668941526.3276591.16335503450068989347.b4-ty@kernel.org> <20220309094907.GA44574@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220309094907.GA44574@e124191.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_041414_922017_6D9E4E9B X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 09, 2022 at 09:49:07AM +0000, Joey Gouly wrote: > Hi Will, > > On Mon, Mar 07, 2022 at 10:03:30PM +0000, Will Deacon wrote: > > On Tue, 1 Mar 2022 15:45:18 +0000, Joey Gouly wrote: > > > The kasan-enabled.h header relies on static keys, so make sure > > > to include the header to avoid compilation errors (with JUMP_LABEL=n). > > > > > > It fixes the following: > > > ./include/linux/kasan-enabled.h:9:1: warning: data definition has no type or storage class > > > 9 | DECLARE_STATIC_KEY_FALSE(kasan_flag_enabled); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int] > > > > > > [...] > > > > Applied to arm64 (for-next/mte), thanks! > > > > [1/1] kasan: fix a missing header include of static_keys.h > > https://git.kernel.org/arm64/c/1a7b2121ebd3 > > I accidentally deleted my sign off when adding the Fixes tag, spotted when merging into next: > https://lore.kernel.org/lkml/20220309081719.54964469@canb.auug.org.au/ > > So here it is: > Signed-off-by: Joey Gouly Thanks, I'll add that to the patch. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel