From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD663C433F5 for ; Thu, 10 Mar 2022 01:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236060AbiCJByy (ORCPT ); Wed, 9 Mar 2022 20:54:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232971AbiCJByw (ORCPT ); Wed, 9 Mar 2022 20:54:52 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 245FC128592; Wed, 9 Mar 2022 17:53:53 -0800 (PST) Received: from integral2.. (unknown [114.10.7.234]) by gnuweeb.org (Postfix) with ESMTPSA id 138147E2D7; Thu, 10 Mar 2022 01:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1646877232; bh=k4b/gnTPXj7jVItm9sqkob63bVPtxz95JpsUqhVzIvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KJ9w89Xw36tW+P7fsFcWottfGTayDR72m4AEw+oygIZnUbrHJXoITtxAgjU5tkW4E Uh5aqucDJd74GzwLm/RZ2vJLjiWHqIwkotxVdSr8iSnefl96NsEeXNy8ioWSfK9TPT CcZf25Unrb8Ma4+ovJaFJ1yK8qg52lUt1WyNAOutCYgtrckvc80t9vYqE+K+eZiJiM Cdb5PsDDnAXhXvVHDestgGZjGqyQwlh/3cwqHI5ODq8DrPn/QTt9RWEpT45WYzN2Va 6YlGszkZWVHxI31eN0lKD9fQolTt56irJGg2A/RzjvChgHP5mQ/Gh/Q2dXeviID6dT ZIo8h0n/ZEWnA== From: Ammar Faizi To: Borislav Petkov , Thomas Gleixner Cc: Ammar Faizi , Alviro Iskandar Setiawan , Alviro Iskandar Setiawan , Dave Hansen , Greg Kroah-Hartman , "H. Peter Anvin" , Ingo Molnar , Tony Luck , Yazen Ghannam , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org, David Laight , Jiri Hladky Subject: [PATCH v5 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()` Date: Thu, 10 Mar 2022 08:53:05 +0700 Message-Id: <20220310015306.445359-2-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220310015306.445359-1-ammarfaizi2@gnuweeb.org> References: <20220310015306.445359-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The asm constraint does not reflect that the asm statement can modify the value of @loops. But the asm statement in delay_loop() does modify the @loops. Specifiying the wrong constraint may lead to undefined behavior, it may clobber random stuff (e.g. local variable, important temporary value in regs, etc.). Fix this by changing the constraint from "a" (as an input) to "+a" (as an input and output). Cc: David Laight Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: Jiri Hladky Cc: stable@vger.kernel.org # v2.6.27+ Fixes: e01b70ef3eb ("x86: fix bug in arch/i386/lib/delay.c file, delay_loop function") Signed-off-by: Ammar Faizi --- arch/x86/lib/delay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index 65d15df6212d..0e65d00e2339 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -54,8 +54,8 @@ static void delay_loop(u64 __loops) " jnz 2b \n" "3: dec %0 \n" - : /* we don't need output */ - :"a" (loops) + : "+a" (loops) + : ); } -- 2.32.0