From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF33C433EF for ; Thu, 10 Mar 2022 11:38:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235816AbiCJLjY (ORCPT ); Thu, 10 Mar 2022 06:39:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235045AbiCJLjX (ORCPT ); Thu, 10 Mar 2022 06:39:23 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29FEF13D43 for ; Thu, 10 Mar 2022 03:38:23 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSH7d-0000Ow-1N; Thu, 10 Mar 2022 12:38:21 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nSH7c-0002Ek-Et; Thu, 10 Mar 2022 12:38:20 +0100 Date: Thu, 10 Mar 2022 12:38:20 +0100 From: Oleksij Rempel To: Oliver Neukum Cc: Oleksij Rempel , "netdev@vger.kernel.org" Subject: Re: ordering of call to unbind() in usbnet_disconnect Message-ID: <20220310113820.GG15680@pengutronix.de> References: <62b944a1-0df2-6e81-397c-6bf9dea266ef@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <62b944a1-0df2-6e81-397c-6bf9dea266ef@suse.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:35:19 up 89 days, 20:20, 88 users, load average: 0.12, 0.14, 0.12 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Thu, Mar 10, 2022 at 12:25:08PM +0100, Oliver Neukum wrote: > Hi, > > I got bug reports that 2c9d6c2b871d ("usbnet: run unbind() before > unregister_netdev()") > is causing regressions. Rather than simply reverting it, > it seems to me that the call needs to be split. One in the old place > and one in the place you moved it to. > > Could you tell me which drivers you moved the call for? I moved it for asix_devices.c:ax88772_unbind() Probably smsc95xx.c:smsc95xx_unbind() has same issue. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |