From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63A32C433EF for ; Thu, 10 Mar 2022 17:02:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB27F83AB5; Thu, 10 Mar 2022 18:02:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 78234839E9; Thu, 10 Mar 2022 18:01:58 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 1C6C9839E9 for ; Thu, 10 Mar 2022 18:01:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E0211692; Thu, 10 Mar 2022 09:01:54 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B00D3F99C; Thu, 10 Mar 2022 09:01:53 -0800 (PST) Date: Thu, 10 Mar 2022 17:01:50 +0000 From: Andre Przywara To: Sean Anderson Cc: Tom Rini , Linus Walleij , Simon Glass , u-boot@lists.denx.de, Mingkai Hu , Priyanka Jain , Rajesh Bhagat Subject: Re: [PATCH 00/17] arm: semihosting: Cleanups and new features Message-ID: <20220310170150.01cd713f@donnerap.cambridge.arm.com> In-Reply-To: <95c128ae-652a-0e00-695b-47b6a2d150df@seco.com> References: <20220303204400.2787389-1-sean.anderson@seco.com> <20220304114753.23bc4666@donnerap.cambridge.arm.com> <120ddbc5-f452-422e-cba5-6ffd0faf4ed1@seco.com> <20220304184637.GZ5020@bill-the-cat> <95c128ae-652a-0e00-695b-47b6a2d150df@seco.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Mar 2022 11:48:50 -0500 Sean Anderson wrote: Hi, > On 3/4/22 1:46 PM, Tom Rini wrote: > > On Fri, Mar 04, 2022 at 12:19:27PM -0500, Sean Anderson wrote: > >> Hi Andre, > >> > >> On 3/4/22 6:47 AM, Andre Przywara wrote: > >> > On Fri, 4 Mar 2022 02:06:03 +0100 > >> > Linus Walleij wrote: > >> > > >> > Hi, > >> > > >> > Linus, thanks for the heads up, much appreciated! > >> > > >> >> On Thu, Mar 3, 2022 at 9:44 PM Sean Anderson wrote: > >> >> > >> >> > The main device affected by these changes is vexpress64, so I'd appreciate > >> >> > if Linus (or anyone else) could try booting. > >> > > >> > As it happens, I am sitting on a series updating vexpress_aemv8a_semi, and > >> > letting it use OF_CONTROL. I will send this ASAP. > >> > As it turned out, the automatic semihosting boot command is actually broken > >> > in v2022.01, the fix is the first patch in my series. This clashes with > >> > this series, but it's easy to resolve. > >> > >> I, for one, appreciate that the boot command is no longer all one line after > >> your series. > >> > >> Simon/Tom, which series would you like to be based off the other? > > > > I think it's however it's easiest for you two to collaborate. > > I think it will be cleaner for me to base my series on his, but I just want to > avoid having to rebase a lot :) Yeah, it should just be this one line, though, right? Tom, would you consider taking patch 01/11 now, as this fixes a regression? The Sean could at least rebase on top of this. Rebasing on top of the rest should be more straight-forward, because it's not one super-long line anymore. > > >> > From skimming over this series here, it looks quite nice, I especially love > >> > promoting the semihosting load to a proper filesystem. The only drawback > >> > seems to be that this will break existing scripts used by people in their > >> > deployments, which rely on the smhload command. I don't really know if > >> > there are actually any users doing so, but I guess we will find out. > >> > >> Yeah, I'm not sure what the stance on shell compatibility is. As I understand > >> it, for the C API only in-tree users matter. However, shell commands are more > >> of an "external" API, used by distro boot scripts. Simon/Tom, what's the > >> process for this? > > > > Well, in this case we can be a bit more cavalier than typical because of > > the very limited user base. So long as we have good documentation Yes, I agree. I don't think there are many users. The fact that it's broken in v2022.01 and nobody complained so far tells you something. And I can certainly handle a good part of the users internally here. I guess the other half is in Linaro ;-) Cheers, Andre > > around it including something around how to transition to the new > > commands, it should be fine to do so, when the code is otherwise ready. > > OK, I will add some more documentation about transitioning to this series. > > --Sean