From: Stephen Boyd <sboyd@kernel.org>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Tero Kristo" <kristo@kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/5] ARM: dts: Add clock-output-names for omap4
Date: Thu, 10 Mar 2022 19:34:37 -0800 [thread overview]
Message-ID: <20220311033439.15316C340EC@smtp.kernel.org> (raw)
In-Reply-To: <20220204084339.12341-2-tony@atomide.com>
Quoting Tony Lindgren (2022-02-04 00:43:35)
> To stop using the non-standard node name based clock naming, let's
> first add the clock-output-names property. This allows us to stop using
> the internal legacy clock naming and unify the naming for the TI SoCs in
> the following patches.
>
> Note that we must wait on fixing the node naming issues until after the
> internal clock names have been updated to avoid adding name translation
> unnecessarily.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Tero Kristo <kristo@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
I assume I don't merge this through clk tree.
> arch/arm/boot/dts/omap443x-clocks.dtsi | 1 +
> arch/arm/boot/dts/omap446x-clocks.dtsi | 2 +
> arch/arm/boot/dts/omap44xx-clocks.dtsi | 165 +++++++++++++++++++++++++
> 3 files changed, 168 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap443x-clocks.dtsi b/arch/arm/boot/dts/omap443x-clocks.dtsi
> --- a/arch/arm/boot/dts/omap443x-clocks.dtsi
> +++ b/arch/arm/boot/dts/omap443x-clocks.dtsi
> @@ -8,6 +8,7 @@ &prm_clocks {
> bandgap_fclk: bandgap_fclk@1888 {
> #clock-cells = <0>;
> compatible = "ti,gate-clock";
> + clock-output-names = "bandgap_fclk";
At this point clock-output-names is basically a debug feature. It would
be better to use clocks property in consumer nodes and then use
clk_parent_data to link up the clk tree. Not sure if that matters here
though? I can understand the desire to have "usable" names vs. some
not very useful name be auto generated..
> clocks = <&sys_32k_ck>;
> ti,bit-shift = <8>;
> reg = <0x1888>;
next prev parent reply other threads:[~2022-03-11 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 8:43 [PATCH 0/5] Unify omap4/5 clocks with clock-output-names Tony Lindgren
2022-02-04 8:43 ` [PATCH 1/5] ARM: dts: Add clock-output-names for omap4 Tony Lindgren
2022-03-11 3:34 ` Stephen Boyd [this message]
2022-03-12 8:12 ` Tony Lindgren
2022-03-15 21:25 ` Stephen Boyd
2022-02-04 8:43 ` [PATCH 2/5] ARM: dts: Drop custom clkctrl compatible and update omap4 l4per Tony Lindgren
2022-02-04 8:43 ` [PATCH 3/5] ARM: dts: Add clock-output-names for omap5 Tony Lindgren
2022-02-04 8:43 ` [PATCH 4/5] ARM: dts: Drop custom clkctrl compatible and update omap5 l4per Tony Lindgren
2022-02-04 8:43 ` [PATCH 5/5] clk: ti: Stop using legacy clkctrl names for omap4 and 5 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311033439.15316C340EC@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.