Re: [PATCH 00/17] arm: semihosting: Cleanups and new features

From: Andre Przywara <andre.przywara@arm.com>
To: Tom Rini <trini@konsulko.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de, Mingkai Hu <mingkai.hu@nxp.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: Re: [PATCH 00/17] arm: semihosting: Cleanups and new features
Date: Fri, 11 Mar 2022 13:10:50 +0000	[thread overview]
Message-ID: <20220311131050.51b49265@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220310171616.GP5020@bill-the-cat>

On Thu, 10 Mar 2022 12:16:16 -0500
Tom Rini <trini@konsulko.com> wrote:

> On Thu, Mar 10, 2022 at 12:06:48PM -0500, Sean Anderson wrote:
> > 
> > 
> > On 3/10/22 12:01 PM, Andre Przywara wrote:  
> > > On Thu, 10 Mar 2022 11:48:50 -0500
> > > Sean Anderson <sean.anderson@seco.com> wrote:
> > > 
> > > Hi,
> > >   
> > >> On 3/4/22 1:46 PM, Tom Rini wrote:  
> > >> > On Fri, Mar 04, 2022 at 12:19:27PM -0500, Sean Anderson wrote:    
> > >> >> Hi Andre,
> > >> >> 
> > >> >> On 3/4/22 6:47 AM, Andre Przywara wrote:    
> > >> >> > On Fri, 4 Mar 2022 02:06:03 +0100
> > >> >> > Linus Walleij <linus.walleij@linaro.org> wrote:
> > >> >> > 
> > >> >> > Hi,
> > >> >> > 
> > >> >> > Linus, thanks for the heads up, much appreciated!
> > >> >> >     
> > >> >> >> On Thu, Mar 3, 2022 at 9:44 PM Sean Anderson <sean.anderson@seco.com> wrote:
> > >> >> >>     
> > >> >> >> > The main device affected by these changes is vexpress64, so I'd appreciate
> > >> >> >> > if Linus (or anyone else) could try booting.      
> > >> >> > 
> > >> >> > As it happens, I am sitting on a series updating vexpress_aemv8a_semi, and
> > >> >> > letting it use OF_CONTROL. I will send this ASAP.
> > >> >> > As it turned out, the automatic semihosting boot command is actually broken
> > >> >> > in v2022.01, the fix is the first patch in my series. This clashes with
> > >> >> > this series, but it's easy to resolve.    
> > >> >> 
> > >> >> I, for one, appreciate that the boot command is no longer all one line after
> > >> >> your series.
> > >> >> 
> > >> >> Simon/Tom, which series would you like to be based off the other?    
> > >> > 
> > >> > I think it's however it's easiest for you two to collaborate.    
> > >> 
> > >> I think it will be cleaner for me to base my series on his, but I just want to
> > >> avoid having to rebase a lot :)  
> > > 
> > > Yeah, it should just be this one line, though, right?
> > > Tom, would you consider taking patch 01/11 now, as this fixes a
> > > regression? The Sean could at least rebase on top of this. Rebasing on top
> > > of the rest should be more straight-forward, because it's not one
> > > super-long line anymore.  
> > 
> > The patch which makes the boot command multi-line is [PATCH 07/11] vexpress64: fvp:
> > add distro_boot support. I'm not sure how much that patch depends on the others,
> > but presumably you would need to apply 5 and 6 as well.  
> 
> Um, so for clarity, should I take:
> https://patchwork.ozlabs.org/project/uboot/patch/20220304163018.3167841-2-andre.przywara@arm.com/

Yes, please, it's really just this one patch that fixes the regression.
This is also the reason I refrained from sending a separate series, plus
the other patches (trivially) depend on it.

Thanks!
Andre

> or if it's more than just that, how about a regression-fixes-only series
> for me to take for this release?  Thanks!
> 