No u-boot-rockchip pull request sent or merged for v2022.04

No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

Hi Tom,

I have a few Rockchip-related series [1] that I was expecting to land
for v2022.04 (including improvements for chromebook_bob, support for the
chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
u-boot-rockchip pull request since the one for v2022.01 [2]. There's
also more pending patches from other people [3].

Kever seems unresponsive, last message to the mailing list was that pull
request in December 2021. I did send on-list mails as To: Kever whenever
Simon happened to poke me about chromebook_kevin not being merged, but
to no avail.

What should be done here, any advice?

Sorry for being quite late with this,
Alper.


[1] Patches by me
https://patchwork.ozlabs.org/project/uboot/list/?submitter=78732

[2] Pull request: u-boot-rockchip-20211226
https://lore.kernel.org/u-boot/c12f6f2b-8c5a-654a-ad6a-5aed4a93874a@rock-chips.com/

[3] Patches assigned to Kever Yang
https://patchwork.ozlabs.org/project/uboot/list/?delegate=93623

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:

> Hi Tom,
> 
> I have a few Rockchip-related series [1] that I was expecting to land
> for v2022.04 (including improvements for chromebook_bob, support for the
> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
> also more pending patches from other people [3].
> 
> Kever seems unresponsive, last message to the mailing list was that pull
> request in December 2021. I did send on-list mails as To: Kever whenever
> Simon happened to poke me about chromebook_kevin not being merged, but
> to no avail.
> 
> What should be done here, any advice?
 
I've been hoping for something to show up soon myself.  To start with,
are there any rockchip related regression fixes you're aware of?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

On 11/03/2022 18:43, Tom Rini wrote:
> On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:
>> I have a few Rockchip-related series [1] that I was expecting to land
>> for v2022.04 (including improvements for chromebook_bob, support for the
>> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
>> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
>> also more pending patches from other people [3].
>>
>> Kever seems unresponsive, last message to the mailing list was that pull
>> request in December 2021. I did send on-list mails as To: Kever whenever
>> Simon happened to poke me about chromebook_kevin not being merged, but
>> to no avail.
>>
>> What should be done here, any advice?
>  
> I've been hoping for something to show up soon myself.  To start with,
> are there any rockchip related regression fixes you're aware of?

I haven't been paying enough attention to others' patches. For those of
mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
IIRC it has been broken since v2021.10 on some boards (but not all).

[1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Simon Glass]

Hi.

On Fri, 11 Mar 2022 at 11:16, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> On 11/03/2022 18:43, Tom Rini wrote:
> > On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:
> >> I have a few Rockchip-related series [1] that I was expecting to land
> >> for v2022.04 (including improvements for chromebook_bob, support for the
> >> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
> >> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
> >> also more pending patches from other people [3].
> >>
> >> Kever seems unresponsive, last message to the mailing list was that pull
> >> request in December 2021. I did send on-list mails as To: Kever whenever
> >> Simon happened to poke me about chromebook_kevin not being merged, but
> >> to no avail.
> >>
> >> What should be done here, any advice?
> >
> > I've been hoping for something to show up soon myself.  To start with,
> > are there any rockchip related regression fixes you're aware of?
>
> I haven't been paying enough attention to others' patches. For those of
> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
> IIRC it has been broken since v2021.10 on some boards (but not all).
>
> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/

Apler, would you be interested in being a co-maintainer for Rockchip?

I very much want to get your other patches landed too, particularly
the 'kevin' ones as I have that board in my lab.

Regards,
Simon

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Philipp Tomsich]

On Fri, 11 Mar 2022 at 19:15, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> On 11/03/2022 18:43, Tom Rini wrote:
> > On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:
> >> I have a few Rockchip-related series [1] that I was expecting to land
> >> for v2022.04 (including improvements for chromebook_bob, support for the
> >> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
> >> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
> >> also more pending patches from other people [3].
> >>
> >> Kever seems unresponsive, last message to the mailing list was that pull
> >> request in December 2021. I did send on-list mails as To: Kever whenever
> >> Simon happened to poke me about chromebook_kevin not being merged, but
> >> to no avail.
> >>
> >> What should be done here, any advice?
> >
> > I've been hoping for something to show up soon myself.  To start with,
> > are there any rockchip related regression fixes you're aware of?
>
> I haven't been paying enough attention to others' patches. For those of
> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
> IIRC it has been broken since v2021.10 on some boards (but not all).

For the regressions, I could try help moving them forward (i.e.,
build-test and reviewing) next week, but I don't have a test setup
with any Rockchip boards available at the moment.

Philipp.

>
> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

On 11/03/2022 21:18, Simon Glass wrote:
> On Fri, 11 Mar 2022 at 11:16, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>> I haven't been paying enough attention to others' patches. For those of
>> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
>> IIRC it has been broken since v2021.10 on some boards (but not all).
>>
>> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
>> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/
> 
> Apler, would you be interested in being a co-maintainer for Rockchip?

I can try. Not sure how much I'll be able to help (both time and
knowledge-wise), I only have a chromebook_kevin and just know few things
about rk3399 stuff at best, learning as I go along. But I would like to
help.

> I very much want to get your other patches landed too, particularly
> the 'kevin' ones as I have that board in my lab.

Me too. Would they go into -next and v2022.07 at this point?

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

On Fri, Mar 11, 2022 at 07:25:38PM +0100, Philipp Tomsich wrote:
> On Fri, 11 Mar 2022 at 19:15, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
> >
> > On 11/03/2022 18:43, Tom Rini wrote:
> > > On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:
> > >> I have a few Rockchip-related series [1] that I was expecting to land
> > >> for v2022.04 (including improvements for chromebook_bob, support for the
> > >> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
> > >> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
> > >> also more pending patches from other people [3].
> > >>
> > >> Kever seems unresponsive, last message to the mailing list was that pull
> > >> request in December 2021. I did send on-list mails as To: Kever whenever
> > >> Simon happened to poke me about chromebook_kevin not being merged, but
> > >> to no avail.
> > >>
> > >> What should be done here, any advice?
> > >
> > > I've been hoping for something to show up soon myself.  To start with,
> > > are there any rockchip related regression fixes you're aware of?
> >
> > I haven't been paying enough attention to others' patches. For those of
> > mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
> > IIRC it has been broken since v2021.10 on some boards (but not all).
> 
> For the regressions, I could try help moving them forward (i.e.,
> build-test and reviewing) next week, but I don't have a test setup
> with any Rockchip boards available at the moment.

For regression stuff, I'm happy to just pick it up and run the build
testing.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Fri, Mar 11, 2022 at 09:56:59PM +0300, Alper Nebi Yasak wrote:
> On 11/03/2022 21:18, Simon Glass wrote:
> > On Fri, 11 Mar 2022 at 11:16, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
> >> I haven't been paying enough attention to others' patches. For those of
> >> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
> >> IIRC it has been broken since v2021.10 on some boards (but not all).
> >>
> >> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
> >> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/
> > 
> > Apler, would you be interested in being a co-maintainer for Rockchip?
> 
> I can try. Not sure how much I'll be able to help (both time and
> knowledge-wise), I only have a chromebook_kevin and just know few things
> about rk3399 stuff at best, learning as I go along. But I would like to
> help.
> 
> > I very much want to get your other patches landed too, particularly
> > the 'kevin' ones as I have that board in my lab.
> 
> Me too. Would they go into -next and v2022.07 at this point?

Well, how self contained is it all?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

On 11/03/2022 22:01, Tom Rini wrote:
> On Fri, Mar 11, 2022 at 09:56:59PM +0300, Alper Nebi Yasak wrote:
>> On 11/03/2022 21:18, Simon Glass wrote:
>>> Apler, would you be interested in being a co-maintainer for Rockchip?
>>
>> I can try. Not sure how much I'll be able to help (both time and
>> knowledge-wise), I only have a chromebook_kevin and just know few things
>> about rk3399 stuff at best, learning as I go along. But I would like to
>> help.
>>
>>> I very much want to get your other patches landed too, particularly
>>> the 'kevin' ones as I have that board in my lab.
>>
>> Me too. Would they go into -next and v2022.07 at this point?
> 
> Well, how self contained is it all?

It's this series [1], the first three patches only affect chromebook_bob
 (board/google/gru, dts, configs). The final patch for chromebook_kevin
adds a single define to linux-event-codes.h, duplicates some bob code
and Kconfig already in arch/arm/mach-rockchip, in addition to
kevin-specific files.

[1] Improve support for Bob chromebook and add support for Kevin
https://patchwork.ozlabs.org/project/uboot/list/?series=278350

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

On 11/03/2022 22:25, Alper Nebi Yasak wrote:
> On 11/03/2022 22:01, Tom Rini wrote:
>> On Fri, Mar 11, 2022 at 09:56:59PM +0300, Alper Nebi Yasak wrote:
>>> On 11/03/2022 21:18, Simon Glass wrote:
>>>> Apler, would you be interested in being a co-maintainer for Rockchip?
>>>
>>> I can try. Not sure how much I'll be able to help (both time and
>>> knowledge-wise), I only have a chromebook_kevin and just know few things
>>> about rk3399 stuff at best, learning as I go along. But I would like to
>>> help.
>>>
>>>> I very much want to get your other patches landed too, particularly
>>>> the 'kevin' ones as I have that board in my lab.
>>>
>>> Me too. Would they go into -next and v2022.07 at this point?
>>
>> Well, how self contained is it all?
> 
> It's this series [1], the first three patches only affect chromebook_bob
>  (board/google/gru, dts, configs). The final patch for chromebook_kevin

I mean the first patches only affect chromebook_bob as kevin isn't there
yet, those changes still apply to or are copied to kevin by the final
patch. (Didn't sound right when I re-read it so wanted to clarify.)

> adds a single define to linux-event-codes.h, duplicates some bob code
> and Kconfig already in arch/arm/mach-rockchip, in addition to
> kevin-specific files.
> 
> [1] Improve support for Bob chromebook and add support for Kevin
> https://patchwork.ozlabs.org/project/uboot/list/?series=278350

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Kever Yang]

Hi Alper,

     Sorry for reply late, I apologize for not  able to make a pull 
request for v2022.04 till now, I'm really busy for pass few weeks, the 
reason including some change from both my work and my family.

I will check the patches on the list for u-boot-rockchip and land them 
once I have check the patch and works on my boards.


Thanks,
- Kever
On 2022/3/11 05:05, Alper Nebi Yasak wrote:
> Hi Tom,
>
> I have a few Rockchip-related series [1] that I was expecting to land
> for v2022.04 (including improvements for chromebook_bob, support for the
> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
> also more pending patches from other people [3].
>
> Kever seems unresponsive, last message to the mailing list was that pull
> request in December 2021. I did send on-list mails as To: Kever whenever
> Simon happened to poke me about chromebook_kevin not being merged, but
> to no avail.
>
> What should be done here, any advice?
>
> Sorry for being quite late with this,
> Alper.
>
>
> [1] Patches by me
> https://patchwork.ozlabs.org/project/uboot/list/?submitter=78732
>
> [2] Pull request: u-boot-rockchip-20211226
> https://lore.kernel.org/u-boot/c12f6f2b-8c5a-654a-ad6a-5aed4a93874a@rock-chips.com/
>
> [3] Patches assigned to Kever Yang
> https://patchwork.ozlabs.org/project/uboot/list/?delegate=93623

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Kever Yang]

Hi Alper,

On 2022/3/12 02:15, Alper Nebi Yasak wrote:
> On 11/03/2022 18:43, Tom Rini wrote:
>> On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote:
>>> I have a few Rockchip-related series [1] that I was expecting to land
>>> for v2022.04 (including improvements for chromebook_bob, support for the
>>> chromebook_kevin board, rk3399 eMMC fixes) but there hasn't been a
>>> u-boot-rockchip pull request since the one for v2022.01 [2]. There's
>>> also more pending patches from other people [3].
>>>
>>> Kever seems unresponsive, last message to the mailing list was that pull
>>> request in December 2021. I did send on-list mails as To: Kever whenever
>>> Simon happened to poke me about chromebook_kevin not being merged, but
>>> to no avail.
>>>
>>> What should be done here, any advice?
>>   
>> I've been hoping for something to show up soon myself.  To start with,
>> are there any rockchip related regression fixes you're aware of?
> I haven't been paying enough attention to others' patches. For those of
> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.

The eMMC driver is always not robust enough on mainline U-Boot, eg. 
there still have many

offlist patches on rockchip branch to make all the SoCs work(we do try 
to upstream them before), and the patch series you

mentioned which broken the chromebook_kevin board is one of patch want 
to clean up and support

rk3568, so I think we also need to test this fix on rk3568 board.


Thanks,
- Kever
> IIRC it has been broken since v2021.10 on some boards (but not all).
>
> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Kever Yang]

Hi Tom, Simon, Philipp,

     Thanks for your help, I think my spare time is getting back and I 
can handle the work of patch review and verify on different SoCs/boards 
for u-boot-rockchip now.

I will land patches and fixes which is ready to land to master for 
v2022.04 and others to for-next for v2022.07.


Thanks,
- Kever
On 2022/3/12 03:01, Tom Rini wrote:
> On Fri, Mar 11, 2022 at 09:56:59PM +0300, Alper Nebi Yasak wrote:
>> On 11/03/2022 21:18, Simon Glass wrote:
>>> On Fri, 11 Mar 2022 at 11:16, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>>>> I haven't been paying enough attention to others' patches. For those of
>>>> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
>>>> IIRC it has been broken since v2021.10 on some boards (but not all).
>>>>
>>>> [1] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
>>>> https://patchwork.ozlabs.org/project/uboot/patch/20220128224240.4226-3-alpernebiyasak@gmail.com/
>>> Apler, would you be interested in being a co-maintainer for Rockchip?
>> I can try. Not sure how much I'll be able to help (both time and
>> knowledge-wise), I only have a chromebook_kevin and just know few things
>> about rk3399 stuff at best, learning as I go along. But I would like to
>> help.
>>
>>> I very much want to get your other patches landed too, particularly
>>> the 'kevin' ones as I have that board in my lab.
>> Me too. Would they go into -next and v2022.07 at this point?
> Well, how self contained is it all?
>

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Alper Nebi Yasak]

On 12/03/2022 16:38, Kever Yang wrote:
> On 2022/3/12 02:15, Alper Nebi Yasak wrote:
>> I haven't been paying enough attention to others' patches. For those of
>> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
> 
> The eMMC driver is always not robust enough on mainline U-Boot, eg. 
> there still have many
> 
> offlist patches on rockchip branch to make all the SoCs work(we do try 
> to upstream them before), and the patch series you
> 
> mentioned which broken the chromebook_kevin board is one of patch want 
> to clean up and support
> 
> rk3568, so I think we also need to test this fix on rk3568 board.

Well, Tom applied the patch to master. I also received a modified
version of patch 4/4 of that series as fixed for RK3568 SDK, so I assume
the merged one (2/4) does work on that board without modification.

Re: No u-boot-rockchip pull request sent or merged for v2022.04

[Kever Yang]

Hi Alper,

On 2022/3/15 05:30, Alper Nebi Yasak wrote:
> On 12/03/2022 16:38, Kever Yang wrote:
>> On 2022/3/12 02:15, Alper Nebi Yasak wrote:
>>> I haven't been paying enough attention to others' patches. For those of
>>> mine, I think I can only call my RK3399 eMMC fix [1] a regression fix.
>> The eMMC driver is always not robust enough on mainline U-Boot, eg.
>> there still have many
>>
>> offlist patches on rockchip branch to make all the SoCs work(we do try
>> to upstream them before), and the patch series you
>>
>> mentioned which broken the chromebook_kevin board is one of patch want
>> to clean up and support
>>
>> rk3568, so I think we also need to test this fix on rk3568 board.
> Well, Tom applied the patch to master. I also received a modified
> version of patch 4/4 of that series as fixed for RK3568 SDK, so I assume
> the merged one (2/4) does work on that board without modification.

We do the verify on rk3568 board and this patch set do broken rk3568, 
though if only pick 2/4 works.

We have debug and fix it, Yifeng should already share the updated 
working version of patch 4/4 to you off list,

please help to send the new version once ready, so that I can land all 
the patches.


Thanks,
- Kever