From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01182C433F5 for ; Fri, 11 Mar 2022 20:16:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 782121772; Fri, 11 Mar 2022 21:15:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 782121772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647029758; bh=yr0wqfz/5omDgz5A56JPzaEkc41VyITYQncs1Q50cpA=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=jILLfdl81Li34MMnFrCK3hF/izDS0FDSUaK7FL7NvGvBDIeykrFoQXQ9qBJnlrpAD L7FM1Mkc0PSNWqcblbY/NlRgKi3w2T6Gm5hYfs0gGQ3KUQM5tf1zeHl5ojK0nfisGc 7yNxB7dpdYKbglUHmrYtQwHtsS2Sl/M6xXaKDpCI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0BF1DF801D8; Fri, 11 Mar 2022 21:15:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 351E9F80227; Fri, 11 Mar 2022 21:15:05 +0100 (CET) Received: from www381.your-server.de (www381.your-server.de [78.46.137.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3DB2CF8012C for ; Fri, 11 Mar 2022 21:14:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3DB2CF8012C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=metafoo.de header.i=@metafoo.de header.b="WAB6QQHu" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=ZVDcCpO/0E/ykbsgbIMmswF2OSPMyLGBt9qq4Nypk3E=; b=WAB6QQHuW25VP+/UWuc8tdgmDk LPAvPPpfZOniDjPwyj5nkNFPLBv+oruf65DsAB0FT8N9zTjQSFbWgJNw7I5J9oGL/46K3xNMR53KQ Jdt9H53RRTj6vb0BvSnRJg3bfwIF/6UrxJ1ljBhWSMF1Zy7prYBmi6bfHMsrHnbQaSlubbA74C1Rl IRCoYPz0jVJA4iml/osSYfI9YILwO25bgMGuz8+xiEqLbxh5CMr9xJUCRInxLU7CzLRKLC8gcdKdY QWhAUM7fmLhuF8m8NTBTVlb056CsTNj5xFGGcD+Rxefp6xIJ0GicE8ymqkPyUe/pZ/ivmtkuits4y Ocl2PAnw==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www381.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1nSlf7-0009yI-Sg; Fri, 11 Mar 2022 21:14:57 +0100 Received: from [2001:a61:2b4b:5001:9e5c:8eff:fe01:8578] (helo=lars-desktop.fritz.box) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSlf7-000VS9-ND; Fri, 11 Mar 2022 21:14:57 +0100 From: Lars-Peter Clausen To: Takashi Iwai Subject: [PATCH] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB Date: Fri, 11 Mar 2022 21:14:00 +0100 Message-Id: <20220311201400.235892-1-lars@metafoo.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26478/Fri Mar 11 10:27:25 2022) Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" For the RODE NT-USB the lowest Playback mixer volume setting mutes the audio output. But it is not reported as such causing e.g. PulseAudio to accidentally mute the device when selecting a low volume. Fix this by applying the existing quirk for this kind of issue when the device is detected. Signed-off-by: Lars-Peter Clausen --- sound/usb/mixer_quirks.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index e447ddd6854c..d35cf54cab33 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -3360,9 +3360,10 @@ void snd_usb_mixer_fu_apply_quirk(struct usb_mixer_interface *mixer, if (unitid == 7 && cval->control == UAC_FU_VOLUME) snd_dragonfly_quirk_db_scale(mixer, cval, kctl); break; - /* lowest playback value is muted on C-Media devices */ - case USB_ID(0x0d8c, 0x000c): - case USB_ID(0x0d8c, 0x0014): + /* lowest playback value is muted on some devices */ + case USB_ID(0x0d8c, 0x000c): /* C-Media */ + case USB_ID(0x0d8c, 0x0014): /* C-Media */ + case USB_ID(0x19f7, 0x0003): /* RODE NT-USB */ if (strstr(kctl->id.name, "Playback")) cval->min_mute = 1; break; -- 2.30.2