From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A28C433EF for ; Sat, 12 Mar 2022 07:16:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B8098D0003; Sat, 12 Mar 2022 02:16:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 240A08D0001; Sat, 12 Mar 2022 02:16:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E2218D0003; Sat, 12 Mar 2022 02:16:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id EE0278D0001 for ; Sat, 12 Mar 2022 02:16:45 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BB4EF1893 for ; Sat, 12 Mar 2022 07:16:45 +0000 (UTC) X-FDA: 79234876770.14.6BA090E Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf13.hostedemail.com (Postfix) with ESMTP id 14BEB20007 for ; Sat, 12 Mar 2022 07:16:44 +0000 (UTC) Received: by mail-ej1-f42.google.com with SMTP id yy13so23486835ejb.2 for ; Fri, 11 Mar 2022 23:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=fCsAW2UJBB6c8M7QlLxk/JpB7LFkDqCihtv/AG+0X8o=; b=gqlsHeWUslWmzUd/Eur6w3QnGn7z2Zwd53xTFvdB8A32ZYPRsfJNBaAwpSKYMaKBN7 Ow2oIrQFQHSV+lmB4JpCjzVpV2lwJ/YqI/9FSKwQDmDfs9VaBrPJeEKgtx5nwB1Lj2x/ 6+bmSn4/Ei6xKx5X/k4isDUc4/6feXGplx3FStYBqaIVKj0l6LGBxLX3sskLSsysS+dz RbUBSKdevPvprvhQXzMqfkOQ7m6kNdlwRCda0DYDQx+tNNXdjB/tImVE6t7B8C5x68HJ wY5JZZhZoFO7SN/y9eB4vA9xiunMKSr3rXaoa0YlR0eGT7jKk3wZgxmcQPxo8jLz5Fn+ TYcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fCsAW2UJBB6c8M7QlLxk/JpB7LFkDqCihtv/AG+0X8o=; b=DSUQsfIV06vepLnHzsvrfEN1gQB6DoQ0WdFexDS8IsXPbxCoqiiZa/y0GSZHoEnrc6 rrvDowe15AY22jh5uiJwpu8lx6C3uUj59Ic7XipJQykqnzyAsonljJB7jn/6zUOhKl+Y /tZ1C12vCFw3g/4JsE4D6KP/JNFkpGYgqw3r6ymVX509E8zQf2F35tWAplZcvd/UcYrV MhJr1wPxlhNLs+rdWqUAUYaWD2wdWmRaXM46s5clOfr1NFEH21Urvt7QwYM232HV30oQ imy3COKm02ovJtdNFU1zxFwpTXB1I/iTBBjXlupYuHAb1pJAiB9YmdwLCM2Aayn3kSbA unYw== X-Gm-Message-State: AOAM533tjQ4uWxVTX2LBtGNJV60t1EC9gZnHYzsG32mebEcWtmto0pcK skmbtILhhUy/HUVHIGkQ2Xk= X-Google-Smtp-Source: ABdhPJzM8qMnDGTwX/YJSEeKqcXHJnylnQX45G0C/nIhSIh2See/JjfvN6BSKAtcks9RZDlbUar+mg== X-Received: by 2002:a17:907:7ea7:b0:6db:b3c7:95d6 with SMTP id qb39-20020a1709077ea700b006dbb3c795d6mr3155520ejc.480.1647069403462; Fri, 11 Mar 2022 23:16:43 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id q15-20020a056402518f00b00416a3194924sm3788805edd.75.2022.03.11.23.16.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Mar 2022 23:16:42 -0800 (PST) From: Wei Yang To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Wei Yang Subject: [Patch v2 1/3] mm/memcg: mz already removed from rb_tree in mem_cgroup_largest_soft_limit_node() Date: Sat, 12 Mar 2022 07:16:21 +0000 Message-Id: <20220312071623.19050-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 14BEB20007 X-Stat-Signature: ep6gbr5qcnqrichepemj671714pumgub Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gqlsHeWU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-HE-Tag: 1647069404-158882 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When mz is not NULL, mem_cgroup_largest_soft_limit_node() has removed it from rb_tree. Not necessary to call __mem_cgroup_remove_exceeded() again. Signed-off-by: Wei Yang --- mm/memcontrol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index f898320b678a..d70bf5cf04eb 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3458,7 +3458,6 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, nr_reclaimed += reclaimed; *total_scanned += nr_scanned; spin_lock_irq(&mctz->lock); - __mem_cgroup_remove_exceeded(mz, mctz); /* * If we failed to reclaim anything from this memory cgroup -- 2.33.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: [Patch v2 1/3] mm/memcg: mz already removed from rb_tree in mem_cgroup_largest_soft_limit_node() Date: Sat, 12 Mar 2022 07:16:21 +0000 Message-ID: <20220312071623.19050-1-richard.weiyang@gmail.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=fCsAW2UJBB6c8M7QlLxk/JpB7LFkDqCihtv/AG+0X8o=; b=gqlsHeWUslWmzUd/Eur6w3QnGn7z2Zwd53xTFvdB8A32ZYPRsfJNBaAwpSKYMaKBN7 Ow2oIrQFQHSV+lmB4JpCjzVpV2lwJ/YqI/9FSKwQDmDfs9VaBrPJeEKgtx5nwB1Lj2x/ 6+bmSn4/Ei6xKx5X/k4isDUc4/6feXGplx3FStYBqaIVKj0l6LGBxLX3sskLSsysS+dz RbUBSKdevPvprvhQXzMqfkOQ7m6kNdlwRCda0DYDQx+tNNXdjB/tImVE6t7B8C5x68HJ wY5JZZhZoFO7SN/y9eB4vA9xiunMKSr3rXaoa0YlR0eGT7jKk3wZgxmcQPxo8jLz5Fn+ TYcg== List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Wei Yang When mz is not NULL, mem_cgroup_largest_soft_limit_node() has removed it from rb_tree. Not necessary to call __mem_cgroup_remove_exceeded() again. Signed-off-by: Wei Yang --- mm/memcontrol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index f898320b678a..d70bf5cf04eb 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3458,7 +3458,6 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, nr_reclaimed += reclaimed; *total_scanned += nr_scanned; spin_lock_irq(&mctz->lock); - __mem_cgroup_remove_exceeded(mz, mctz); /* * If we failed to reclaim anything from this memory cgroup -- 2.33.1