All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>
Subject: [PATCH v6 13/15] vdpa: Never set log_base addr if SVQ is enabled
Date: Mon, 14 Mar 2022 18:34:53 +0100	[thread overview]
Message-ID: <20220314173455.200342-14-eperezma@redhat.com> (raw)
In-Reply-To: <20220314173455.200342-1-eperezma@redhat.com>

Setting the log address would make the device start reporting invalid
dirty memory because the SVQ vrings are located in qemu's memory.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 hw/virtio/vhost-vdpa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 93dbe1043c..89d59f86f9 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1090,7 +1090,8 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started)
 static int vhost_vdpa_set_log_base(struct vhost_dev *dev, uint64_t base,
                                      struct vhost_log *log)
 {
-    if (vhost_vdpa_one_time_request(dev)) {
+    struct vhost_vdpa *v = dev->opaque;
+    if (v->shadow_vqs_enabled || vhost_vdpa_one_time_request(dev)) {
         return 0;
     }
 
-- 
2.27.0



  parent reply	other threads:[~2022-03-14 17:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 17:34 [PATCH v6 00/15] vDPA shadow virtqueue Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 01/15] vhost: Add VhostShadowVirtqueue Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 02/15] vhost: Add Shadow VirtQueue kick forwarding capabilities Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 03/15] vhost: Add Shadow VirtQueue call " Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 04/15] vhost: Add vhost_svq_valid_features to shadow vq Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 05/15] virtio: Add vhost_svq_get_vring_addr Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 06/15] vdpa: adapt vhost_ops callbacks to svq Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 07/15] vhost: Shadow virtqueue buffers forwarding Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 08/15] util: Add iova_tree_alloc_map Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 09/15] util: add iova_tree_find_iova Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 10/15] vhost: Add VhostIOVATree Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 11/15] vdpa: Add custom IOTLB translations to SVQ Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 12/15] vdpa: Adapt vhost_vdpa_get_vring_base " Eugenio Pérez
2022-03-14 17:34 ` Eugenio Pérez [this message]
2022-03-14 17:34 ` [PATCH v6 14/15] vdpa: Expose VHOST_F_LOG_ALL on SVQ Eugenio Pérez
2022-03-14 17:34 ` [PATCH v6 15/15] vdpa: Add x-svq to NetdevVhostVDPAOptions Eugenio Pérez
2022-03-14 18:13   ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220314173455.200342-14-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.