From: Tom Rini <trini@konsulko.com>
To: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Cc: u-boot@lists.denx.de, Jack Mitchell <ml@embed.me.uk>,
Kever Yang <kever.yang@rock-chips.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Yifeng Zhao <yifeng.zhao@rock-chips.com>,
Samuel Dionne-Riel <samuel@dionne-riel.com>,
Simon Glass <sjg@chromium.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
Stephen Carlson <stcarlso@linux.microsoft.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Michal Simek <michal.simek@xilinx.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Peng Fan <peng.fan@nxp.com>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH v4 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
Date: Mon, 14 Mar 2022 14:14:05 -0400 [thread overview]
Message-ID: <20220314181405.GF9986@bill-the-cat> (raw)
In-Reply-To: <20220128224240.4226-3-alpernebiyasak@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Sat, Jan 29, 2022 at 01:42:37AM +0300, Alper Nebi Yasak wrote:
> The Rockchip RK3399 eMMC PHY has to be power-cycled while changing its
> clock speed to some higher speeds. This is dependent on the desired
> SDHCI clock speed, and it looks like the PHY should be powered off while
> setting the SDHCI clock in these cases.
>
> Commit ac804143cfd1 ("mmc: rockchip_sdhci: add phy and clock config for
> rk3399") attempts to do this in the set_ios_post() hook by setting the
> SDHCI clock once more while the PHY is turned off/on as necessary, as
> the SDHCI framework does not provide a way to override how it sets its
> clock. However, the commit breaks reinitializing the eMMC on a few
> boards including chromebook_kevin and reportedly ROCKPro64.
>
> This patch reworks the power cycling to utilize the SDHCI framework
> slightly better (using the set_control_reg() hook to power off the PHY
> and set_ios_post() hook to power it back on) which happens to fix the
> issue, at least on a chromebook_kevin.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-03-14 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 22:42 [PATCH v4 0/4] rockchip: sdhci: Fix reinit and add HS400 Enhanced Strobe support Alper Nebi Yasak
2022-01-28 22:42 ` [PATCH v4 1/4] mmc: sdhci: Add " Alper Nebi Yasak
2022-01-28 22:42 ` [PATCH v4 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling Alper Nebi Yasak
2022-02-26 18:36 ` Simon Glass
2022-03-14 18:14 ` Tom Rini [this message]
2022-01-28 22:42 ` [PATCH v4 3/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399 Alper Nebi Yasak
2022-02-08 23:39 ` Jaehoon Chung
2022-01-28 22:42 ` [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568 Alper Nebi Yasak
2022-02-08 23:43 ` Jaehoon Chung
2022-02-26 18:36 ` Simon Glass
2022-03-03 8:29 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314181405.GF9986@bill-the-cat \
--to=trini@konsulko.com \
--cc=a-govindraju@ti.com \
--cc=alpernebiyasak@gmail.com \
--cc=ashok.reddy.soma@xilinx.com \
--cc=faiz_abbas@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=jh80.chung@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=michal.simek@xilinx.com \
--cc=ml@embed.me.uk \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=philipp.tomsich@vrull.eu \
--cc=samuel@dionne-riel.com \
--cc=sjg@chromium.org \
--cc=stcarlso@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.