From: Jakub Kicinski <kuba@kernel.org>
To: Roi Dayan <roid@nvidia.com>
Cc: <netdev@vger.kernel.org>, Maor Dickman <maord@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 2/3] net/mlx5e: MPLSoUDP decap, use vlan push_eth instead of pedit
Date: Mon, 14 Mar 2022 22:02:44 -0700 [thread overview]
Message-ID: <20220314220244.5e8e3cb7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220309130256.1402040-3-roid@nvidia.com>
On Wed, 9 Mar 2022 15:02:55 +0200 Roi Dayan wrote:
> + case FLOW_ACTION_VLAN_PUSH_ETH:
> + if (!flow_flag_test(parse_state->flow, L3_TO_L2_DECAP))
> + return -EOPNOTSUPP;
> + parse_state->eth_push = true;
> + memcpy(attr->eth.h_dest, act->vlan_push_eth_dst, ETH_ALEN);
> + memcpy(attr->eth.h_source, act->vlan_push_eth_src, ETH_ALEN);
> + break;
How does the device know the proto? I kind of expected this code will
require some form of a match on proto.
next prev parent reply other threads:[~2022-03-15 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 13:02 [PATCH net-next 0/3] flow_offload: add tc vlan push_eth and pop_eth actions Roi Dayan
2022-03-09 13:02 ` [PATCH net-next 1/3] net/sched: add vlan push_eth and pop_eth action to the hardware IR Roi Dayan
2022-03-15 5:02 ` Jakub Kicinski
2022-03-15 9:53 ` Roi Dayan
2022-03-09 13:02 ` [PATCH net-next 2/3] net/mlx5e: MPLSoUDP decap, use vlan push_eth instead of pedit Roi Dayan
2022-03-15 5:02 ` Jakub Kicinski [this message]
2022-03-15 9:50 ` Roi Dayan
2022-03-15 15:52 ` Jakub Kicinski
2022-03-09 13:02 ` [PATCH net-next 3/3] net/mlx5e: MPLSoUDP encap, support action vlan pop_eth explicitly Roi Dayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314220244.5e8e3cb7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=maord@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.