From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2077469 for ; Mon, 14 Mar 2022 23:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647298938; x=1678834938; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t7C/pcYibGXzuw1c7KT4Go7pZLQBu1j2wb9INd1xCZM=; b=TXWzrIinVGabdNU8yziLIBVl0joTOxV+usC9itSaefyR8RrDrxozn2ru OvhOkD/LkL5U4BakdXJJA9mCSw3uMvgVODaUaoKqT7jRurobZwwGtBhHi vkqaB7JN91VGExDTfI5kvnUrZaKFd11cS4rHwGf0jKAuFSCP3fwYBF/RA 5hI39HtmS48lkCNZykQAHLjlXc6gOWzKiNtIdaXxnHpvhvKzhYee+9Nqd WCnuVmhiRH6QA4L5LQPCZmHgwEFZ7UCD/DJR+wJ1wtM3hNFLSN3i4ReY8 zzlYTT2Vp5dIMhamZGIMap7apFZaVyim0+4e/qmb3nZqrFQZHVSKxHqeG w==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="253725328" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="253725328" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 16:02:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="515638274" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 14 Mar 2022 16:02:13 -0700 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nTthc-000AJg-BB; Mon, 14 Mar 2022 23:02:12 +0000 Date: Tue, 15 Mar 2022 07:02:09 +0800 From: kernel test robot To: Dietmar Eggemann , Darren Hart Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Vincent Guittot , Will Deacon , LKML , Linux Arm , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , Catalin Marinas , Barry Song , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org Subject: Re: [PATCH] arch_topology: Swap MC & CLS SD mask if MC weight==1 & Message-ID: <202203150659.T51bnDgz-lkp@intel.com> References: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Dietmar, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.17-rc8 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4a248f85b3dd8e010ff8335755c927130e9b0764 config: riscv-randconfig-r042-20220314 (https://download.01.org/0day-ci/archive/20220315/202203150659.T51bnDgz-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3e4950d7fa78ac83f33bbf1658e2f49a73719236) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/7528fb2ea1e30038ee1dcc48df9d413502977895 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 git checkout 7528fb2ea1e30038ee1dcc48df9d413502977895 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/base/arch_topology.c:617:23: warning: no previous prototype for function '_cpu_coregroup_mask' [-Wmissing-prototypes] const struct cpumask *_cpu_coregroup_mask(int cpu) ^ drivers/base/arch_topology.c:617:7: note: declare 'static' if the function is not intended to be used outside of this translation unit const struct cpumask *_cpu_coregroup_mask(int cpu) ^ static >> drivers/base/arch_topology.c:634:23: warning: no previous prototype for function '_cpu_clustergroup_mask' [-Wmissing-prototypes] const struct cpumask *_cpu_clustergroup_mask(int cpu) ^ drivers/base/arch_topology.c:634:7: note: declare 'static' if the function is not intended to be used outside of this translation unit const struct cpumask *_cpu_clustergroup_mask(int cpu) ^ static 2 warnings generated. vim +/_cpu_coregroup_mask +617 drivers/base/arch_topology.c 616 > 617 const struct cpumask *_cpu_coregroup_mask(int cpu) 618 { 619 const cpumask_t *core_mask = cpumask_of_node(cpu_to_node(cpu)); 620 621 /* Find the smaller of NUMA, core or LLC siblings */ 622 if (cpumask_subset(&cpu_topology[cpu].core_sibling, core_mask)) { 623 /* not numa in package, lets use the package siblings */ 624 core_mask = &cpu_topology[cpu].core_sibling; 625 } 626 if (cpu_topology[cpu].llc_id != -1) { 627 if (cpumask_subset(&cpu_topology[cpu].llc_sibling, core_mask)) 628 core_mask = &cpu_topology[cpu].llc_sibling; 629 } 630 631 return core_mask; 632 } 633 > 634 const struct cpumask *_cpu_clustergroup_mask(int cpu) 635 { 636 return &cpu_topology[cpu].cluster_sibling; 637 } 638 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27886C433F5 for ; Mon, 14 Mar 2022 23:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ln4xHgQQeWbk6bZGgNLN7x/SxIMAMyXUFLK/oXiwQY=; b=LpeOXOLFz9pLrC XSZer/qW+XQOjtwyr2nmMzOH7PqPk5y/ZpzdyIAa+3VrPQYffgVZfYaOL/oZkt4Ec4FeUrw8Wg+Q3 f0m0ltZoNDhPC1tRuknbwc24qSyo70J90TSmOCwh4zzJBv8+LIQPJwNOaEOJUSNvwIEvecZu4PdgE H6dwH5Wi0zp5MyakWzi85bCWUqFZ8NNv6/LTQwfbmrwck7uwiIgjOK4+ggoYTQqA6ewKydXufgA6s 7gF45zV9WTFrsDmo2gURIjqCdkWtyrqZxCCnGf5GzFlb+vyH4oKV7aU/qbgPlrmYizzYDEh5sIgIT n29FsEGWZNBSKx/EKBrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTthm-0077a6-HA; Mon, 14 Mar 2022 23:02:22 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTthi-0077Z9-9w for linux-arm-kernel@lists.infradead.org; Mon, 14 Mar 2022 23:02:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647298938; x=1678834938; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t7C/pcYibGXzuw1c7KT4Go7pZLQBu1j2wb9INd1xCZM=; b=TXWzrIinVGabdNU8yziLIBVl0joTOxV+usC9itSaefyR8RrDrxozn2ru OvhOkD/LkL5U4BakdXJJA9mCSw3uMvgVODaUaoKqT7jRurobZwwGtBhHi vkqaB7JN91VGExDTfI5kvnUrZaKFd11cS4rHwGf0jKAuFSCP3fwYBF/RA 5hI39HtmS48lkCNZykQAHLjlXc6gOWzKiNtIdaXxnHpvhvKzhYee+9Nqd WCnuVmhiRH6QA4L5LQPCZmHgwEFZ7UCD/DJR+wJ1wtM3hNFLSN3i4ReY8 zzlYTT2Vp5dIMhamZGIMap7apFZaVyim0+4e/qmb3nZqrFQZHVSKxHqeG w==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256115589" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="256115589" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 16:02:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="515638274" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 14 Mar 2022 16:02:13 -0700 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nTthc-000AJg-BB; Mon, 14 Mar 2022 23:02:12 +0000 Date: Tue, 15 Mar 2022 07:02:09 +0800 From: kernel test robot To: Dietmar Eggemann , Darren Hart Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Vincent Guittot , Will Deacon , LKML , Linux Arm , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , Catalin Marinas , Barry Song , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org Subject: Re: [PATCH] arch_topology: Swap MC & CLS SD mask if MC weight==1 & Message-ID: <202203150659.T51bnDgz-lkp@intel.com> References: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_160218_417842_A5848C04 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dietmar, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.17-rc8 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4a248f85b3dd8e010ff8335755c927130e9b0764 config: riscv-randconfig-r042-20220314 (https://download.01.org/0day-ci/archive/20220315/202203150659.T51bnDgz-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3e4950d7fa78ac83f33bbf1658e2f49a73719236) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/7528fb2ea1e30038ee1dcc48df9d413502977895 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 git checkout 7528fb2ea1e30038ee1dcc48df9d413502977895 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/base/arch_topology.c:617:23: warning: no previous prototype for function '_cpu_coregroup_mask' [-Wmissing-prototypes] const struct cpumask *_cpu_coregroup_mask(int cpu) ^ drivers/base/arch_topology.c:617:7: note: declare 'static' if the function is not intended to be used outside of this translation unit const struct cpumask *_cpu_coregroup_mask(int cpu) ^ static >> drivers/base/arch_topology.c:634:23: warning: no previous prototype for function '_cpu_clustergroup_mask' [-Wmissing-prototypes] const struct cpumask *_cpu_clustergroup_mask(int cpu) ^ drivers/base/arch_topology.c:634:7: note: declare 'static' if the function is not intended to be used outside of this translation unit const struct cpumask *_cpu_clustergroup_mask(int cpu) ^ static 2 warnings generated. vim +/_cpu_coregroup_mask +617 drivers/base/arch_topology.c 616 > 617 const struct cpumask *_cpu_coregroup_mask(int cpu) 618 { 619 const cpumask_t *core_mask = cpumask_of_node(cpu_to_node(cpu)); 620 621 /* Find the smaller of NUMA, core or LLC siblings */ 622 if (cpumask_subset(&cpu_topology[cpu].core_sibling, core_mask)) { 623 /* not numa in package, lets use the package siblings */ 624 core_mask = &cpu_topology[cpu].core_sibling; 625 } 626 if (cpu_topology[cpu].llc_id != -1) { 627 if (cpumask_subset(&cpu_topology[cpu].llc_sibling, core_mask)) 628 core_mask = &cpu_topology[cpu].llc_sibling; 629 } 630 631 return core_mask; 632 } 633 > 634 const struct cpumask *_cpu_clustergroup_mask(int cpu) 635 { 636 return &cpu_topology[cpu].cluster_sibling; 637 } 638 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel