From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out.xnet.cz (smtp-out.xnet.cz [178.217.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE3C1B75 for ; Tue, 15 Mar 2022 07:29:08 +0000 (UTC) Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 420E01822C; Tue, 15 Mar 2022 08:29:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=true.cz; s=xnet; t=1647329340; bh=65xHoffDZObM2VcshT2400SVsaHk3C3lcItOW7dYiro=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To; b=LcIHGOxyWO+eN62q6QH5dSr84iz8ODEZ+2nhHHrUG1w6UE9Mbsyr0H+6UP3nbzIEz iL4g6D3ZcfQvtl5m/BPl39+tqWEOqudRSbqqAc9/G/IA561CnJWYn4B635DHO7RPwP FFTlRZGBFvEp1AbDNB2L8qBC5vk6B2GVeGlH8olY= Received: by meh.true.cz (OpenSMTPD) with ESMTP id 7ab44043; Tue, 15 Mar 2022 08:28:36 +0100 (CET) Date: Tue, 15 Mar 2022 08:28:58 +0100 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Greg Kroah-Hartman Cc: Maxime Ripard , Bastien =?utf-8?Q?Roucari=C3=A8s?= , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Message-ID: <20220315072846.GA9129@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <20220308125531.27305-1-ynezz@true.cz> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220308125531.27305-1-ynezz@true.cz> X-PGP-Key: https://gist.githubusercontent.com/ynezz/477f6d7a1623a591b0806699f9fc8a27/raw/a0878b8ed17e56f36ebf9e06a6b888a2cd66281b/pgp-key.pub Petr Štetiar [2022-03-08 13:55:30]: Hi Greg, one week has passed and as I didn't received any feedback, I'm providing more details in a hope to make it more clear, why I think, that this fix is wrong and should be reverted in LTS kernels 5.10 and 5.15. > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks > network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel > KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware > revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was > working on his board. Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions G/G1/G2 utilizing RTL8211E PHY. My understanding is, that up to kernel version 5.9 and specifically commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or RTL8211E PHYs (all HW revisions). At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network stopped working, reverting stable backport commit a90398438517 ("ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it. >From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr > Cc: stable@vger.kernel.org > Cc: Bastien Roucariès > References: https://github.com/openwrt/openwrt/issues/9153 > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt > Signed-off-by: Petr Štetiar > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index ecb91fb899ff..8077f1716fbc 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,7 +112,7 @@ &gmac { > pinctrl-names = "default"; > pinctrl-0 = <&gmac_rgmii_pins>; > phy-handle = <&phy1>; > - phy-mode = "rgmii-id"; > + phy-mode = "rgmii"; > status = "okay"; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E896DC433EF for ; Tue, 15 Mar 2022 07:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0f3w76A1Qm3BOx8xT/o6IAi+XaaDJURPNBvMRTChEPA=; b=lo4/Plp1NbdPNC XazhsaWt1h4t79IrGC3K2nfcfMJT5kSFTARhz869zMUNF5BMXJu6ZHEhQUIk0XklqCIbk9BpR6z/j RkzmH12Sse05lJPo5EEkAf4M6ZFxCXZZ5WMp0Z7iNuXE6jAYtE5fVdi7rw2bOIfgtZ2IKKu47Lxvq UaFpwvrG+on9MZzBpD+Tb2NNeehUDm2uZRybeL49zaFhcdz2dwoN4GZA+ABRXnus5wCceD/jSO9LZ je4jV39Nv1HLlyjz98pZ/xl1xwOjVm0VfDDoL3biV3EhIMUf6/Ou+QNr9sUd/nuZvv1dzyfzidpxM +U5UcTgKSCyZtz9NCe0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU1cG-0086s8-DS; Tue, 15 Mar 2022 07:29:12 +0000 Received: from smtp-out.xnet.cz ([178.217.244.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU1cA-0086pC-96 for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 07:29:08 +0000 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 420E01822C; Tue, 15 Mar 2022 08:29:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=true.cz; s=xnet; t=1647329340; bh=65xHoffDZObM2VcshT2400SVsaHk3C3lcItOW7dYiro=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To; b=LcIHGOxyWO+eN62q6QH5dSr84iz8ODEZ+2nhHHrUG1w6UE9Mbsyr0H+6UP3nbzIEz iL4g6D3ZcfQvtl5m/BPl39+tqWEOqudRSbqqAc9/G/IA561CnJWYn4B635DHO7RPwP FFTlRZGBFvEp1AbDNB2L8qBC5vk6B2GVeGlH8olY= Received: by meh.true.cz (OpenSMTPD) with ESMTP id 7ab44043; Tue, 15 Mar 2022 08:28:36 +0100 (CET) Date: Tue, 15 Mar 2022 08:28:58 +0100 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Greg Kroah-Hartman Cc: Maxime Ripard , Bastien =?utf-8?Q?Roucari=C3=A8s?= , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Message-ID: <20220315072846.GA9129@meh.true.cz> References: <20220308125531.27305-1-ynezz@true.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308125531.27305-1-ynezz@true.cz> X-PGP-Key: https://gist.githubusercontent.com/ynezz/477f6d7a1623a591b0806699f9fc8a27/raw/a0878b8ed17e56f36ebf9e06a6b888a2cd66281b/pgp-key.pub X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_002906_839373_BFF84769 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGV0ciDFoHRldGlhciA8eW5lenpAdHJ1ZS5jej4gWzIwMjItMDMtMDggMTM6NTU6MzBdOgoKSGkg R3JlZywKCm9uZSB3ZWVrIGhhcyBwYXNzZWQgYW5kIGFzIEkgZGlkbid0IHJlY2VpdmVkIGFueSBm ZWVkYmFjaywgSSdtIHByb3ZpZGluZyBtb3JlCmRldGFpbHMgaW4gYSBob3BlIHRvIG1ha2UgaXQg bW9yZSBjbGVhciwgd2h5IEkgdGhpbmssIHRoYXQgdGhpcyBmaXggaXMgd3JvbmcKYW5kIHNob3Vs ZCBiZSByZXZlcnRlZCBpbiBMVFMga2VybmVscyA1LjEwIGFuZCA1LjE1LgoKPiBUaGlzIHJldmVy dHMgY29tbWl0IDU1ZGQ3ZTA1OTA5OGNlNGJkMGE1NWMyNTFjYjc4ZTc0NjA0YWJiNTcgYXMgaXQg YnJlYWtzCj4gbmV0d29yayBvbiBteSBBMjAtb2xpbnV4aW5vLWxpbWUyIGhhcmR3YXJlIHJldmlz aW9uICJLIiB3aGljaCBoYXMgTWljcmVsCj4gS1NaOTAzMVJOWENDLVRSIEdpZ2FiaXQgUEhZLiBC YXN0aWVuIGhhcyBwcm9iYWJseSBzb21lIHByZXZpb3VzIGhhcmR3YXJlCj4gcmV2aXNpb25zIHdo aWNoIHdlcmUgYmFzZWQgb24gUlRMODIxMUUtVkItQ0cxIFBIWSBhbmQgdGh1cyB0aGlzIGZpeCB3 YXMKPiB3b3JraW5nIG9uIGhpcyBib2FyZC4KCkRpc2NsYWltZXIsIEkgZG9uJ3Qgb3duIEEyMC1v bGludXhpbm8tbGltZTIgYm9hcmQgd2l0aCBlYXJsaWVyIEhXIHJldmlzaW9ucwpHL0cxL0cyIHV0 aWxpemluZyBSVEw4MjExRSBQSFkuCgpNeSB1bmRlcnN0YW5kaW5nIGlzLCB0aGF0IHVwIHRvIGtl cm5lbCB2ZXJzaW9uIDUuOSBhbmQgc3BlY2lmaWNhbGx5IGNvbW1pdApiYmM0ZDcxZDYzNTQgKCJu ZXQ6IHBoeTogcmVhbHRlazogZml4IHJ0bDgyMTFlIHJ4L3R4IGRlbGF5IGNvbmZpZyIpIGl0IHdh cwpsaWtlbHkgcG9zc2libGUgdG8gdXNlIHNhbWUgRFRTIGZvciBBMjAtb2xpbnV4aW5vLWxpbWUy IHdpdGggS1NaOTAzMSBvcgpSVEw4MjExRSBQSFlzIChhbGwgSFcgcmV2aXNpb25zKS4KCkF0IGxl YXN0IEkgd2FzIHVzaW5nIG15IEEyMC1vbGludXhpbm8tbGltZTIgSFcgcmV2aXNpb24gSyB3aXRo IEtTWjkwMzEgUEhZCmp1c3QgZmluZSB3aXRoIDQuMTkga2VybmVsLiBBZnRlciB1cGdyYWRlIHRv IDUuMTAgTFRTIGtlcm5lbCBteSBuZXR3b3JrCnN0b3BwZWQgd29ya2luZywgcmV2ZXJ0aW5nIHN0 YWJsZSBiYWNrcG9ydCBjb21taXQgYTkwMzk4NDM4NTE3ICgiQVJNOiBkdHM6CnN1bjdpOiBBMjAt b2xpbnV4aW5vLWxpbWUyOiBGaXggZXRoZXJuZXQgcGh5LW1vZGUiKSBmaXhlZCBpdC4KCkZyb20g bXkgUE9WIHByb3BlciBmaXggZm9yIGVhcmxpZXIgSFcgcmV2aXNpb25zIEcvRzEvRzIgaXMgaW50 cm9kdWN0aW9uIG9mCnN1bjdpLWEyMC1vbGludXhpbm8tbGltZTItcmV2Ry5kdHMgd2l0aCBhIHBy b3BlciBgcGh5LW1vZGVgIGZvciBSVEw4MjExRSBQSFkuCgpDaGVlcnMsCgpQZXRyCgo+IENjOiBz dGFibGVAdmdlci5rZXJuZWwub3JnCj4gQ2M6IEJhc3RpZW4gUm91Y2FyacOocyA8cm91Y2FAZGVi aWFuLm9yZz4KPiBSZWZlcmVuY2VzOiBodHRwczovL2dpdGh1Yi5jb20vb3BlbndydC9vcGVud3J0 L2lzc3Vlcy85MTUzCj4gUmVmZXJlbmNlczogaHR0cHM6Ly9naXRodWIuY29tL09MSU1FWC9PTElO VVhJTk8vYmxvYi9tYXN0ZXIvSEFSRFdBUkUvQTIwLU9MaW51WGluby1MSU1FMi9oYXJkd2FyZV9y ZXZpc2lvbl9jaGFuZ2VzX2xvZy50eHQKPiBTaWduZWQtb2ZmLWJ5OiBQZXRyIMWgdGV0aWFyIDx5 bmV6ekB0cnVlLmN6Pgo+IC0tLQo+ICBhcmNoL2FybS9ib290L2R0cy9zdW43aS1hMjAtb2xpbnV4 aW5vLWxpbWUyLmR0cyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3N1bjdpLWEy MC1vbGludXhpbm8tbGltZTIuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvc3VuN2ktYTIwLW9saW51 eGluby1saW1lMi5kdHMKPiBpbmRleCBlY2I5MWZiODk5ZmYuLjgwNzdmMTcxNmZiYyAxMDA2NDQK PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9zdW43aS1hMjAtb2xpbnV4aW5vLWxpbWUyLmR0cwo+ ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3N1bjdpLWEyMC1vbGludXhpbm8tbGltZTIuZHRzCj4g QEAgLTExMiw3ICsxMTIsNyBAQCAmZ21hYyB7Cj4gIAlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi Owo+ICAJcGluY3RybC0wID0gPCZnbWFjX3JnbWlpX3BpbnM+Owo+ICAJcGh5LWhhbmRsZSA9IDwm cGh5MT47Cj4gLQlwaHktbW9kZSA9ICJyZ21paS1pZCI7Cj4gKwlwaHktbW9kZSA9ICJyZ21paSI7 Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==