All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Petr Štetiar" <ynezz@true.cz>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Bastien Roucariès" <rouca@debian.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	stable@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
Date: Tue, 15 Mar 2022 09:02:06 +0100	[thread overview]
Message-ID: <20220315080206.GA12404@meh.true.cz> (raw)
In-Reply-To: <YjBCImqGsbIZ3IF4@Red>

Corentin Labbe <clabbe.montjoie@gmail.com> [2022-03-15 08:37:06]:

Hi,

> If your patch is applied, older revisions will stop working, right ?

correct, in the same way new revisions stopped working when that wrong fix was
applied.

> What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

WARNING: multiple messages have this Message-ID
From: "Petr Štetiar" <ynezz@true.cz>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Bastien Roucariès" <rouca@debian.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	stable@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
Date: Tue, 15 Mar 2022 09:02:06 +0100	[thread overview]
Message-ID: <20220315080206.GA12404@meh.true.cz> (raw)
In-Reply-To: <YjBCImqGsbIZ3IF4@Red>

Corentin Labbe <clabbe.montjoie@gmail.com> [2022-03-15 08:37:06]:

Hi,

> If your patch is applied, older revisions will stop working, right ?

correct, in the same way new revisions stopped working when that wrong fix was
applied.

> What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-15  8:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 12:55 Petr Štetiar
2022-03-08 12:55 ` Petr Štetiar
2022-03-15  7:28 ` Petr Štetiar
2022-03-15  7:28   ` Petr Štetiar
2022-03-15  7:37   ` Corentin Labbe
2022-03-15  7:37     ` Corentin Labbe
2022-03-15  8:02     ` Petr Štetiar [this message]
2022-03-15  8:02       ` Petr Štetiar
2022-03-15  7:51   ` Greg Kroah-Hartman
2022-03-15  7:51     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315080206.GA12404@meh.true.cz \
    --to=ynezz@true.cz \
    --cc=clabbe.montjoie@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rouca@debian.org \
    --cc=stable@vger.kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.