All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 2/2] drm/i915/intel_combo_phy: Print procmon ref values
Date: Tue, 15 Mar 2022 13:32:47 +0530	[thread overview]
Message-ID: <20220315080247.1161844-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20220315080247.1161844-1-ankit.k.nautiyal@intel.com>

Add debug print for Procmon Ref values, to help get the
voltage configurations of combo PHYs.

v2: Used drm_dbg_kms for logs. (Jani)
Added names for different voltage levels. (Imre)

Suggested-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index 4dfe77351b8b..7ccf45578a7f 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -25,18 +25,29 @@ enum {
 };
 
 static const struct icl_procmon {
+	char name[30];
 	u32 dw1, dw9, dw10;
 } icl_procmon_values[] = {
-	[PROCMON_0_85V_DOT_0] =
-		{ .dw1 = 0x00000000, .dw9 = 0x62AB67BB, .dw10 = 0x51914F96, },
-	[PROCMON_0_95V_DOT_0] =
-		{ .dw1 = 0x00000000, .dw9 = 0x86E172C7, .dw10 = 0x77CA5EAB, },
-	[PROCMON_0_95V_DOT_1] =
-		{ .dw1 = 0x00000000, .dw9 = 0x93F87FE1, .dw10 = 0x8AE871C5, },
-	[PROCMON_1_05V_DOT_0] =
-		{ .dw1 = 0x00000000, .dw9 = 0x98FA82DD, .dw10 = 0x89E46DC1, },
-	[PROCMON_1_05V_DOT_1] =
-		{ .dw1 = 0x00440000, .dw9 = 0x9A00AB25, .dw10 = 0x8AE38FF1, },
+	[PROCMON_0_85V_DOT_0] = {
+		.name = "0.85V dot0 (low-voltage)\0",
+		.dw1 = 0x00000000, .dw9 = 0x62AB67BB, .dw10 = 0x51914F96,
+	},
+	[PROCMON_0_95V_DOT_0] = {
+		.name = "0.95V dot0\0",
+		.dw1 = 0x00000000, .dw9 = 0x86E172C7, .dw10 = 0x77CA5EAB,
+	},
+	[PROCMON_0_95V_DOT_1] = {
+		.name = "0.95V dot1\0",
+		.dw1 = 0x00000000, .dw9 = 0x93F87FE1, .dw10 = 0x8AE871C5,
+	},
+	[PROCMON_1_05V_DOT_0] = {
+		.name = "1.05V dot0\0",
+		.dw1 = 0x00000000, .dw9 = 0x98FA82DD, .dw10 = 0x89E46DC1,
+	},
+	[PROCMON_1_05V_DOT_1] = {
+		.name = "1.05V dot1\0",
+		.dw1 = 0x00440000, .dw9 = 0x9A00AB25, .dw10 = 0x8AE38FF1,
+	},
 };
 
 static const struct icl_procmon *
@@ -113,6 +124,11 @@ static bool icl_verify_procmon_ref_values(struct drm_i915_private *dev_priv,
 
 	procmon = icl_get_procmon_ref_values(dev_priv, phy);
 
+	drm_dbg_kms(&dev_priv->drm,
+		    "Combo PHY %c %s PROCMON values : 0x%x, 0x%x, 0x%x\n",
+		    phy_name(phy), procmon->name, procmon->dw1, procmon->dw9,
+		    procmon->dw10);
+
 	ret = check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW1(phy),
 			    (0xff << 16) | 0xff, procmon->dw1);
 	ret &= check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW9(phy),
-- 
2.25.1


  parent reply	other threads:[~2022-03-15  8:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  8:02 [Intel-gfx] [PATCH v3 0/2] Remove check for ComboPHY I/O voltage for DP source rate Ankit Nautiyal
2022-03-15  8:02 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/display: Remove check for low voltage sku for max dp " Ankit Nautiyal
2022-03-15  8:02 ` Ankit Nautiyal [this message]
2022-03-15  8:38   ` [Intel-gfx] [PATCH v3 2/2] drm/i915/intel_combo_phy: Print procmon ref values Jani Nikula
2022-03-15 10:12     ` Nautiyal, Ankit K
2022-03-15  9:57   ` [Intel-gfx] [PATCH v4 " Ankit Nautiyal
2022-03-21 11:36     ` Imre Deak
2022-03-23  9:43     ` [Intel-gfx] [PATCH v5 2/2] drm/i915/intel_combo_phy: Print I/O voltage info Ankit Nautiyal
2022-03-15  8:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Remove check for ComboPHY I/O voltage for DP source rate (rev3) Patchwork
2022-03-15 10:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-03-15 11:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Remove check for ComboPHY I/O voltage for DP source rate (rev4) Patchwork
2022-03-15 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-23 11:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Remove check for ComboPHY I/O voltage for DP source rate (rev5) Patchwork
2022-03-23 11:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-23 14:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-25  9:49   ` Nautiyal, Ankit K
2022-03-25 16:14     ` Vudum, Lakshminarayana
2022-03-25 16:08 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2022-03-28 12:00   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315080247.1161844-3-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.