From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 128DEC433F5 for ; Tue, 15 Mar 2022 12:23:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F242C8399B; Tue, 15 Mar 2022 13:23:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D1DC8/gY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9712883AAA; Tue, 15 Mar 2022 13:23:03 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1DFE58399B for ; Tue, 15 Mar 2022 13:22:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id kj21so11932066qvb.11 for ; Tue, 15 Mar 2022 05:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gv3sozpzcLhbGh6NsuGXkAFY74zZdTR6Kiz2YTStLag=; b=D1DC8/gYTNfc3e45UO2dU60l4PTERXz517+zeqlePe3yYBYtynioXqqEZggXs467zn aMbGFhJNpDRFPLPM0wifmRCC8i+viRZX0Ot0cbMXJdrFCYGfr0zLh3UMR5aqKsWDnGu5 nnWRwSo4tF5n9kPBBPd4kW8PueRKAtfxOaySI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gv3sozpzcLhbGh6NsuGXkAFY74zZdTR6Kiz2YTStLag=; b=CVL/+4TAuhHI6op2rrARHfS4BQVicBjOVEzxOUsLgCzM03NjT+H6nP6bLUIEdBVnEe 1+Fu93fRD2psh/TAhVN032hRd/CunQprRg7SRQjil9Kv1GIYj0fxy6e3wUVrEjirdh1v x7oNWGTurpVmZmee9bGaOQMfhkCK2NFag4Js36PLRgB1jzaVSsUbwj1qLjnverxGFcP8 X6J9Rb6qxOD8yXXseOJ3ywsBno1UPE9OCkmg0CjgvDwDxeh4H2H/vo/LerLhymBhiphm 3No1IemmIcW8RuHeEBURIRlVpTE8GMBf3W6aDvFu3PE8Je0gvrr3f57/Hgh0Gw0yGMMh 0mrw== X-Gm-Message-State: AOAM53147ch74bv5ZmupMfnzuhs4W90kFoxm4Iz/jvwvOseol7XywpiD v5lLxRkd82nQr+cXIKOtYQZXZw== X-Google-Smtp-Source: ABdhPJxkiOsash50dbW3ZFtHNmO4rwpHF0h/EP6uQMC2M7ZMhyKVAjQ5oXVewADHX82Fjqq73epXeA== X-Received: by 2002:ad4:5f8c:0:b0:440:a5a5:dbb2 with SMTP id jp12-20020ad45f8c000000b00440a5a5dbb2mr8832047qvb.92.1647346977787; Tue, 15 Mar 2022 05:22:57 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id o21-20020ac85a55000000b002e16389b501sm12816366qta.96.2022.03.15.05.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 05:22:57 -0700 (PDT) Date: Tue, 15 Mar 2022 08:22:55 -0400 From: Tom Rini To: Robert Marko Cc: Jaehoon Chung , Stefan Roese , peng.fan@nxp.com, stcarlso@linux.microsoft.com, U-Boot-Denx , Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP Message-ID: <20220315122255.GX9986@bill-the-cat> References: <20220311181407.1930327-1-robert.marko@sartura.hr> <39424ebb-eac3-7c94-20e0-02a73fa538e1@samsung.com> <20220314131010.GY9986@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k1z90nur9s/yY9w9" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --k1z90nur9s/yY9w9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 15, 2022 at 10:47:57AM +0100, Robert Marko wrote: > On Mon, Mar 14, 2022 at 2:10 PM Tom Rini wrote: > > > > On Mon, Mar 14, 2022 at 06:37:02PM +0900, Jaehoon Chung wrote: > > > On 3/12/22 03:14, Robert Marko wrote: > > > > Generic SDHCI driver received support for checking the busy status = by > > > > polling the DAT[0] level instead of waiting for the worst MMC switc= h time. > > > > > > > > Unfortunately, it appears that this does not work for Xenon control= lers > > > > despite being a part of the standard SDHCI registers and the Armada= 3720 > > > > datasheet itself telling that BIT(20) is useful for detecting the D= AT[0] > > > > busy signal. > > > > > > > > I have tried increasing the timeout value, but I have newer managed= to > > > > catch DAT_LEVEL bits change from 0 at all. > > > > > > > > This issue appears to hit most if not all SoC-s supported by Xenon = driver, > > > > at least A3720, A8040 and CN9130 have non working eMMC currently. > > > > > > > > So, until a better solution is found drop the wait_dat0 OP for Xeno= n. > > > > I was able to only test it on A3720, but it should work for others = as well. > > > > > > > > Fixes: 40e6f52454fc ("drivers: mmc: Add wait_dat0 support for sdhci= driver") > > > > Signed-off-by: Robert Marko > > > > > > Reviewed-by: Jaehoon Chung > > > > Since this is a regression fix, will this be in the PR with the imx fix > > as well? Thanks! >=20 > Hi Tom, > Was this question directed at me or? Sorry, to Jaehoon or Peng. --=20 Tom --k1z90nur9s/yY9w9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIwhR8ACgkQFHw5/5Y0 tyxzRwwAoIxmKQjM7rsfF/VHYvW1DTfUNcwmhgSInjgzYhQsQOEhiGcKcC36Fngl eIwwlrJMJK4dlUC4b3rsU4VnkZJUxuP8xGTUqxTf6YuuMJNJw/O/sphCjMhXkrXF lErA4tkQXvylig0HC7lTGv7nGQBDnk/5sQyu62RSE79bbN3LsxHrs34Td50W8Jta PTICBFc6RsliUnwyT7xYtqUvfqtTQ9kKWvn4H/QrANig2FkP0prXMYnG1DOfwXd6 a+mSZSSQcv7EfYf7egWTdT7z3i6TZw3YKhS6h/PRy7g+zNB263SkBx/vd+vIfhOP 1d7uxE+9akg+Lbp5UHNCD0PCZzZORgGIhjFysPOKFxG4WOi89I7zsUBMc513yJ73 PhnHeQAsIr3/6/cTPjfeeFDDGQW37+D8yU/wfIZbIQJvSvgmjvk6ZNLY0gCOoa4a 5NXv6mf2r2GSDMznUuXeIS9RCENe4C9SGp7Z8yCUU65OmxmFz2NQN7RjhfRMeU0e f6IG/mzj =TAtd -----END PGP SIGNATURE----- --k1z90nur9s/yY9w9--