All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [CI 3/7] drm/i915/stolen: consider I915_BO_ALLOC_GPU_ONLY
Date: Tue, 15 Mar 2022 18:14:21 +0000	[thread overview]
Message-ID: <20220315181425.576828-3-matthew.auld@intel.com> (raw)
In-Reply-To: <20220315181425.576828-1-matthew.auld@intel.com>

Keep the behaviour consistent with normal lmem, where we assume CPU
access if by default required.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index b860ec954104..17f35892ab7e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -695,6 +695,14 @@ static int _i915_gem_object_stolen_init(struct intel_memory_region *mem,
 	if (size == 0)
 		return -EINVAL;
 
+	/*
+	 * With discrete devices, where we lack a mappable aperture there is no
+	 * possible way to ever access this memory on the CPU side.
+	 */
+	if (mem->type == INTEL_MEMORY_STOLEN_LOCAL && !mem->io_size &&
+	    !(flags & I915_BO_ALLOC_GPU_ONLY))
+		return -ENOSPC;
+
 	stolen = kzalloc(sizeof(*stolen), GFP_KERNEL);
 	if (!stolen)
 		return -ENOMEM;
-- 
2.34.1


  parent reply	other threads:[~2022-03-15 18:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 18:14 [Intel-gfx] [CI 1/7] drm/i915/lmem: don't treat small BAR as an error Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 2/7] drm/i915/stolen: " Matthew Auld
2022-03-15 18:14 ` Matthew Auld [this message]
2022-03-15 18:14 ` [Intel-gfx] [CI 4/7] drm/i915: add i915_gem_object_create_region_at() Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 5/7] drm/i915/ttm: wire up the object offset Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 6/7] drm/i915/display: Check mappable aperture when pinning preallocated vma Matthew Auld
2022-03-15 18:14 ` [Intel-gfx] [CI 7/7] drm/i915: fixup the initial fb base on DGFX Matthew Auld
2022-03-15 20:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915/lmem: don't treat small BAR as an error Patchwork
2022-03-15 20:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-16  0:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-16  9:15   ` Matthew Auld
2022-03-16 16:50     ` Vudum, Lakshminarayana
2022-03-16 15:53 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315181425.576828-3-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.