From: Jakub Kicinski <kuba@kernel.org>
To: Roopa Prabhu <roopa@nvidia.com>
Cc: Jie Wang <wangjie125@huawei.com>,
mkubecek@suse.cz, davem@davemloft.net, netdev@vger.kernel.org,
huangguangbin2@huawei.com, lipeng321@huawei.com,
shenjian15@huawei.com, moyufeng@huawei.com,
linyunsheng@huawei.com, tanhuazhong@huawei.com,
salil.mehta@huawei.com, chenhao288@hisilicon.com
Subject: Re: [RFC net-next 1/2] net: ethtool: add ethtool ability to set/get fresh device features
Date: Tue, 15 Mar 2022 18:40:13 -0700 [thread overview]
Message-ID: <20220315184013.0b5970c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <59620a57-f465-917f-1773-65fcf594d3aa@nvidia.com>
On Tue, 15 Mar 2022 13:03:00 -0700 Roopa Prabhu wrote:
> > I'd be curious to hear more opinions on whether we want to create a new
> > command or use another method for setting this bit, and on the concept
> > of "devfeatures" in general.
> >
> > One immediate feedback is that we're not adding any more commands to
> > the ioctl API. You'll need to implement it in the netlink version of
> > the ethtool API.
>
> +1, it would have been nice if we did not have to expose the change in
> api for features via a new option.
>
> harder for user to track which features need new option.
>
> ie, if possible, it would be better to internally transition new
> features to new api.
>
> (i have not looked yet if moving to netlink will make the above point moot)
The slight wrinkle on the usual feature API is that it's out of bits
and the work on moving it to bitmap has stalled :S
next prev parent reply other threads:[~2022-03-16 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 3:21 [RFC net-next 0/2] add ethtool ops support for fresh device features Jie Wang
2022-03-15 3:21 ` [RFC net-next 1/2] net: ethtool: add ethtool ability to set/get " Jie Wang
2022-03-15 19:15 ` Jakub Kicinski
2022-03-15 19:56 ` Michal Kubecek
2022-03-16 1:45 ` Jakub Kicinski
2022-03-21 6:17 ` wangjie (L)
2022-03-21 18:20 ` Jakub Kicinski
2022-03-15 20:03 ` Roopa Prabhu
2022-03-16 1:40 ` Jakub Kicinski [this message]
2022-03-15 19:18 ` Michal Kubecek
2022-03-18 6:28 ` wangjie (L)
2022-03-15 3:21 ` [RFC net-next 2/2] net: hns3: add ethtool set/get device features support for hns3 driver Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315184013.0b5970c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=wangjie125@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.