From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DAE6C433F5 for ; Thu, 17 Mar 2022 07:01:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 99B1B18B3; Thu, 17 Mar 2022 08:00:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 99B1B18B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647500487; bh=xBvEfgzSVHr9TXLCfWQ3iHR4Dxd7SEZTbvU1eyBowVY=; h=In-Reply-To:References:Subject:From:To:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SY/2dcNyVdphdCKmXeHNDFoCkj73lyzhIqUa4bmRG2AisUjG5CB4bpGGnlVkaELTT R1xt1LQV5SzGHnkps+3D3LTh7UqBcBChMwzI6AS0Z0YpDGtdz8BmLuE3Mo+iGW6RAQ MXRSvjDnbi7XqhrDBnG18RkpTqX4s/kZAR61ZAYA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24D0AF805B4; Thu, 17 Mar 2022 07:55:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5DFBFF80095; Tue, 15 Mar 2022 21:13:30 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 273ABF80095 for ; Tue, 15 Mar 2022 21:13:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 273ABF80095 Authentication-Results: alsa1.perex.cz; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bmFmyd/3" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D76CAB8181C; Tue, 15 Mar 2022 20:13:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AADBC340E8; Tue, 15 Mar 2022 20:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647375201; bh=xBvEfgzSVHr9TXLCfWQ3iHR4Dxd7SEZTbvU1eyBowVY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=bmFmyd/3t561qn70PynZc8TtWSsNv8oBdsIscAy5k9B6hLz3ghgzcZ1jUgfmFhahX Dzd5t8OE/9EA1h6nwm/ckaqMhvX6vp56V8Jv3ZZ35GobPnXRlHC9JRWrDYKnAUL3uk vR4k1+h4FQzAKcOwa5g8QEHSxXNUQujOZYWrdTEm/MFmB7vAUNYEdKp6RU9hnf0s/O aLB0dMvQTpBgdrQUgMbYChJhlIAXqJHd4PwXdlsiVKFByuD0f9/fFd6uO2RdxQWl0C vkqpVVoANZEYMHhfev7Ugk3MJUmsg0/9wt6KPjhsQUucswqI72i7ij76ubIX3q8Xdv 1HxN2VoUSsT3Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220312132856.65163-10-krzysztof.kozlowski@canonical.com> References: <20220312132856.65163-1-krzysztof.kozlowski@canonical.com> <20220312132856.65163-10-krzysztof.kozlowski@canonical.com> Subject: Re: [PATCH v4 09/11] clk: imx: scu: Fix kfree() of static memory on setting driver_override From: Stephen Boyd To: Greg Kroah-Hartman , Krzysztof Kozlowski , Rafael J. Wysocki Date: Tue, 15 Mar 2022 13:13:19 -0700 User-Agent: alot/0.10 Message-Id: <20220315201321.8AADBC340E8@smtp.kernel.org> X-Mailman-Approved-At: Thu, 17 Mar 2022 07:55:06 +0100 Cc: linux-hyperv@vger.kernel.org, Stuart Yoder , "Michael S.Tsirkin" , linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, Bjorn Andersson , Srinivas Kandagatla , Vineeth Vijayan , Jason Wang <"jasow ang"@redhat.com>, Alexander Gordeev , "K.Y.Srinivasan" , Fabio Estevam , linux-clk@vger.kernel.org, linux-s390@vger.kernel.org, Wei Liu , Stephen Hemminger , Abel Vesa , Krzysztof Kozlowski , Dexuan Cui , Andy Gross , NXP Linux Team , Christian Borntraeger , Heiko Carstens , Vasily Gorbik , linux-arm-msm@vger.kernel.org, Sascha Hauer , linux-spi@vger.kernel.org, Mark Brown , Rasmus Villemoes , Bjorn Helgaas , virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Laurentiu Tudor , Mathieu Poirier , Linus Torvalds , Haiyang Zhang , Peter Oberparleiter , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Sven Schnelle , Shawn Guo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Quoting Krzysztof Kozlowski (2022-03-12 05:28:54) > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. >=20 > Use dedicated helper to set driver_override properly. >=20 > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: Stephen Boyd