All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Jan Kara <jack@suse.cz>, "Darrick J . Wong" <djwong@kernel.org>,
	linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 2/8] loop: initialize the worker tracking fields once
Date: Wed, 16 Mar 2022 09:45:13 +0100	[thread overview]
Message-ID: <20220316084519.2850118-3-hch@lst.de> (raw)
In-Reply-To: <20220316084519.2850118-1-hch@lst.de>

There is no need to reinitialize idle_worker_list, worker_tree and timer
every time a loop device is configured.  Just initialize them once at
allocation time.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Tested-by: Darrick J. Wong <djwong@kernel.org>
---
 drivers/block/loop.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 64227e659efc4..2d344fefda6b8 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1057,10 +1057,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
 
 	INIT_WORK(&lo->rootcg_work, loop_rootcg_workfn);
 	INIT_LIST_HEAD(&lo->rootcg_cmd_list);
-	INIT_LIST_HEAD(&lo->idle_worker_list);
-	lo->worker_tree = RB_ROOT;
-	timer_setup(&lo->timer, loop_free_idle_workers_timer,
-		TIMER_DEFERRABLE);
 	lo->use_dio = lo->lo_flags & LO_FLAGS_DIRECT_IO;
 	lo->lo_device = bdev;
 	lo->lo_backing_file = file;
@@ -1973,6 +1969,9 @@ static int loop_add(int i)
 	lo = kzalloc(sizeof(*lo), GFP_KERNEL);
 	if (!lo)
 		goto out;
+	lo->worker_tree = RB_ROOT;
+	INIT_LIST_HEAD(&lo->idle_worker_list);
+	timer_setup(&lo->timer, loop_free_idle_workers_timer, TIMER_DEFERRABLE);
 	lo->lo_state = Lo_unbound;
 
 	err = mutex_lock_killable(&loop_ctl_mutex);
-- 
2.30.2


  parent reply	other threads:[~2022-03-16  8:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  8:45 yet another approach to fix the loop lock order inversions v3 Christoph Hellwig
2022-03-16  8:45 ` [PATCH 1/8] loop: de-duplicate the idle worker freeing code Christoph Hellwig
2022-03-16  8:45 ` Christoph Hellwig [this message]
2022-03-16  9:26   ` [PATCH 2/8] loop: initialize the worker tracking fields once Chaitanya Kulkarni
2022-03-16  8:45 ` [PATCH 3/8] loop: remove the racy bd_inode->i_mapping->nrpages asserts Christoph Hellwig
2022-03-16 10:24   ` Jan Kara
2022-03-16  8:45 ` [PATCH 4/8] loop: don't freeze the queue in lo_release Christoph Hellwig
2022-03-16  8:45 ` [PATCH 5/8] loop: only freeze the queue in __loop_clr_fd when needed Christoph Hellwig
2022-03-16  8:45 ` [PATCH 6/8] loop: implement ->free_disk Christoph Hellwig
2022-03-16 10:30   ` Jan Kara
2022-03-16  8:45 ` [PATCH 7/8] loop: remove lo_refcount and avoid lo_mutex in ->open / ->release Christoph Hellwig
2022-03-16 11:22   ` Jan Kara
2022-03-16 13:14     ` Tetsuo Handa
2022-03-16 14:38       ` Jan Kara
2022-03-22 11:09         ` Christoph Hellwig
2022-03-23 12:18           ` Jan Kara
2022-03-23 13:09             ` Tetsuo Handa
2022-03-16  8:45 ` [PATCH 8/8] loop: don't destroy lo->workqueue in __loop_clr_fd Christoph Hellwig
2022-03-16 11:25   ` Jan Kara
2022-03-16 13:24     ` Tetsuo Handa
2022-03-22 11:10       ` Christoph Hellwig
2022-03-22 12:42         ` Tetsuo Handa
2022-03-23  0:06           ` Tetsuo Handa
2022-03-16 10:59 ` yet another approach to fix the loop lock order inversions v3 Tetsuo Handa
2022-03-22 11:12   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2022-01-28 13:00 yet another approach to fix loop autoclear for xfstets xfs/049 v2 Christoph Hellwig
2022-01-28 13:00 ` [PATCH 2/8] loop: initialize the worker tracking fields once Christoph Hellwig
2022-01-26 15:50 yet another approach to fix loop autoclear for xfstets xfs/049 Christoph Hellwig
2022-01-26 15:50 ` [PATCH 2/8] loop: initialize the worker tracking fields once Christoph Hellwig
2022-01-27  9:45   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220316084519.2850118-3-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=djwong@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.