From: Jakub Kicinski <kuba@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
xeb@mail.ru, David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Menglong Dong <imagedong@tencent.com>,
Eric Dumazet <edumazet@google.com>, Martin Lau <kafai@fb.com>,
Talal Ahmad <talalahmad@google.com>,
Kees Cook <keescook@chromium.org>,
Alexander Lobakin <alobakin@pm.me>,
Hao Peng <flyingpeng@tencent.com>,
Mengen Sun <mengensun@tencent.com>,
dongli.zhang@oracle.com, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Biao Jiang <benbjiang@tencent.com>
Subject: Re: [PATCH net-next 3/3] net: ipgre: add skb drop reasons to gre_rcv()
Date: Wed, 16 Mar 2022 11:51:04 -0700 [thread overview]
Message-ID: <20220316115104.25ad2605@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CADxym3Yj58gXe9kHRxNvxxMfNMYjvzbrdcq7sNAo6SQHXb98nQ@mail.gmail.com>
On Wed, 16 Mar 2022 14:21:24 +0800 Menglong Dong wrote:
> > ipgre_rcv() OTOH may be better off taking the reason as an output
> > argument. Assuming PACKET_REJECT means NOMEM is a little fragile.
>
> Yeah, it seems not friendly. I think it's ok to ignore such 'NOMEM' reasons?
> Therefore, we only need to consider the PACKET_NEXT return value, and
> keep ipgre_rcv() still.
SGTM.
prev parent reply other threads:[~2022-03-16 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 13:33 [PATCH net-next 0/3] net: gre: add skb drop reasons to gre packet receive menglong8.dong
2022-03-14 13:33 ` [PATCH net-next 1/3] net: gre_demux: add skb drop reasons to gre_rcv() menglong8.dong
2022-03-16 3:08 ` Jakub Kicinski
2022-03-16 3:49 ` David Ahern
2022-03-16 4:53 ` Menglong Dong
2022-03-16 14:45 ` David Ahern
2022-03-16 4:55 ` Jakub Kicinski
2022-03-16 10:12 ` David Laight
2022-03-16 18:55 ` Jakub Kicinski
2022-03-16 14:56 ` David Ahern
2022-03-16 18:57 ` Jakub Kicinski
2022-03-16 21:05 ` David Ahern
2022-03-16 4:41 ` Menglong Dong
2022-03-16 4:50 ` Jakub Kicinski
2022-03-14 13:33 ` [PATCH net-next 2/3] net: ipgre: make erspan_rcv() return PACKET_NEXT menglong8.dong
2022-03-14 13:33 ` [PATCH net-next 3/3] net: ipgre: add skb drop reasons to gre_rcv() menglong8.dong
2022-03-16 3:17 ` Jakub Kicinski
2022-03-16 6:21 ` Menglong Dong
2022-03-16 18:50 ` Jakub Kicinski
2022-03-16 18:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316115104.25ad2605@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alobakin@pm.me \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.