From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A1E0C433F5 for ; Wed, 16 Mar 2022 19:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243097AbiCPTPI (ORCPT ); Wed, 16 Mar 2022 15:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239247AbiCPTPH (ORCPT ); Wed, 16 Mar 2022 15:15:07 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95B6F28E35 for ; Wed, 16 Mar 2022 12:13:53 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nUZ5j-0007nc-S5; Wed, 16 Mar 2022 20:13:51 +0100 Date: Wed, 16 Mar 2022 20:13:51 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH 3/3] libxtables: Boost rule target checks by announcing chain names Message-ID: <20220316191351.GG9936@breakpoint.cc> References: <20220316174443.1930-1-phil@nwl.cc> <20220316174443.1930-4-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220316174443.1930-4-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > When restoring a ruleset, feed libxtables with chain names from > respective lines to avoid an extension search. > > While the user's intention is clear, this effectively disables the > sanity check for clashes with target extensions. But: > > * The check yielded only a warning and the clashing chain was finally > accepted. > > * Users crafting iptables dumps for feeding into iptables-restore likely > know what they're doing. Acked-by: Florian Westphal