From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECC3C43217 for ; Wed, 16 Mar 2022 19:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245535AbiCPTVi (ORCPT ); Wed, 16 Mar 2022 15:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235986AbiCPTVh (ORCPT ); Wed, 16 Mar 2022 15:21:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706B6532CF; Wed, 16 Mar 2022 12:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=X2j8KWKH7mPGrGuSOCsj6/Zr05knYdm/d0qKjoRqe/A=; b=bdC3zFz0aD/kHDcjfAyZbfQHBp 7D/NlBM1amLmkH4B4sqKV2ufqUvJD88hTlKpyZ6VqDgekjK4FNGYILRpxkEqmQPADEL6WPYAAzU3c Sgrf+0emCMPKxF4geOisKrAEZIi126v6w7X5ziKEvg+Vo5Kfv7gQeEp68Rya/2NrsCbuCdD1F1eRO BniaXaZDMgIYFHq/3z0YvLS2w5qVtTdqdrrvR04+Nr2xp3obBSzkGzIwryyT9w7ppsZfrvdhEgpU1 CvVbeb1+V8VRryF0rtfXsRiz/tX5kbeNaIbViAt6lEitADJHoianGTvyLAizZrpPdjB0SFmWrUO/U gzvEtNsQ==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZBu-00EArp-Lx; Wed, 16 Mar 2022 19:20:14 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Date: Wed, 16 Mar 2022 12:20:01 -0700 Message-Id: <20220316192010.19001-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org There are a number of drivers that use "module_init(init)" and "module_exit(exit)", which are anonymous names and can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ffffffff832fc78c t init ffffffff832fc79e t init ffffffff832fc8f8 t init ffffffff832fca05 t init ffffffff832fcbd2 t init ffffffff83328f0e t init ffffffff8332c5b1 t init ffffffff8332d9eb t init ffffffff8332f0aa t init ffffffff83330e25 t init ffffffff833317a5 t init ffffffff8333dd6b t init Example 2: (initcall_debug log) calling init+0x0/0x12 @ 1 initcall init+0x0/0x12 returned 0 after 15 usecs calling init+0x0/0x60 @ 1 initcall init+0x0/0x60 returned 0 after 2 usecs calling init+0x0/0x9a @ 1 initcall init+0x0/0x9a returned 0 after 74 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 6 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 4 usecs calling init+0x0/0xf5 @ 1 initcall init+0x0/0xf5 returned 0 after 27 usecs calling init+0x0/0x7d @ 1 initcall init+0x0/0x7d returned 0 after 11 usecs calling init+0x0/0xc9 @ 1 initcall init+0x0/0xc9 returned 0 after 19 usecs calling init+0x0/0x9d @ 1 initcall init+0x0/0x9d returned 0 after 37 usecs calling init+0x0/0x63f @ 1 initcall init+0x0/0x63f returned 0 after 411 usecs calling init+0x0/0x171 @ 1 initcall init+0x0/0x171 returned 0 after 61 usecs calling init+0x0/0xef @ 1 initcall init+0x0/0xef returned 0 after 3 usecs Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: Jens Axboe Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Eli Cohen Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: "David S. Miller" Cc: Jakub Kicinski Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Felipe Balbi Cc: Michał Mirosław Cc: Sebastian Andrzej Siewior Cc: Krzysztof Opasiak Cc: Igor Kotrasinski Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: Jussi Kivilinna Cc: Joachim Fritschi Cc: Herbert Xu Cc: Thomas Gleixner Cc: Steven Rostedt Cc: Ingo Molnar Cc: Karol Herbst Cc: Pekka Paalanen Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org Cc: netdev@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-rdma@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: virtualization@lists.linux-foundation.org Cc: x86@kernel.org patches: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit diffstat: arch/x86/crypto/blowfish_glue.c | 8 ++++---- arch/x86/crypto/camellia_glue.c | 8 ++++---- arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- arch/x86/mm/testmmiotrace.c | 8 ++++---- drivers/block/virtio_blk.c | 8 ++++---- drivers/char/virtio_console.c | 8 ++++---- drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- drivers/scsi/virtio_scsi.c | 8 ++++---- drivers/usb/gadget/legacy/inode.c | 8 ++++---- drivers/usb/gadget/legacy/serial.c | 10 +++++----- drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- drivers/usb/usbip/vudc_main.c | 8 ++++---- net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- 15 files changed, 61 insertions(+), 61 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6E96C433F5 for ; Wed, 16 Mar 2022 19:21:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 50B1C41823; Wed, 16 Mar 2022 19:21:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xI-dzO8z8nGP; Wed, 16 Mar 2022 19:21:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 97C2E41820; Wed, 16 Mar 2022 19:21:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 69B6FC0082; Wed, 16 Mar 2022 19:21:37 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4A74EC0033 for ; Wed, 16 Mar 2022 19:21:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2C681400BA for ; Wed, 16 Mar 2022 19:21:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=infradead.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QSwDfxeA1IZR for ; Wed, 16 Mar 2022 19:21:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by smtp2.osuosl.org (Postfix) with ESMTPS id 09773400AF for ; Wed, 16 Mar 2022 19:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=X2j8KWKH7mPGrGuSOCsj6/Zr05knYdm/d0qKjoRqe/A=; b=bdC3zFz0aD/kHDcjfAyZbfQHBp 7D/NlBM1amLmkH4B4sqKV2ufqUvJD88hTlKpyZ6VqDgekjK4FNGYILRpxkEqmQPADEL6WPYAAzU3c Sgrf+0emCMPKxF4geOisKrAEZIi126v6w7X5ziKEvg+Vo5Kfv7gQeEp68Rya/2NrsCbuCdD1F1eRO BniaXaZDMgIYFHq/3z0YvLS2w5qVtTdqdrrvR04+Nr2xp3obBSzkGzIwryyT9w7ppsZfrvdhEgpU1 CvVbeb1+V8VRryF0rtfXsRiz/tX5kbeNaIbViAt6lEitADJHoianGTvyLAizZrpPdjB0SFmWrUO/U gzvEtNsQ==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZBu-00EArp-Lx; Wed, 16 Mar 2022 19:20:14 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Date: Wed, 16 Mar 2022 12:20:01 -0700 Message-Id: <20220316192010.19001-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Cc: linux-usb@vger.kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Dave Hansen , Valentina Manea , virtualization@lists.linux-foundation.org, Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , Herbert Xu , Jens Axboe , x86@kernel.org, linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , Randy Dunlap , Florian Westphal , Karol Herbst , netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" VGhlcmUgYXJlIGEgbnVtYmVyIG9mIGRyaXZlcnMgdGhhdCB1c2UgIm1vZHVsZV9pbml0KGluaXQp IiBhbmQKIm1vZHVsZV9leGl0KGV4aXQpIiwgd2hpY2ggYXJlIGFub255bW91cyBuYW1lcyBhbmQg Y2FuIGxlYWQgdG8KY29uZnVzaW9uIG9yIGFtYmlndWl0eSB3aGVuIHJlYWRpbmcgU3lzdGVtLm1h cCwgY3Jhc2hlcy9vb3BzL2J1Z3MsCm9yIGFuIGluaXRjYWxsX2RlYnVnIGxvZy4KCkdpdmUgZWFj aCBvZiB0aGVzZSBpbml0IGFuZCBleGl0IGZ1bmN0aW9ucyB1bmlxdWUgZHJpdmVyLXNwZWNpZmlj Cm5hbWVzIHRvIGVsaW1pbmF0ZSB0aGUgYW5vbnltb3VzIG5hbWVzLgoKRXhhbXBsZSAxOiAoU3lz dGVtLm1hcCkKIGZmZmZmZmZmODMyZmM3OGMgdCBpbml0CiBmZmZmZmZmZjgzMmZjNzllIHQgaW5p dAogZmZmZmZmZmY4MzJmYzhmOCB0IGluaXQKIGZmZmZmZmZmODMyZmNhMDUgdCBpbml0CiBmZmZm ZmZmZjgzMmZjYmQyIHQgaW5pdAogZmZmZmZmZmY4MzMyOGYwZSB0IGluaXQKIGZmZmZmZmZmODMz MmM1YjEgdCBpbml0CiBmZmZmZmZmZjgzMzJkOWViIHQgaW5pdAogZmZmZmZmZmY4MzMyZjBhYSB0 IGluaXQKIGZmZmZmZmZmODMzMzBlMjUgdCBpbml0CiBmZmZmZmZmZjgzMzMxN2E1IHQgaW5pdAog ZmZmZmZmZmY4MzMzZGQ2YiB0IGluaXQKCkV4YW1wbGUgMjogKGluaXRjYWxsX2RlYnVnIGxvZykK IGNhbGxpbmcgIGluaXQrMHgwLzB4MTIgQCAxCiBpbml0Y2FsbCBpbml0KzB4MC8weDEyIHJldHVy bmVkIDAgYWZ0ZXIgMTUgdXNlY3MKIGNhbGxpbmcgIGluaXQrMHgwLzB4NjAgQCAxCiBpbml0Y2Fs bCBpbml0KzB4MC8weDYwIHJldHVybmVkIDAgYWZ0ZXIgMiB1c2VjcwogY2FsbGluZyAgaW5pdCsw eDAvMHg5YSBAIDEKIGluaXRjYWxsIGluaXQrMHgwLzB4OWEgcmV0dXJuZWQgMCBhZnRlciA3NCB1 c2VjcwogY2FsbGluZyAgaW5pdCsweDAvMHg3MyBAIDEKIGluaXRjYWxsIGluaXQrMHgwLzB4NzMg cmV0dXJuZWQgMCBhZnRlciA2IHVzZWNzCiBjYWxsaW5nICBpbml0KzB4MC8weDczIEAgMQogaW5p dGNhbGwgaW5pdCsweDAvMHg3MyByZXR1cm5lZCAwIGFmdGVyIDQgdXNlY3MKIGNhbGxpbmcgIGlu aXQrMHgwLzB4ZjUgQCAxCiBpbml0Y2FsbCBpbml0KzB4MC8weGY1IHJldHVybmVkIDAgYWZ0ZXIg MjcgdXNlY3MKIGNhbGxpbmcgIGluaXQrMHgwLzB4N2QgQCAxCiBpbml0Y2FsbCBpbml0KzB4MC8w eDdkIHJldHVybmVkIDAgYWZ0ZXIgMTEgdXNlY3MKIGNhbGxpbmcgIGluaXQrMHgwLzB4YzkgQCAx CiBpbml0Y2FsbCBpbml0KzB4MC8weGM5IHJldHVybmVkIDAgYWZ0ZXIgMTkgdXNlY3MKIGNhbGxp bmcgIGluaXQrMHgwLzB4OWQgQCAxCiBpbml0Y2FsbCBpbml0KzB4MC8weDlkIHJldHVybmVkIDAg YWZ0ZXIgMzcgdXNlY3MKIGNhbGxpbmcgIGluaXQrMHgwLzB4NjNmIEAgMQogaW5pdGNhbGwgaW5p dCsweDAvMHg2M2YgcmV0dXJuZWQgMCBhZnRlciA0MTEgdXNlY3MKIGNhbGxpbmcgIGluaXQrMHgw LzB4MTcxIEAgMQogaW5pdGNhbGwgaW5pdCsweDAvMHgxNzEgcmV0dXJuZWQgMCBhZnRlciA2MSB1 c2VjcwogY2FsbGluZyAgaW5pdCsweDAvMHhlZiBAIDEKIGluaXRjYWxsIGluaXQrMHgwLzB4ZWYg cmV0dXJuZWQgMCBhZnRlciAzIHVzZWNzCgpDYzogIk1pY2hhZWwgUy4gVHNpcmtpbiIgPG1zdEBy ZWRoYXQuY29tPgpDYzogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KQ2M6IFBhb2xv IEJvbnppbmkgPHBib256aW5pQHJlZGhhdC5jb20+CkNjOiBTdGVmYW4gSGFqbm9jemkgPHN0ZWZh bmhhQHJlZGhhdC5jb20+CkNjOiBKZW5zIEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+CkNjOiBBbWl0 IFNoYWggPGFtaXRAa2VybmVsLm9yZz4KQ2M6IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+ CkNjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgpDYzog RWxpIENvaGVuIDxlbGlAbWVsbGFub3guY29tPgpDYzogU2FlZWQgTWFoYW1lZWQgPHNhZWVkbUBu dmlkaWEuY29tPgpDYzogTGVvbiBSb21hbm92c2t5IDxsZW9uQGtlcm5lbC5vcmc+CkNjOiBQYWJs byBOZWlyYSBBeXVzbyA8cGFibG9AbmV0ZmlsdGVyLm9yZz4KQ2M6IEpvenNlZiBLYWRsZWNzaWsg PGthZGxlY0BuZXRmaWx0ZXIub3JnPgpDYzogRmxvcmlhbiBXZXN0cGhhbCA8ZndAc3RybGVuLmRl PgpDYzogIkRhdmlkIFMuIE1pbGxlciIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+CkNjOiBKYWt1YiBL aWNpbnNraSA8a3ViYUBrZXJuZWwub3JnPgpDYzogIkphbWVzIEUuSi4gQm90dG9tbGV5IiA8amVq YkBsaW51eC5pYm0uY29tPgpDYzogIk1hcnRpbiBLLiBQZXRlcnNlbiIgPG1hcnRpbi5wZXRlcnNl bkBvcmFjbGUuY29tPgpDYzogRmVsaXBlIEJhbGJpIDxmZWxpcGUuYmFsYmlAbGludXguaW50ZWwu Y29tPgpDYzogTWljaGHFgiBNaXJvc8WCYXcgPG1pcnEtbGludXhAcmVyZS5xbXFtLnBsPgpDYzog U2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4LmRlPgpDYzogS3J6 eXN6dG9mIE9wYXNpYWsgPGsub3Bhc2lha0BzYW1zdW5nLmNvbT4KQ2M6IElnb3IgS290cmFzaW5z a2kgPGkua290cmFzaW5za0BzYW1zdW5nLmNvbT4KQ2M6IFZhbGVudGluYSBNYW5lYSA8dmFsZW50 aW5hLm1hbmVhLm1AZ21haWwuY29tPgpDYzogU2h1YWggS2hhbiA8c2h1YWhAa2VybmVsLm9yZz4K Q2M6IFNodWFoIEtoYW4gPHNraGFuQGxpbnV4Zm91bmRhdGlvbi5vcmc+CkNjOiBKdXNzaSBLaXZp bGlubmEgPGp1c3NpLmtpdmlsaW5uYUBtYm5ldC5maT4KQ2M6IEpvYWNoaW0gRnJpdHNjaGkgPGpm cml0c2NoaUBmcmVlbmV0LmRlPgpDYzogSGVyYmVydCBYdSA8aGVyYmVydEBnb25kb3IuYXBhbmEu b3JnLmF1PgpDYzogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+CkNjOiBTdGV2 ZW4gUm9zdGVkdCA8cm9zdGVkdEBnb29kbWlzLm9yZz4KQ2M6IEluZ28gTW9sbmFyIDxtaW5nb0Br ZXJuZWwub3JnPgpDYzogS2Fyb2wgSGVyYnN0IDxrYXJvbGhlcmJzdEBnbWFpbC5jb20+CkNjOiBQ ZWtrYSBQYWFsYW5lbiA8cHBhYWxhbmVuQGdtYWlsLmNvbT4KQ2M6IERhdmUgSGFuc2VuIDxkYXZl LmhhbnNlbkBsaW51eC5pbnRlbC5jb20+CkNjOiBBbmR5IEx1dG9taXJza2kgPGx1dG9Aa2VybmVs Lm9yZz4KQ2M6IFBldGVyIFppamxzdHJhIDxwZXRlcnpAaW5mcmFkZWFkLm9yZz4KQ2M6IEJvcmlz bGF2IFBldGtvdiA8YnBAYWxpZW44LmRlPgpDYzogIkguIFBldGVyIEFudmluIiA8aHBhQHp5dG9y LmNvbT4KQ2M6IG5ldGZpbHRlci1kZXZlbEB2Z2VyLmtlcm5lbC5vcmcKQ2M6IGNvcmV0ZWFtQG5l dGZpbHRlci5vcmcKQ2M6IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcKQ2M6IGxpbnV4LWJsb2NrQHZn ZXIua2VybmVsLm9yZwpDYzogbGludXgtY3J5cHRvQHZnZXIua2VybmVsLm9yZwpDYzogbGludXgt cmRtYUB2Z2VyLmtlcm5lbC5vcmcKQ2M6IGxpbnV4LXNjc2lAdmdlci5rZXJuZWwub3JnCkNjOiBs aW51eC11c2JAdmdlci5rZXJuZWwub3JnCkNjOiBub3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpDYzogdmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKQ2M6IHg4NkBr ZXJuZWwub3JnCgpwYXRjaGVzOgogW1BBVENIIDEvOV0gdmlydGlvX2JsazogZWxpbWluYXRlIGFu b255bW91cyBtb2R1bGVfaW5pdCAmIG1vZHVsZV9leGl0CiBbUEFUQ0ggMi85XSB2aXJ0aW9fY29u c29sZTogZWxpbWluYXRlIGFub255bW91cyBtb2R1bGVfaW5pdCAmIG1vZHVsZV9leGl0CiBbUEFU Q0ggMy85XSBuZXQ6IG1seDU6IGVsaW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxlX2luaXQgJiBtb2R1 bGVfZXhpdAogW1BBVENIIDQvOV0gbmV0ZmlsdGVyOiBoMzIzOiBlbGltaW5hdGUgYW5vbnltb3Vz IG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4aXQKIFtQQVRDSCA1LzldIHZpcnRpby1zY3NpOiBlbGlt aW5hdGUgYW5vbnltb3VzIG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4aXQKIFtQQVRDSCA2LzldIHVz YjogZ2FkZ2V0OiBlbGltaW5hdGUgYW5vbnltb3VzIG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4aXQK IFtQQVRDSCA3LzldIHVzYjogdXNiaXA6IGVsaW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxlX2luaXQg JiBtb2R1bGVfZXhpdAogW1BBVENIIDgvOV0geDg2L2NyeXB0bzogZWxpbWluYXRlIGFub255bW91 cyBtb2R1bGVfaW5pdCAmIG1vZHVsZV9leGl0CiBbUEFUQ0ggOS85XSB0ZXN0bW1pb3RyYWNlOiBl bGltaW5hdGUgYW5vbnltb3VzIG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4aXQKCmRpZmZzdGF0Ogog YXJjaC94ODYvY3J5cHRvL2Jsb3dmaXNoX2dsdWUuYyAgICAgICAgICAgICAgICB8ICAgIDggKysr Ky0tLS0KIGFyY2gveDg2L2NyeXB0by9jYW1lbGxpYV9nbHVlLmMgICAgICAgICAgICAgICAgfCAg ICA4ICsrKystLS0tCiBhcmNoL3g4Ni9jcnlwdG8vc2VycGVudF9hdngyX2dsdWUuYyAgICAgICAg ICAgIHwgICAgOCArKysrLS0tLQogYXJjaC94ODYvY3J5cHRvL3R3b2Zpc2hfZ2x1ZS5jICAgICAg ICAgICAgICAgICB8ICAgIDggKysrKy0tLS0KIGFyY2gveDg2L2NyeXB0by90d29maXNoX2dsdWVf M3dheS5jICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCiBhcmNoL3g4Ni9tbS90ZXN0bW1pb3Ry YWNlLmMgICAgICAgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQogZHJpdmVycy9ibG9jay92 aXJ0aW9fYmxrLmMgICAgICAgICAgICAgICAgICAgICB8ICAgIDggKysrKy0tLS0KIGRyaXZlcnMv Y2hhci92aXJ0aW9fY29uc29sZS5jICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCiBk cml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvbWFpbi5jIHwgICAgOCArKysr LS0tLQogZHJpdmVycy9zY3NpL3ZpcnRpb19zY3NpLmMgICAgICAgICAgICAgICAgICAgICB8ICAg IDggKysrKy0tLS0KIGRyaXZlcnMvdXNiL2dhZGdldC9sZWdhY3kvaW5vZGUuYyAgICAgICAgICAg ICAgfCAgICA4ICsrKystLS0tCiBkcml2ZXJzL3VzYi9nYWRnZXQvbGVnYWN5L3NlcmlhbC5jICAg ICAgICAgICAgIHwgICAxMCArKysrKy0tLS0tCiBkcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2R1bW15 X2hjZC5jICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQogZHJpdmVycy91c2IvdXNiaXAvdnVk Y19tYWluLmMgICAgICAgICAgICAgICAgICB8ICAgIDggKysrKy0tLS0KIG5ldC9pcHY0L25ldGZp bHRlci9uZl9uYXRfaDMyMy5jICAgICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCiAxNSBmaWxl cyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspLCA2MSBkZWxldGlvbnMoLSkKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGlu ZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8v bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 284F1C433EF for ; Sun, 27 Mar 2022 07:44:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F1F710E14E; Sun, 27 Mar 2022 07:44:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B46610E9CC for ; Wed, 16 Mar 2022 19:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=X2j8KWKH7mPGrGuSOCsj6/Zr05knYdm/d0qKjoRqe/A=; b=bdC3zFz0aD/kHDcjfAyZbfQHBp 7D/NlBM1amLmkH4B4sqKV2ufqUvJD88hTlKpyZ6VqDgekjK4FNGYILRpxkEqmQPADEL6WPYAAzU3c Sgrf+0emCMPKxF4geOisKrAEZIi126v6w7X5ziKEvg+Vo5Kfv7gQeEp68Rya/2NrsCbuCdD1F1eRO BniaXaZDMgIYFHq/3z0YvLS2w5qVtTdqdrrvR04+Nr2xp3obBSzkGzIwryyT9w7ppsZfrvdhEgpU1 CvVbeb1+V8VRryF0rtfXsRiz/tX5kbeNaIbViAt6lEitADJHoianGTvyLAizZrpPdjB0SFmWrUO/U gzvEtNsQ==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZBu-00EArp-Lx; Wed, 16 Mar 2022 19:20:14 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Date: Wed, 16 Mar 2022 12:20:01 -0700 Message-Id: <20220316192010.19001-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sun, 27 Mar 2022 07:44:03 +0000 Subject: [Nouveau] [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Jason Wang , Dave Hansen , Valentina Manea , virtualization@lists.linux-foundation.org, Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , Herbert Xu , Jens Axboe , x86@kernel.org, linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , Randy Dunlap , Florian Westphal , netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" There are a number of drivers that use "module_init(init)" and "module_exit(exit)", which are anonymous names and can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ffffffff832fc78c t init ffffffff832fc79e t init ffffffff832fc8f8 t init ffffffff832fca05 t init ffffffff832fcbd2 t init ffffffff83328f0e t init ffffffff8332c5b1 t init ffffffff8332d9eb t init ffffffff8332f0aa t init ffffffff83330e25 t init ffffffff833317a5 t init ffffffff8333dd6b t init Example 2: (initcall_debug log) calling init+0x0/0x12 @ 1 initcall init+0x0/0x12 returned 0 after 15 usecs calling init+0x0/0x60 @ 1 initcall init+0x0/0x60 returned 0 after 2 usecs calling init+0x0/0x9a @ 1 initcall init+0x0/0x9a returned 0 after 74 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 6 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 4 usecs calling init+0x0/0xf5 @ 1 initcall init+0x0/0xf5 returned 0 after 27 usecs calling init+0x0/0x7d @ 1 initcall init+0x0/0x7d returned 0 after 11 usecs calling init+0x0/0xc9 @ 1 initcall init+0x0/0xc9 returned 0 after 19 usecs calling init+0x0/0x9d @ 1 initcall init+0x0/0x9d returned 0 after 37 usecs calling init+0x0/0x63f @ 1 initcall init+0x0/0x63f returned 0 after 411 usecs calling init+0x0/0x171 @ 1 initcall init+0x0/0x171 returned 0 after 61 usecs calling init+0x0/0xef @ 1 initcall init+0x0/0xef returned 0 after 3 usecs Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: Jens Axboe Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Eli Cohen Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: "David S. Miller" Cc: Jakub Kicinski Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Felipe Balbi Cc: Michał Mirosław Cc: Sebastian Andrzej Siewior Cc: Krzysztof Opasiak Cc: Igor Kotrasinski Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: Jussi Kivilinna Cc: Joachim Fritschi Cc: Herbert Xu Cc: Thomas Gleixner Cc: Steven Rostedt Cc: Ingo Molnar Cc: Karol Herbst Cc: Pekka Paalanen Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org Cc: netdev@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-rdma@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: virtualization@lists.linux-foundation.org Cc: x86@kernel.org patches: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit diffstat: arch/x86/crypto/blowfish_glue.c | 8 ++++---- arch/x86/crypto/camellia_glue.c | 8 ++++---- arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- arch/x86/mm/testmmiotrace.c | 8 ++++---- drivers/block/virtio_blk.c | 8 ++++---- drivers/char/virtio_console.c | 8 ++++---- drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- drivers/scsi/virtio_scsi.c | 8 ++++---- drivers/usb/gadget/legacy/inode.c | 8 ++++---- drivers/usb/gadget/legacy/serial.c | 10 +++++----- drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- drivers/usb/usbip/vudc_main.c | 8 ++++---- net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- 15 files changed, 61 insertions(+), 61 deletions(-)