From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Simo Sorce <ssorce@redhat.com>,
Eric Biggers <ebiggers@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
kernel@pengutronix.de, Guenter Roeck <linux@roeck-us.net>,
Vladis Dronov <vdronov@redhat.com>
Subject: Re: [v2 PATCH] crypto: api - Fix built-in testing dependency failures
Date: Wed, 16 Mar 2022 22:44:17 +0100 [thread overview]
Message-ID: <20220316214417.khho2qno76bby3qm@pengutronix.de> (raw)
In-Reply-To: <20220316163719.ud2s36e5zwmtmzef@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]
On Wed, Mar 16, 2022 at 05:37:19PM +0100, Uwe Kleine-König wrote:
> On Wed, Mar 16, 2022 at 01:10:41PM +1200, Herbert Xu wrote:
> > On Wed, Dec 29, 2021 at 12:05:23PM +0100, Uwe Kleine-König wrote:
> > > On Wed, Dec 29, 2021 at 01:05:54PM +1100, Herbert Xu wrote:
> > > > On Wed, Dec 22, 2021 at 11:22:46AM +0100, Uwe Kleine-König wrote:
> > > > >
> > > > > I still experience a problem with the patch that got
> > > > > adad556efcdd42a1d9e060cbe5f6161cccf1fa28 in v5.16-rc1. I saw there are
> > > > > two commit fixing this one (
> > > > >
> > > > > cad439fc040e crypto: api - Do not create test larvals if manager is disabled
> > > > > e42dff467ee6 crypto: api - Export crypto_boot_test_finished
> > > > >
> > > > > ) but I still encounter the following on 2f47a9a4dfa3:
> > > >
> > > > Perhaps you missed the last fix?
> > > >
> > > > commit beaaaa37c664e9afdf2913aee19185d8e3793b50
> > > > Author: Herbert Xu <herbert@gondor.apana.org.au>
> > > > Date: Fri Nov 5 15:26:08 2021 +0800
> > > >
> > > > crypto: api - Fix boot-up crash when crypto manager is disabled
> > >
> > > As 2f47a9a4dfa3 includes this commit, this is not the problem.
> >
> > Using the config snippet in this email thread I was unable to
> > reproduce the failure under qemu. Can you still reproduce this
> > with the latest upstream kernel? If yes please send me your complete
> > config file.
>
> Still happens on 5.17-rc8, config attached.
I debugged that a bit further because the problem is in the way while
debugging another bug. What I learned is that without
CONFIG_DEBUG_BUG_VERBOSE a BUG results in hitting an undefined
instruction e7f001f2 on ARM.
After enabling CONFIG_DEBUG_BUG_VERBOSE this gets much more helpful:
[ 1.630337] kernel BUG at crypto/algapi.c:461!
Digging a bit deeper the problem is that simd_skcipher_create_compat()
fails for aes_algs[1] in arch/arm/crypto/aes-neonbs-glue.c with -ENOENT
and then aes_exit -> simd_skcipher_free -> crypto_unregister_skcipher ->
crypto_unregister_alg stumbles over refcount_read(&alg->cra_refcnt)
being 2. Is this enough to understand the actual problem?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-16 21:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:12 [PATCH] crypto: api - Fix built-in testing dependency failures Herbert Xu
2021-09-13 18:16 ` Eric Biggers
2021-09-14 3:28 ` Herbert Xu
2021-09-17 0:26 ` [v2 PATCH] " Herbert Xu
2021-09-28 18:32 ` Nathan Chancellor
2021-10-01 5:50 ` Herbert Xu
2021-10-01 10:58 ` Naresh Kamboju
2021-10-01 10:58 ` Naresh Kamboju
2021-10-01 18:01 ` Nathan Chancellor
2021-10-03 0:28 ` Herbert Xu
2021-10-06 2:33 ` Nathan Chancellor
2021-10-19 13:28 ` [PATCH] crypto: api - Do not create test larvals if manager is disabled Herbert Xu
2021-11-02 15:41 ` Geert Uytterhoeven
2021-11-04 7:28 ` Damien Le Moal
2021-11-04 7:58 ` Geert Uytterhoeven
2021-11-04 8:05 ` Damien Le Moal
2021-11-04 12:16 ` Herbert Xu
2021-11-04 13:11 ` Geert Uytterhoeven
2021-11-04 13:30 ` Herbert Xu
2021-11-04 15:18 ` Ido Schimmel
2021-11-05 7:26 ` crypto: api - Fix boot-up crash when crypto " Herbert Xu
2021-11-05 14:33 ` Ido Schimmel
2021-11-05 18:00 ` Geert Uytterhoeven
2021-10-26 16:33 ` [v2 PATCH] crypto: api - Fix built-in testing dependency failures Guenter Roeck
2021-10-27 2:59 ` Herbert Xu
2021-10-27 3:48 ` Guenter Roeck
2021-11-06 3:47 ` Herbert Xu
2021-11-06 14:55 ` Guenter Roeck
2021-12-22 10:22 ` Uwe Kleine-König
2021-12-22 10:37 ` Uwe Kleine-König
2021-12-29 2:05 ` Herbert Xu
2021-12-29 11:05 ` Uwe Kleine-König
2022-03-16 1:10 ` Herbert Xu
2022-03-16 16:37 ` Uwe Kleine-König
2022-03-16 21:44 ` Uwe Kleine-König [this message]
2022-03-16 22:38 ` Herbert Xu
2022-03-16 22:55 ` [PATCH] crypto: arm/aes-neonbs-cbc - Select generic cbc and aes Herbert Xu
2022-03-17 7:11 ` Uwe Kleine-König
2022-03-17 9:16 ` Philipp Zabel
2022-03-17 22:15 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316214417.khho2qno76bby3qm@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ssorce@redhat.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.