From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716A6C433F5 for ; Thu, 17 Mar 2022 02:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357250AbiCQCkW (ORCPT ); Wed, 16 Mar 2022 22:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358444AbiCQCkV (ORCPT ); Wed, 16 Mar 2022 22:40:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F14A1FCF0; Wed, 16 Mar 2022 19:39:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F001BB81DD5; Thu, 17 Mar 2022 02:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71A07C340F0; Thu, 17 Mar 2022 02:38:57 +0000 (UTC) Date: Wed, 16 Mar 2022 22:38:55 -0400 From: Steven Rostedt To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit Message-ID: <20220316223855.5c31ae25@gandalf.local.home> In-Reply-To: <20220316192010.19001-10-rdunlap@infradead.org> References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-10-rdunlap@infradead.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, 16 Mar 2022 12:20:10 -0700 Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: 8b7d89d02ef3 ("x86: mmiotrace - trace memory mapped IO") > Signed-off-by: Randy Dunlap > Cc: Thomas Gleixner > Cc: Steven Rostedt Acked-by: Steven Rostedt (Google) -- Steve > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Cc: x86@kernel.org > --- > arch/x86/mm/testmmiotrace.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/arch/x86/mm/testmmiotrace.c > +++ lnx-517-rc8/arch/x86/mm/testmmiotrace.c > @@ -113,7 +113,7 @@ static void do_test_bulk_ioremapping(voi > synchronize_rcu(); > } > > -static int __init init(void) > +static int __init testmmiotrace_init(void) > { > unsigned long size = (read_far) ? (8 << 20) : (16 << 10); > int ret = security_locked_down(LOCKDOWN_MMIOTRACE); > @@ -136,11 +136,11 @@ static int __init init(void) > return 0; > } > > -static void __exit cleanup(void) > +static void __exit testmmiotrace_cleanup(void) > { > pr_debug("unloaded.\n"); > } > > -module_init(init); > -module_exit(cleanup); > +module_init(testmmiotrace_init); > +module_exit(testmmiotrace_cleanup); > MODULE_LICENSE("GPL"); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF9C6C433EF for ; Thu, 17 Mar 2022 02:39:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6C0C1416B4; Thu, 17 Mar 2022 02:39:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ST0qSB2IKDxm; Thu, 17 Mar 2022 02:39:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 20F70415FA; Thu, 17 Mar 2022 02:39:07 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 029E6C001A; Thu, 17 Mar 2022 02:39:07 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id AC490C000B for ; Thu, 17 Mar 2022 02:39:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A64C040AEF for ; Thu, 17 Mar 2022 02:39:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CLS6wZieRyat for ; Thu, 17 Mar 2022 02:39:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8FAFC40111 for ; Thu, 17 Mar 2022 02:39:04 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E992614E9; Thu, 17 Mar 2022 02:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71A07C340F0; Thu, 17 Mar 2022 02:38:57 +0000 (UTC) Date: Wed, 16 Mar 2022 22:38:55 -0400 From: Steven Rostedt To: Randy Dunlap Subject: Re: [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit Message-ID: <20220316223855.5c31ae25@gandalf.local.home> In-Reply-To: <20220316192010.19001-10-rdunlap@infradead.org> References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-10-rdunlap@infradead.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Dave Hansen , Valentina Manea , Karol Herbst , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, 16 Mar 2022 12:20:10 -0700 Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: 8b7d89d02ef3 ("x86: mmiotrace - trace memory mapped IO") > Signed-off-by: Randy Dunlap > Cc: Thomas Gleixner > Cc: Steven Rostedt Acked-by: Steven Rostedt (Google) -- Steve > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Cc: x86@kernel.org > --- > arch/x86/mm/testmmiotrace.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/arch/x86/mm/testmmiotrace.c > +++ lnx-517-rc8/arch/x86/mm/testmmiotrace.c > @@ -113,7 +113,7 @@ static void do_test_bulk_ioremapping(voi > synchronize_rcu(); > } > > -static int __init init(void) > +static int __init testmmiotrace_init(void) > { > unsigned long size = (read_far) ? (8 << 20) : (16 << 10); > int ret = security_locked_down(LOCKDOWN_MMIOTRACE); > @@ -136,11 +136,11 @@ static int __init init(void) > return 0; > } > > -static void __exit cleanup(void) > +static void __exit testmmiotrace_cleanup(void) > { > pr_debug("unloaded.\n"); > } > > -module_init(init); > -module_exit(cleanup); > +module_init(testmmiotrace_init); > +module_exit(testmmiotrace_cleanup); > MODULE_LICENSE("GPL"); _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0112DC433F5 for ; Sun, 27 Mar 2022 07:44:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4640D10E1E2; Sun, 27 Mar 2022 07:44:15 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3B3C10EAD4 for ; Thu, 17 Mar 2022 02:39:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E992614E9; Thu, 17 Mar 2022 02:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71A07C340F0; Thu, 17 Mar 2022 02:38:57 +0000 (UTC) Date: Wed, 16 Mar 2022 22:38:55 -0400 From: Steven Rostedt To: Randy Dunlap Message-ID: <20220316223855.5c31ae25@gandalf.local.home> In-Reply-To: <20220316192010.19001-10-rdunlap@infradead.org> References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-10-rdunlap@infradead.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 27 Mar 2022 07:44:03 +0000 Subject: Re: [Nouveau] [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Jason Wang , Dave Hansen , Valentina Manea , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, 16 Mar 2022 12:20:10 -0700 Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: 8b7d89d02ef3 ("x86: mmiotrace - trace memory mapped IO") > Signed-off-by: Randy Dunlap > Cc: Thomas Gleixner > Cc: Steven Rostedt Acked-by: Steven Rostedt (Google) -- Steve > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Cc: x86@kernel.org > --- > arch/x86/mm/testmmiotrace.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/arch/x86/mm/testmmiotrace.c > +++ lnx-517-rc8/arch/x86/mm/testmmiotrace.c > @@ -113,7 +113,7 @@ static void do_test_bulk_ioremapping(voi > synchronize_rcu(); > } > > -static int __init init(void) > +static int __init testmmiotrace_init(void) > { > unsigned long size = (read_far) ? (8 << 20) : (16 << 10); > int ret = security_locked_down(LOCKDOWN_MMIOTRACE); > @@ -136,11 +136,11 @@ static int __init init(void) > return 0; > } > > -static void __exit cleanup(void) > +static void __exit testmmiotrace_cleanup(void) > { > pr_debug("unloaded.\n"); > } > > -module_init(init); > -module_exit(cleanup); > +module_init(testmmiotrace_init); > +module_exit(testmmiotrace_cleanup); > MODULE_LICENSE("GPL");