All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Marek Vasut <marex@denx.de>
Cc: "Stefano Babic" <sbabic@denx.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	"Peng Fan" <peng.fan@nxp.com>, "Ye Li" <ye.li@nxp.com>,
	"Alice Guo" <alice.guo@nxp.com>,
	"Andrey Zhizhikin" <andrey.zhizhikin@leica-geosystems.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v2 4/9] arm: imx: imx8mm: add enable_pwm_clk function
Date: Thu, 17 Mar 2022 08:39:27 +0100	[thread overview]
Message-ID: <20220317073927.GC29139@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <1225773a-10e9-d90b-d1b1-0b749c96129d@denx.de>

On Wed, Mar 16, 2022 at 09:54:34PM +0100, Marek Vasut wrote:
> On 3/16/22 16:27, Tommaso Merciai wrote:
> > Add function enable_pwm_clk into in clock_imx8mm.c. This
> > function first configure, then enable pwm clock from clock control
> > register. The following configuration is used:
> > 
> > source(0) -> 24 MHz ref clock
> > div(0)    -> no division for this clock
> > 
> > References:
> >   - iMX8MMRM.pdf p 303
> > 
> > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> > ---
> > Changes since v1:
> >   - Fix enable_pwm_clk function implementation. Now is generic for all pwm clks
> > 
> >   arch/arm/mach-imx/imx8m/clock_imx8mm.c | 53 ++++++++++++++++++++++++++
> >   1 file changed, 53 insertions(+)
> 
> Why is this not in drivers/clk/imx/ DM driver ?

Hi Marek,
All function that enable/configure clk from CCGR are in arch/arm/mach-imx/imx8m/clock_imx8mm.c.
For that I continue to put here the implementation. After we can port
the clk dm part to manipulate clock in drivers/clk/imx/ DM driver.
What do you think about? Let me know.

Thanks,
Tommaso

-- 
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com

  reply	other threads:[~2022-03-17  7:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 15:27 [PATCH v2 0/9] imx8mm: add pwm-imx backlight support Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 1/9] arch: mach-imx: imx8m: add pwm1/pwm2 base address Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 2/9] arch: mach-imx: imx8m: add pwm ctrl registers fields defines Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 3/9] arch: mach-imx: imx8m: add pwm_regs struct in imx-regs Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 4/9] arm: imx: imx8mm: add enable_pwm_clk function Tommaso Merciai
2022-03-16 19:07   ` Michael Nazzareno Trimarchi
2022-03-17  7:40     ` Tommaso Merciai
2022-03-16 20:54   ` Marek Vasut
2022-03-17  7:39     ` Tommaso Merciai [this message]
2022-03-17 11:58       ` Marek Vasut
2022-03-17 12:38         ` Tommaso Merciai
2022-03-17 12:44           ` Marek Vasut
2022-03-17 15:13           ` Tommaso Merciai
2022-03-17 15:31             ` Marek Vasut
2022-03-24 10:55               ` Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 5/9] imx8m: clock: " Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 6/9] configs: imx8mm_evk: add CONFIG_IMX6_PWM_PER_CLK config Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 7/9] imx8mm_evk: spl: enable pwm clock Tommaso Merciai
2022-03-16 23:55   ` Fabio Estevam
2022-03-17  0:48     ` Fabio Estevam
2022-03-17  7:34       ` Tommaso Merciai
2022-03-17 10:55         ` Fabio Estevam
2022-03-17 12:40           ` Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 8/9] arm: dts: imx8mm_evk: add pwm1/backlight support Tommaso Merciai
2022-03-16 15:27 ` [PATCH v2 9/9] configs: imx8mm_evk: add pwm backlight support Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317073927.GC29139@tom-ThinkPad-T14s-Gen-2i \
    --to=tommaso.merciai@amarulasolutions.com \
    --cc=alice.guo@nxp.com \
    --cc=andrey.zhizhikin@leica-geosystems.com \
    --cc=festevam@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.