From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Hangyu Hua <hbh25y@gmail.com>
Cc: rcsekar@samsung.com, wg@grandegger.com, davem@davemloft.net,
kuba@kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: m_can: fix a possible use after free in m_can_tx_handler()
Date: Thu, 17 Mar 2022 09:11:48 +0100 [thread overview]
Message-ID: <20220317081148.rdnacm4bry76rny4@pengutronix.de> (raw)
In-Reply-To: <20220317030143.14668-1-hbh25y@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On 17.03.2022 11:01:43, Hangyu Hua wrote:
> can_put_echo_skb will clone skb then free the skb. It is better to avoid using
> skb after can_put_echo_skb.
Why not move the can_put_echo_skb() instead? I'll send a patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-03-17 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 3:01 [PATCH] can: m_can: fix a possible use after free in m_can_tx_handler() Hangyu Hua
2022-03-17 8:11 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317081148.rdnacm4bry76rny4@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=hbh25y@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.