From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D9FC433EF for ; Thu, 17 Mar 2022 17:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237006AbiCQRqa (ORCPT ); Thu, 17 Mar 2022 13:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232196AbiCQRq3 (ORCPT ); Thu, 17 Mar 2022 13:46:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F31C0BD7E4 for ; Thu, 17 Mar 2022 10:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647539112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2jSZntopo5lj3lX97AHm+Bt3POGDsH+Rw9wQ2NJBUtQ=; b=aR+dRsi2GVNS+dVSdjY/fFYG0R7ey+2VMGIclYSkVUSWPEoLPu9wTTzPVAbhaLo5mSijKJ 4mVavy8lTJI3lbGIbpgR5wy79/p3QCuJw8+jld4OnpDcj/opWhx1cukwwmfJTOZlDcCftC BwCn9+eky40unW3QeK5e2odDYe/OR8g= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-QmBcoxd8M5CO-TVQeH7Qcw-1; Thu, 17 Mar 2022 13:45:10 -0400 X-MC-Unique: QmBcoxd8M5CO-TVQeH7Qcw-1 Received: by mail-ed1-f70.google.com with SMTP id bq19-20020a056402215300b0040f276105a4so3546302edb.2 for ; Thu, 17 Mar 2022 10:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2jSZntopo5lj3lX97AHm+Bt3POGDsH+Rw9wQ2NJBUtQ=; b=TB8/2rwvA9EsQriMb9Ba260eU8O2gGEwuy3/n3Wf/UkZXS3bXGrxM0EbWFSPq8o+Wq uy77ilcC9DSQucJuFhtGvFG8OiaAL3BttAaqj/MbjCrqFZHluIadaXPxyAfDu54hw/7c xdjb0mVG8dqAgC1sZHL46Za2feKERvSbUbHGoRB8yKNu0YXjZFfTmU6p1PRhlfJN5WbB U1uDfpNK53Fr8bjirtp4nsShPhUg2khVOG0lNvQlXSLflVJQiARBMkmHlGGFBwH4H+p7 GeTl+McZcoQ4P7rY6+ltOoGdBfopZ7C6ZTP6Oz7dyLAJh77dOq/KkJGghPfhLbFH9skd VddA== X-Gm-Message-State: AOAM532L2TsYocTiGq9OAt3fqn3gLpDwgQLsvAmZYS6sgN4p2V7Oze42 UY/N1rLilXx3A+eYB6IT1jVfyjXRg3etImbg4ZQgSQwXozo/iB99thZjCkamFcWBsfMrTNGRpJA cZAtaWhnkGT6T X-Received: by 2002:a17:907:3f86:b0:6db:b745:f761 with SMTP id hr6-20020a1709073f8600b006dbb745f761mr5351773ejc.610.1647539109574; Thu, 17 Mar 2022 10:45:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw07m+uKi8TwSUle9H2N2prBjnYvm79oDP4Lqt9N6Gdp5ucxXVDZSzZrzPZTYFL8YPxAdRODw== X-Received: by 2002:a17:907:3f86:b0:6db:b745:f761 with SMTP id hr6-20020a1709073f8600b006dbb745f761mr5351757ejc.610.1647539109354; Thu, 17 Mar 2022 10:45:09 -0700 (PDT) Received: from gator (cst2-173-70.cust.vodafone.cz. [31.30.173.70]) by smtp.gmail.com with ESMTPSA id w14-20020a170906d20e00b006cee22553f7sm2715187ejz.213.2022.03.17.10.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 10:45:09 -0700 (PDT) Date: Thu, 17 Mar 2022 18:45:07 +0100 From: Andrew Jones To: Alexandru Elisei Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [kvm-unit-tests PATCH] arm/run: Use TCG with qemu-system-arm on arm64 systems Message-ID: <20220317174507.jt2rattmtetddvsq@gator> References: <20220317165601.356466-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317165601.356466-1-alexandru.elisei@arm.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 17, 2022 at 04:56:01PM +0000, Alexandru Elisei wrote: > From: Andrew Jones > > If the user sets QEMU=qemu-system-arm on arm64 systems, the tests can only > be run by using the TCG accelerator. In this case use TCG instead of KVM. > > Signed-off-by: Andrew Jones > [ Alex E: Added commit message ] > Signed-off-by: Alexandru Elisei > --- > arm/run | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arm/run b/arm/run > index 28a0b4ad2729..128489125dcb 100755 > --- a/arm/run > +++ b/arm/run > @@ -10,16 +10,24 @@ if [ -z "$KUT_STANDALONE" ]; then > fi > processor="$PROCESSOR" > > -ACCEL=$(get_qemu_accelerator) || > +accel=$(get_qemu_accelerator) || > exit $? > > -if [ "$ACCEL" = "kvm" ]; then > +if [ "$accel" = "kvm" ]; then > QEMU_ARCH=$HOST > fi > > qemu=$(search_qemu_binary) || > exit $? > > +if [ "$QEMU" ] && [ -z "$ACCEL" ] && > + [ "$HOST" = "aarch64" ] && [ "$ARCH" = "arm" ] && > + [ "$(basename $QEMU)" = "qemu-system-arm" ]; then > + accel=tcg > +fi > + > +ACCEL=$accel > + > if ! $qemu -machine '?' 2>&1 | grep 'ARM Virtual Machine' > /dev/null; then > echo "$qemu doesn't support mach-virt ('-machine virt'). Exiting." > exit 2 > -- > 2.35.1 > Ha, OK, I guess you posting this is a strong vote in favor of this behavior. I've queued it https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/queue Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C91C433FE for ; Thu, 17 Mar 2022 17:45:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3784A49EAE; Thu, 17 Mar 2022 13:45:16 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ceTP1ik4kw-N; Thu, 17 Mar 2022 13:45:15 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 157F949EC2; Thu, 17 Mar 2022 13:45:15 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D492F49EAE for ; Thu, 17 Mar 2022 13:45:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PzIr5WFa9eaL for ; Thu, 17 Mar 2022 13:45:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 908FF49E17 for ; Thu, 17 Mar 2022 13:45:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647539112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2jSZntopo5lj3lX97AHm+Bt3POGDsH+Rw9wQ2NJBUtQ=; b=aR+dRsi2GVNS+dVSdjY/fFYG0R7ey+2VMGIclYSkVUSWPEoLPu9wTTzPVAbhaLo5mSijKJ 4mVavy8lTJI3lbGIbpgR5wy79/p3QCuJw8+jld4OnpDcj/opWhx1cukwwmfJTOZlDcCftC BwCn9+eky40unW3QeK5e2odDYe/OR8g= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-389-KIHSkYGxNR6NaLHpkKLh7Q-1; Thu, 17 Mar 2022 13:45:10 -0400 X-MC-Unique: KIHSkYGxNR6NaLHpkKLh7Q-1 Received: by mail-ej1-f72.google.com with SMTP id hy26-20020a1709068a7a00b006dfa034862cso1064206ejc.23 for ; Thu, 17 Mar 2022 10:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2jSZntopo5lj3lX97AHm+Bt3POGDsH+Rw9wQ2NJBUtQ=; b=G66f5oSWQMgRpuqi568khJqZkHAe82apH6PLNmnQ059/gQCfL0LG1zGkVdcF25jcvj PcGbxqO2BuH332p0IOXNHKaZjeXAcRqw7AUusq+2ltXR+Z9iNnrQJLwGEYOgKRgFmSSw Y5Tw+gp5GUnHMVcK5BE2BajL/4qweASIus1ms51ojJJbDQkv3qZKMTm9X+4Qz+SCTN6H NJexP4MTq0uIHh9jsJz7i/1Oau3QBtcFLiwcTjXnoNwjp7CG/1zAoRFuXYath3xhGyTL WgrU2WaCZtlmOvC7VzKYUZIzKO2LiHQt+W6dvp8/HDAXMHVsmV8W9wPzS5odubnHP+gs Am9g== X-Gm-Message-State: AOAM531rJKiey+Cx8JZIWLjYDBvX2hWwu6w/1bGF+26uGvBjDH08nmG/ 5IAUhuCfJqt62KKH415BT7kYtyi2HzZkr81JFrn99D9+zwcKUeN7HChBstGFvrzAybWmFvlb5CR PmTCi6lNj4nG3SM548sE37q/t X-Received: by 2002:a17:907:3f86:b0:6db:b745:f761 with SMTP id hr6-20020a1709073f8600b006dbb745f761mr5351772ejc.610.1647539109574; Thu, 17 Mar 2022 10:45:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw07m+uKi8TwSUle9H2N2prBjnYvm79oDP4Lqt9N6Gdp5ucxXVDZSzZrzPZTYFL8YPxAdRODw== X-Received: by 2002:a17:907:3f86:b0:6db:b745:f761 with SMTP id hr6-20020a1709073f8600b006dbb745f761mr5351757ejc.610.1647539109354; Thu, 17 Mar 2022 10:45:09 -0700 (PDT) Received: from gator (cst2-173-70.cust.vodafone.cz. [31.30.173.70]) by smtp.gmail.com with ESMTPSA id w14-20020a170906d20e00b006cee22553f7sm2715187ejz.213.2022.03.17.10.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 10:45:09 -0700 (PDT) Date: Thu, 17 Mar 2022 18:45:07 +0100 From: Andrew Jones To: Alexandru Elisei Subject: Re: [kvm-unit-tests PATCH] arm/run: Use TCG with qemu-system-arm on arm64 systems Message-ID: <20220317174507.jt2rattmtetddvsq@gator> References: <20220317165601.356466-1-alexandru.elisei@arm.com> MIME-Version: 1.0 In-Reply-To: <20220317165601.356466-1-alexandru.elisei@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Mar 17, 2022 at 04:56:01PM +0000, Alexandru Elisei wrote: > From: Andrew Jones > > If the user sets QEMU=qemu-system-arm on arm64 systems, the tests can only > be run by using the TCG accelerator. In this case use TCG instead of KVM. > > Signed-off-by: Andrew Jones > [ Alex E: Added commit message ] > Signed-off-by: Alexandru Elisei > --- > arm/run | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arm/run b/arm/run > index 28a0b4ad2729..128489125dcb 100755 > --- a/arm/run > +++ b/arm/run > @@ -10,16 +10,24 @@ if [ -z "$KUT_STANDALONE" ]; then > fi > processor="$PROCESSOR" > > -ACCEL=$(get_qemu_accelerator) || > +accel=$(get_qemu_accelerator) || > exit $? > > -if [ "$ACCEL" = "kvm" ]; then > +if [ "$accel" = "kvm" ]; then > QEMU_ARCH=$HOST > fi > > qemu=$(search_qemu_binary) || > exit $? > > +if [ "$QEMU" ] && [ -z "$ACCEL" ] && > + [ "$HOST" = "aarch64" ] && [ "$ARCH" = "arm" ] && > + [ "$(basename $QEMU)" = "qemu-system-arm" ]; then > + accel=tcg > +fi > + > +ACCEL=$accel > + > if ! $qemu -machine '?' 2>&1 | grep 'ARM Virtual Machine' > /dev/null; then > echo "$qemu doesn't support mach-virt ('-machine virt'). Exiting." > exit 2 > -- > 2.35.1 > Ha, OK, I guess you posting this is a strong vote in favor of this behavior. I've queued it https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/queue Thanks, drew _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm