All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Vincent Mailhol <vincent.mailhol@gmail.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	linux-can@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Thu, 17 Mar 2022 21:23:59 +0100	[thread overview]
Message-ID: <20220317212359.71252c57.max@enpas.org> (raw)
In-Reply-To: <20220314220408.hn4vdohtjdbfoaqo@pengutronix.de>

On Mon, 14 Mar 2022 23:04:08 +0100
Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 09.03.2022 22:49:49, Vincent Mailhol wrote:
> > Either we agree that using can_rx_offload without implementing
> > the mailbox_read() is OK and in that case, the can_rx_offload
> > framework should be modified to allow mailbox_read() to be a NULL
> > pointer.
> > 
> > Either it is not the case and you use the more classic
> > netif_rx().
> > 
> > And I do not have the answer. I haven't studied can_rx_offload
> > enough to be a judge here. Sorry.
> > 
> > @Marc, any thoughts?  
> 
> Use can_rx_offload_add_manual() instead.

m-(

Yes, it's right underneath _add_fifo() and does the right thing. No
idea how I missed it, I thought I had looked through all variants.

Thanks!


> > Also give a look at can_dropped_invalid_skb().  
> 
> ACK

Done.


> Marc

Max

  reply	other threads:[~2022-03-17 20:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 21:43 [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-03-07 21:57 ` Greg Kroah-Hartman
2022-03-07 22:00   ` Max Staudt
2022-03-08  7:01 ` Vincent Mailhol
2022-03-09 12:54   ` Max Staudt
2022-03-09 13:49     ` Vincent Mailhol
2022-03-12 21:21       ` Max Staudt
2022-03-15 10:21         ` Marc Kleine-Budde
2022-03-17 21:05           ` Max Staudt
2022-03-14 22:04       ` Marc Kleine-Budde
2022-03-17 20:23         ` Max Staudt [this message]
2022-03-17 20:57           ` Marc Kleine-Budde
2022-03-17 21:08             ` Max Staudt
2022-03-14 22:00   ` Marc Kleine-Budde
2022-03-14 21:58 ` Marc Kleine-Budde
2022-03-17 20:18   ` Max Staudt
2022-03-17 20:55     ` Marc Kleine-Budde
2022-03-21  2:06       ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317212359.71252c57.max@enpas.org \
    --to=max@enpas.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=vincent.mailhol@gmail.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.