From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6F1C433EF for ; Thu, 17 Mar 2022 21:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbiCQV1s (ORCPT ); Thu, 17 Mar 2022 17:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbiCQV1o (ORCPT ); Thu, 17 Mar 2022 17:27:44 -0400 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3B30E127E; Thu, 17 Mar 2022 14:26:26 -0700 (PDT) Received: by mail-pj1-f43.google.com with SMTP id o6-20020a17090a9f8600b001c6562049d9so6640850pjp.3; Thu, 17 Mar 2022 14:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O28KFB9Z1FTz+AymH1IN8bgHj7fL/zlAB/PUyRZgUJs=; b=p46uwofeLg5Vu8lhhImWBLOdalf9R9c51tbeP4ZqSXmJbVrnjwLKBmGO9x6y741/9C F1z3FT9GcfO3w8Uy5wgXkvY6Zwo2xF4zgYMtDHHrA2e3Tsx6H8wPajgjqunwWno7+obU O6jsg/z1Bm5Zqn45iBnmqEX6OA1XWo7u0lsPGuH6iRhhTvHzeE2ZhCcy8SVHLf76esom jC4E5SjBuceJocPckCw5BIzd3ZvDCUpxHgkpX8+G+QJVoz3BlD1LcuU1moF9RfTaOcXO EkObbZW7qdIyoS1dWuTav1xwouqRxh6yOZ1vBaCw4wPeTtMpIuOCslctpNdt1fGceRqP Q0kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O28KFB9Z1FTz+AymH1IN8bgHj7fL/zlAB/PUyRZgUJs=; b=1Zbw8PbbMsfRlZbFZJYq30NNsPA1/xsrHRAijo3POLNEeakSr29lEu+lTQyEquU72d l6aAwgnBjDdHWcVS/zOyUk2BK7Fu8+IORtKCHLISRZM04rNjN0MOylKFr7Cv+8HDpPXp Z3CsDCz9yyr5iENVabZjjdfUY00/BwC4C7o5XBymhs1asQPAjgXG4qzqKSi4usc3QGgf eqatnONAdxukug2UCL21408S8tFQMSS//vk9o2WzivxeFINi9ApulD+kAGLS+r71mJOh dqkicxyiOA4Tx8B96ykzgk3McYNuvLd2D7kEFAowiUWrPccxkjEDRbGNW3FqBJneIg3p ykYA== X-Gm-Message-State: AOAM532r1jwS82VZxbd6Rnx8zt5XQMehQcEQokR2AxgUCxLdI66pZcK3 ikIl1Xa5inExEDdx6jJkykw= X-Google-Smtp-Source: ABdhPJwiI+1DF6j6F1CN5z+IyxD3suUX3qc9ceGaxuETSEpJcT/76Ll3c9nj5XiMyX7kuDZiR4jblg== X-Received: by 2002:a17:90b:3e8c:b0:1bf:4043:daa with SMTP id rj12-20020a17090b3e8c00b001bf40430daamr7630460pjb.233.1647552315163; Thu, 17 Mar 2022 14:25:15 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.51.18]) by smtp.gmail.com with ESMTPSA id k185-20020a6384c2000000b003821dcd9020sm1284016pgd.27.2022.03.17.14.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 14:25:14 -0700 (PDT) Date: Fri, 18 Mar 2022 02:55:08 +0530 From: Kuldeep Singh To: Robin Murphy Cc: Marc Zyngier , Daniel Lezcano , Thomas Gleixner , Rob Herring , Marc Zyngier , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: timer: Document arm, cortex-a7-timer in arch timer Message-ID: <20220317212508.GB99538@9a2d8922b8f1> References: <20220317191527.96237-1-singh.kuldeep87k@gmail.com> <20220317191527.96237-3-singh.kuldeep87k@gmail.com> <558f0c92-c499-daca-e1ad-2b16137f8c06@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558f0c92-c499-daca-e1ad-2b16137f8c06@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 08:25:12PM +0000, Robin Murphy wrote: > On 2022-03-17 19:15, Kuldeep Singh wrote: > > Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in > > conjugation with "arm,armv7-timer". Since, initial entry is not > > documented, it start raising dtbs_check warnings. > > > > ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long > > 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] > > 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] > > > > Document this compatible to address it. The motivation to add this > > change is taken from an already existing entry "arm,cortex-a15-timer". > > Please note, this will not hurt any arch timer users. > > Eh, if it's never been documented or supported, I say just get rid of it. > The arch timer interface is by definition part of a CPU, and we can tell > what the CPU is by reading its ID registers. Indeed that's how the driver > handles the non-zero number of CPU-specific errata that already exist - we > don't need compatibles for that. > > In some ways it might have been nice to have *SoC-specific* compatibles > given the difficulty some integrators seem to have had in wiring up a stable > count *to* the interface, but it's not like they could be magically added to > already-deployed DTs after a bug is discovered, and nor could we have > mandated them from day 1 just in case and subsequently maintained a binding > that is just an ever-growing list of every SoC. Oh well. Robin, A similar discussion was already done on v1 thread. Please see below for details: https://lore.kernel.org/linux-devicetree/20220317065925.GA9158@9a2d8922b8f1/ https://lore.kernel.org/linux-devicetree/726bde76-d792-febf-d364-6eedeb748c3b@canonical.com/ And final outcome of discussion turns out to add this compatible string. I see people with different set of perspective in regard to whether keep compatible string or not. We should have some sort of evidences to support claims so that next time when similar situation arises, we'll be aware beforehand how to proceed. - Kuldeep > > Robin. > > > Signed-off-by: Kuldeep Singh > > --- > > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > index ba2910f0a7b2..ea390e5df71d 100644 > > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > @@ -26,6 +26,7 @@ properties: > > - arm,armv8-timer > > - items: > > - enum: > > + - arm,cortex-a7-timer > > - arm,cortex-a15-timer > > - const: arm,armv7-timer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6486EC433F5 for ; Thu, 17 Mar 2022 21:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k4AtqIwVhoKprzKUx98ijA+YDZjsEtHSsRHkirzhd7I=; b=YUzQDqr5RlPBQ7 VWULlz9zGUr1eH0aUNbFZC2qoQzDYQBt/2ZTpYSjrV4kTrYEj5g1OGeToS37/8lu8PrsggaiOvary FIa/XRsQTR6OJ5BPcLYYE1hija6BrLIC+XQxvzmLHbOC/THhEiVvshkaRRW92ng431cAGr+U7WXbH I4UKiJbfG4NozVurO2P9ET5b8jn6aWQOopElmtxlHzDKACCBMymJac38oujHCOw/hcOsahZnIhD4C PdV5ZGxVDIYm2nIJhTJm7WzNxXN8kbalLkRwkNVr2Qreb45ffFzdIrnPWQwXi00rnb05Tp78uvGYW EJAFBQrIPuxbUfpStn7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUxdT-00HS5C-Gk; Thu, 17 Mar 2022 21:26:19 +0000 Received: from mail-pj1-f42.google.com ([209.85.216.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUxdP-00HS4q-TX for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 21:26:17 +0000 Received: by mail-pj1-f42.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so6636669pjl.4 for ; Thu, 17 Mar 2022 14:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O28KFB9Z1FTz+AymH1IN8bgHj7fL/zlAB/PUyRZgUJs=; b=p46uwofeLg5Vu8lhhImWBLOdalf9R9c51tbeP4ZqSXmJbVrnjwLKBmGO9x6y741/9C F1z3FT9GcfO3w8Uy5wgXkvY6Zwo2xF4zgYMtDHHrA2e3Tsx6H8wPajgjqunwWno7+obU O6jsg/z1Bm5Zqn45iBnmqEX6OA1XWo7u0lsPGuH6iRhhTvHzeE2ZhCcy8SVHLf76esom jC4E5SjBuceJocPckCw5BIzd3ZvDCUpxHgkpX8+G+QJVoz3BlD1LcuU1moF9RfTaOcXO EkObbZW7qdIyoS1dWuTav1xwouqRxh6yOZ1vBaCw4wPeTtMpIuOCslctpNdt1fGceRqP Q0kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O28KFB9Z1FTz+AymH1IN8bgHj7fL/zlAB/PUyRZgUJs=; b=A4vmLZdczoj+9yH651BDR0OkZd9jUMogLn9RB08ECr6j3AZ/Pfn9/h280woECU1Fu3 OhhIgcdVGhzyr4epDabZlFwfJ2/ByV+v/WKhHNSb4dE749QyyFAGM0+q/+OCoKNoah+Y 0p1waOWwmF5/TVxXyI2ImZPJZEW15AyqbIGgcSbG5xhkwrqpWzysOIz2xCOcrp14X11T 8c192UNgYVj5H1b1bFTu45RfwKR9WCi0oyS1JIv1441eViMH2Hb4c+YeRyzM2qQmBQon 4HIOLqtn69HYU8kLXpPImEFZF5q/WaG1QZpajznVVHvrXLgNfUJ8H0O0z7Zp7mI3Lb6Z cUJg== X-Gm-Message-State: AOAM5322vINOIS9n6jRW1LUHuc/mdNbqzlExuslHgT7wI41s3RZXRTtx k1rzbsrdNDQ8lI7Fb1kQiM29bNpBmPp3LA== X-Google-Smtp-Source: ABdhPJwiI+1DF6j6F1CN5z+IyxD3suUX3qc9ceGaxuETSEpJcT/76Ll3c9nj5XiMyX7kuDZiR4jblg== X-Received: by 2002:a17:90b:3e8c:b0:1bf:4043:daa with SMTP id rj12-20020a17090b3e8c00b001bf40430daamr7630460pjb.233.1647552315163; Thu, 17 Mar 2022 14:25:15 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.51.18]) by smtp.gmail.com with ESMTPSA id k185-20020a6384c2000000b003821dcd9020sm1284016pgd.27.2022.03.17.14.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 14:25:14 -0700 (PDT) Date: Fri, 18 Mar 2022 02:55:08 +0530 From: Kuldeep Singh To: Robin Murphy Cc: Marc Zyngier , Daniel Lezcano , Thomas Gleixner , Rob Herring , Marc Zyngier , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: timer: Document arm, cortex-a7-timer in arch timer Message-ID: <20220317212508.GB99538@9a2d8922b8f1> References: <20220317191527.96237-1-singh.kuldeep87k@gmail.com> <20220317191527.96237-3-singh.kuldeep87k@gmail.com> <558f0c92-c499-daca-e1ad-2b16137f8c06@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <558f0c92-c499-daca-e1ad-2b16137f8c06@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_142615_987622_F7106D2A X-CRM114-Status: GOOD ( 27.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 17, 2022 at 08:25:12PM +0000, Robin Murphy wrote: > On 2022-03-17 19:15, Kuldeep Singh wrote: > > Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in > > conjugation with "arm,armv7-timer". Since, initial entry is not > > documented, it start raising dtbs_check warnings. > > > > ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long > > 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] > > 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] > > > > Document this compatible to address it. The motivation to add this > > change is taken from an already existing entry "arm,cortex-a15-timer". > > Please note, this will not hurt any arch timer users. > > Eh, if it's never been documented or supported, I say just get rid of it. > The arch timer interface is by definition part of a CPU, and we can tell > what the CPU is by reading its ID registers. Indeed that's how the driver > handles the non-zero number of CPU-specific errata that already exist - we > don't need compatibles for that. > > In some ways it might have been nice to have *SoC-specific* compatibles > given the difficulty some integrators seem to have had in wiring up a stable > count *to* the interface, but it's not like they could be magically added to > already-deployed DTs after a bug is discovered, and nor could we have > mandated them from day 1 just in case and subsequently maintained a binding > that is just an ever-growing list of every SoC. Oh well. Robin, A similar discussion was already done on v1 thread. Please see below for details: https://lore.kernel.org/linux-devicetree/20220317065925.GA9158@9a2d8922b8f1/ https://lore.kernel.org/linux-devicetree/726bde76-d792-febf-d364-6eedeb748c3b@canonical.com/ And final outcome of discussion turns out to add this compatible string. I see people with different set of perspective in regard to whether keep compatible string or not. We should have some sort of evidences to support claims so that next time when similar situation arises, we'll be aware beforehand how to proceed. - Kuldeep > > Robin. > > > Signed-off-by: Kuldeep Singh > > --- > > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > index ba2910f0a7b2..ea390e5df71d 100644 > > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > > @@ -26,6 +26,7 @@ properties: > > - arm,armv8-timer > > - items: > > - enum: > > + - arm,cortex-a7-timer > > - arm,cortex-a15-timer > > - const: arm,armv7-timer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel