From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3264AC433F5 for ; Sun, 20 Mar 2022 20:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cOKdk1aQ1GTZFEw692CpSLn5lWKyjQqlMkjVqO1xlUg=; b=Vr+DrYjFzbQ32y WbLtJR5f816bSOepZmD1OPUKl/wM0nnvL42kUZ2tBR7vO0D4R+HIcqXhiTNiaOiBYuR7gIDzZYhaA n45Qd0bQxn3LaVsqFk+SKDJFX/m082dEWkM+nAPm7+OfzBqkioXxfN+Uf9t2xZhZoYD0DABYMOCmf i4q+KjbnPMC43zrrWLSdazGSj96xFp1Z58JIMAreP+ZkyU59WO7A6ouAtLaSPs2Y7xBDLPueNolMQ JtpJ7M08sdF1qJ/av4jLzfuNS5BSCnDZxAFaedg3HG1ae5eUiutH3PkB3JDpEZ9A6oCQxrspma5c2 SrIVMAkJQAvRjW7HoL+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nW2XP-005uKH-Di; Sun, 20 Mar 2022 20:52:31 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nW2XK-005uJl-DX for linux-arm-kernel@lists.infradead.org; Sun, 20 Mar 2022 20:52:27 +0000 Received: by mail-il1-x129.google.com with SMTP id e9so8455562ilu.9 for ; Sun, 20 Mar 2022 13:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amL/UE7zs4t+GbvQwTwptS5fVw1JEGvaoyRruxO2PoI=; b=eiN6aoC/d7xBm2fmS6GXLzCSV1cdC+bvO0UXbvOSCwrPRYE61s8JaKKaJDNbW2FbMu 8Glo/fnK4rXMyl1CN3LJHwGi8UhXd0YRjZ31YM0EotuR8bX+2gCySfbOO2N+1K0ZG/zH rHRna/2O3StGolRfDVaahMliom9HdyAehdj9Agju6pV7IsJ3OiWoeCxMKqClTUTpckBx fiVm3w1G/aDHlo5WHtk4d9d5NFZJYTZIge09K5Gigaru/koyDq7tUn3v5vW8M2fPsrrT M8Hi6+TiempjF8gmk2PX0jiohxlrhWdF54i6pTsGgZkbaMa2BcdrEv4OmnqoVHyf58ue RjjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amL/UE7zs4t+GbvQwTwptS5fVw1JEGvaoyRruxO2PoI=; b=3RMWErp7Jk4lM1bOkBlHNGeCP0EunKoCH5B3U3SrtCtXWYLVL2mOKWghImEDDsD/EL rN0DFgWrbkpYzgLRmh1RZh8Jf2ZZLkgsgOmA3+B2azdyH6YVZEdV8vJMwIR5EFfjFxi3 XPsVvIXCd8Ak5iDfiUMh53+quXUckrx2K8LqNWiCujy8IvrT4PvpyBzImbk7YVyNBH5k +zrds4CPbW7lphGsUw6OUimRr0n6raxEzbWRNtq7oMruq5ASpz8CrSvnpHw+QrdnxI7I LIOBOySw5uUscAr2vb7Jcic3WutZymJK7s6KQ5lvTd5f5G/1T8nC0Gwqndk0QT2YHGKd meMA== X-Gm-Message-State: AOAM530dZWJsYerdo1XSnsDWoCHQmOQ+8xnk/sCwidowteN1RywnN6Ww negU3XS6TRDf4OpJV16waocsL8tryEY= X-Google-Smtp-Source: ABdhPJxjKvyN438cwi4RqQKo5WRyYxgx5sn5XUjTndVAv47o+eFAdOd5o97GwgvK1Denw5rgMk5b0Q== X-Received: by 2002:a05:6e02:1986:b0:2c8:2b30:4913 with SMTP id g6-20020a056e02198600b002c82b304913mr723866ilf.81.1647809544451; Sun, 20 Mar 2022 13:52:24 -0700 (PDT) Received: from aford-IdeaCentre-A730.lan ([2601:448:8400:9e8:c72f:3c30:c692:940a]) by smtp.gmail.com with ESMTPSA id e17-20020a5d8ad1000000b00644d51bbffcsm7996318iot.36.2022.03.20.13.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 13:52:23 -0700 (PDT) From: Adam Ford To: linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Adam Ford , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , linux-kernel@vger.kernel.org Subject: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang Date: Sun, 20 Mar 2022 15:52:12 -0500 Message-Id: <20220320205212.701548-1-aford173@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220320_135226_513324_406562BB X-CRM114-Status: UNSURE ( 7.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS was set to 3. Because of this, attempts to enable the fourth clock failed, threw some splat, and ultimately hung. Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl") Signed-off-by: Adam Ford diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index a0a0d2d7ca4a..7109f0d508e2 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data { u32 mipi_phy_rst_mask; }; -#define DOMAIN_MAX_CLKS 3 +#define DOMAIN_MAX_CLKS 4 struct imx8m_blk_ctrl_domain { struct generic_pm_domain genpd; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212BAC433EF for ; Sun, 20 Mar 2022 20:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343642AbiCTUxv (ORCPT ); Sun, 20 Mar 2022 16:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233463AbiCTUxt (ORCPT ); Sun, 20 Mar 2022 16:53:49 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E703B542 for ; Sun, 20 Mar 2022 13:52:25 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id n16so9197663ile.11 for ; Sun, 20 Mar 2022 13:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amL/UE7zs4t+GbvQwTwptS5fVw1JEGvaoyRruxO2PoI=; b=eiN6aoC/d7xBm2fmS6GXLzCSV1cdC+bvO0UXbvOSCwrPRYE61s8JaKKaJDNbW2FbMu 8Glo/fnK4rXMyl1CN3LJHwGi8UhXd0YRjZ31YM0EotuR8bX+2gCySfbOO2N+1K0ZG/zH rHRna/2O3StGolRfDVaahMliom9HdyAehdj9Agju6pV7IsJ3OiWoeCxMKqClTUTpckBx fiVm3w1G/aDHlo5WHtk4d9d5NFZJYTZIge09K5Gigaru/koyDq7tUn3v5vW8M2fPsrrT M8Hi6+TiempjF8gmk2PX0jiohxlrhWdF54i6pTsGgZkbaMa2BcdrEv4OmnqoVHyf58ue RjjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amL/UE7zs4t+GbvQwTwptS5fVw1JEGvaoyRruxO2PoI=; b=jgicngW0Do+7ZMAz9iXri65Cf6HTHws8CiYTgKFY6XbesohE89tNhALAvXrbOIz1lh aRXJnMjkoGElQ8V2ZxxVrkw41legeiD6zyTbmZO8E4/bzrFuiv/fY02FTRshkJyEatTX mkJ2AcKIReMtc2e7oLrM7hwbyBJTBTFUJ0mdgI5QEtKsehaEUFPUDDRG2PCVBAfZL4OA WyVmnth0yEi6mnaSLCIuHi9nDbn7N31YYORxrwOJUk1sBLIA/mWk+29iIxWAWZJR9zN7 xW00H3OGOTe0y6UDbid0OBEG0vVnnfl68Y2cAw7uqMm4rRbNH93Bx/Gf0lrd2obUhPOE tWEw== X-Gm-Message-State: AOAM5304CeAShzcKqJV524r3naBOigSSeS8JeKEw/D4ZoIMMzqTuQjXj XekRojeRl7YPD44vTEOXoCw= X-Google-Smtp-Source: ABdhPJxjKvyN438cwi4RqQKo5WRyYxgx5sn5XUjTndVAv47o+eFAdOd5o97GwgvK1Denw5rgMk5b0Q== X-Received: by 2002:a05:6e02:1986:b0:2c8:2b30:4913 with SMTP id g6-20020a056e02198600b002c82b304913mr723866ilf.81.1647809544451; Sun, 20 Mar 2022 13:52:24 -0700 (PDT) Received: from aford-IdeaCentre-A730.lan ([2601:448:8400:9e8:c72f:3c30:c692:940a]) by smtp.gmail.com with ESMTPSA id e17-20020a5d8ad1000000b00644d51bbffcsm7996318iot.36.2022.03.20.13.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 13:52:23 -0700 (PDT) From: Adam Ford To: linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Adam Ford , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , linux-kernel@vger.kernel.org Subject: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang Date: Sun, 20 Mar 2022 15:52:12 -0500 Message-Id: <20220320205212.701548-1-aford173@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS was set to 3. Because of this, attempts to enable the fourth clock failed, threw some splat, and ultimately hung. Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl") Signed-off-by: Adam Ford diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index a0a0d2d7ca4a..7109f0d508e2 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data { u32 mipi_phy_rst_mask; }; -#define DOMAIN_MAX_CLKS 3 +#define DOMAIN_MAX_CLKS 4 struct imx8m_blk_ctrl_domain { struct generic_pm_domain genpd; -- 2.34.1