All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Weiss <luca.weiss@fairphone.com>
To: linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	Luca Weiss <luca.weiss@fairphone.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins
Date: Mon, 21 Mar 2022 14:33:16 +0100	[thread overview]
Message-ID: <20220321133318.99406-5-luca.weiss@fairphone.com> (raw)
In-Reply-To: <20220321133318.99406-1-luca.weiss@fairphone.com>

In other places the SDC and UFS pins have been swapped but this was
missed in the PINCTRL_PIN definitions. Fix that.

Fixes: 7d74b55afd27 ("pinctrl: qcom: Add SM6350 pinctrl driver")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- nothing

 drivers/pinctrl/qcom/pinctrl-sm6350.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sm6350.c b/drivers/pinctrl/qcom/pinctrl-sm6350.c
index 4d37b817b232..a91a86628f2f 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6350.c
@@ -264,14 +264,14 @@ static const struct pinctrl_pin_desc sm6350_pins[] = {
 	PINCTRL_PIN(153, "GPIO_153"),
 	PINCTRL_PIN(154, "GPIO_154"),
 	PINCTRL_PIN(155, "GPIO_155"),
-	PINCTRL_PIN(156, "SDC1_RCLK"),
-	PINCTRL_PIN(157, "SDC1_CLK"),
-	PINCTRL_PIN(158, "SDC1_CMD"),
-	PINCTRL_PIN(159, "SDC1_DATA"),
-	PINCTRL_PIN(160, "SDC2_CLK"),
-	PINCTRL_PIN(161, "SDC2_CMD"),
-	PINCTRL_PIN(162, "SDC2_DATA"),
-	PINCTRL_PIN(163, "UFS_RESET"),
+	PINCTRL_PIN(156, "UFS_RESET"),
+	PINCTRL_PIN(157, "SDC1_RCLK"),
+	PINCTRL_PIN(158, "SDC1_CLK"),
+	PINCTRL_PIN(159, "SDC1_CMD"),
+	PINCTRL_PIN(160, "SDC1_DATA"),
+	PINCTRL_PIN(161, "SDC2_CLK"),
+	PINCTRL_PIN(162, "SDC2_CMD"),
+	PINCTRL_PIN(163, "SDC2_DATA"),
 };
 
 #define DECLARE_MSM_GPIO_PINS(pin) \
-- 
2.35.1


  parent reply	other threads:[~2022-03-21 13:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 13:33 [PATCH v2 0/6] UFS support on SM6350 & FP4 Luca Weiss
2022-03-21 13:33 ` Luca Weiss
2022-03-21 13:33 ` [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string Luca Weiss
2022-03-21 13:40   ` Krzysztof Kozlowski
2022-03-21 15:41   ` Alim Akhtar
2022-03-21 21:45   ` Rob Herring
2022-03-21 21:45   ` Rob Herring
2022-03-21 13:33 ` [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings Luca Weiss
2022-03-21 13:33   ` [PATCH v2 2/6] dt-bindings: phy: qcom, qmp: " Luca Weiss
2022-03-21 13:41   ` [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: " Krzysztof Kozlowski
2022-03-21 13:41     ` Krzysztof Kozlowski
2022-03-21 21:46   ` Rob Herring
2022-03-21 21:46     ` Rob Herring
2022-04-11 18:04   ` Vinod Koul
2022-04-11 18:04     ` Vinod Koul
2022-03-21 13:33 ` [PATCH v2 3/6] phy: qcom-qmp: Add SM6350 UFS PHY support Luca Weiss
2022-03-21 13:33   ` Luca Weiss
2022-04-11 18:04   ` Vinod Koul
2022-04-11 18:04     ` Vinod Koul
2022-03-21 13:33 ` Luca Weiss [this message]
2022-03-21 14:15   ` [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins Bjorn Andersson
2022-03-21 14:21     ` Luca Weiss
2022-04-17 23:42   ` Linus Walleij
2022-03-21 13:33 ` [PATCH v2 5/6] arm64: dts: qcom: sm6350: Add UFS nodes Luca Weiss
2022-03-21 13:42   ` Krzysztof Kozlowski
2022-03-21 13:33 ` [PATCH v2 6/6] arm64: dts: qcom: sm7225-fairphone-fp4: Enable UFS Luca Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220321133318.99406-5-luca.weiss@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.