From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc244.phx1.oracleemaildelivery.com (aib29ajc244.phx1.oracleemaildelivery.com [192.29.103.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D278CC4332F for ; Mon, 21 Mar 2022 13:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=e9RwIMxR7hPX9Utc5kcyCLwr47HHd6RAgIOdW9In+pc=; b=NYMs6saJAI53C0UF1q7TxQIAIBzC8sYtT59eo6GiUUi+A0R0PVp6RautAhRZZriP1Ksg1FaRbcET v2C4eWA18lIRsUsJFQTu4/uiAOliWa7Je95HN1xlSuK65t45GAux3Qgi167Uci4spMh1W/VK9vvu yrbWerR7P//UdxDSSNZH++oYthBNoD62UDzkGTaQQ50bK3ZOmbwlxOMFeqM3ADb5BISlAiucmc/c hh9NfQlds8hd0X8M+ze0wZ+o5q6S+M43jVr/qTx4FqVGpqZ4E1hYDPRzxP7w3K3pKxeGXjsl93R0 ZqxgxKBJsh7wLFeCM4dbtKlAtBvTnoXy09+5/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=e9RwIMxR7hPX9Utc5kcyCLwr47HHd6RAgIOdW9In+pc=; b=s2VJv/6P+oONiAzMwyAu9oKxNE3yvX1VCrGUH3TJlNBwaPAEedCdDnmBTkdVW4CTgsb/00wuWZSs PV1FRyB1hcgrxRQIvC5aKR8cW2HwMXMzRnC5vNgdc/6slm6KC/HqlBUc32EuLMAuBHRLnLk7r7AQ 8ICu2S4MKBDBBobHySGnBY/70Y/x7iyrK38AfEhlZ/WTceH7hAycKlA+s9TXxfdF6sp5MfOE0ntO I4AOM8iMZ7oaWpa3lba54J3PXKo6h2+loU1ReSq8DJOWR8P4F1zXuZ50YI8oIOsrnWLCu311ftOw yIWjpdZvFeB0W/+ayVEFmq6gJV/u4Gl26LdE7w== Received: by omta-ad1-fd1-101-us-phoenix-1.omtaad1.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20220222 64bit (built Feb 22 2022)) with ESMTPS id <0R9300520LBN7U60@omta-ad1-fd1-101-us-phoenix-1.omtaad1.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Mon, 21 Mar 2022 13:54:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=Tt22W1rifVaLx1x3OAsAABHITtxbe6bpdWkKNftHfqWpnuiTETDsmM+4p3hz1yHllt74 RjLB9ooha9YjE4vYpJNmgeAghYDiz6Ryd48ieTbvQ+nfD4dGPH+m//WKlPzkOmtIBsKW qUFSdWPAXVaAc1+vWV+zimBi/AomWxzmyegLl5Mt3Sld/1pFGrWMFamIlTzH1Ya5+tKE K5Y6Pcvqr7Qa1qT36G5vqSz0COayDfCy18NDXIYfItEXHm/DSlBrmSuOaRJzHUjKB4rl 3NFzPNUqQGk5CXMDHLwQdttdpOQBF9fhJiQFZ8Zl+s018PFU10wOE69fwKPjCQbKglVe jw== Authentication-results: aserp3010.oracle.com; spf=softfail smtp.mailfrom=dan.carpenter@oracle.com; dkim=pass header.s=selector2-oracle-onmicrosoft-com header.d=oracle.onmicrosoft.com; dmarc=none header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+rJ3xJBZS7QO6TVPeEsV/RYCU1CsqNZ+d97E6icyL08PsSrcmzY8UxXxId3Rlr3GEc76vhC7i4IqXBp3rotMBXei8odTL6rO42zsIv03NRq6KBP9sfR2hhbV2dZr1D8bF98n4Hymx+ttPlcjOkJMF/L0SxyNrgSUMBWyRiUgi4vQ8wbf1fbyX3eUQhwlMyyce6zew3wr3twfQnHokoRTDvVJZVGuq82biKS33+TiY2dES6z4gjCobToKUEiaM61kboYZn72+/sRDiI4y2A8WtbpEKtx4pXwpvi19zRU1ewNBzAmEaHvEx1BYxE8NaZIkNxdt5Kc7VpRTyo37quLBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=jPyD+wm9q21HNZfkJZb5yZ0a6t1qMEwAyDAOh0vaU7iKCkfNCoiEFETWZsLMzXP3iCwPJhUP/ULU83McgewNYXmNYgeQGbxRJYKTVbXE6jmIEmVBpqSWJl0cDWB0chO+lgd2oDqSe6dq6W9l0V8E5RtnqWTqycT69YmoSNP1O/d7EOcV8jvHrsfiHObXj3R5S+gc9kRYqR6mhcpgXnZkHnIw13nggzsR3hkWpcmI4NCU8uqub2yEt0q3oP0R43MwRvBIJ6B6o46oARMQSvxBb1vYGCgd8ctmrp+R40Y7ebbtHfVU4Qt0ANQ/P0myPXkzodpV5I2qvwHsDYd4mGbd3Q== ARC-Authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=e47sx14z65X0O518KcQL+3QI5FE1o8hzh2E/w6iR4BIDqIwgG1oeRWYvMlnoGG0ujX38d1Ag996ORzKAaHEU9Qrq8wOs/mJ5XCpU3dw0kpI8u2gtBh6XL1QvsWnJ8k1O01oU4ZDXYAKxDpNYMjgAZmUZzK/dOCcf0vzagLT3qO0= Date: Mon, 21 Mar 2022 16:54:35 +0300 To: Jakob Koschel Message-id: <20220321135435.GL336@kadam> References: <20220319203106.2541700-1-jakobkoschel@gmail.com> Content-disposition: inline In-reply-to: User-Agent: Mutt/1.9.4 (2018-02-28) MIME-version: 1.0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:-1; SRV:; IPV:NLI; SFV:SKI; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:; DIR:INB; X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 13:54:46.9808 (UTC) X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210089 Cc: Linux Kernel Mailing List , "Bos, H.J." , Brian Johannesmeyer , Cristiano Giuffrida , Geert Uytterhoeven , Mike Rapoport , Miguel Ojeda , Masahiro Yamada , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: fix check if list iterator did find an element X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dan Carpenter via Ocfs2-devel Reply-to: Dan Carpenter Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-ClientProxiedBy: MR1P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::12) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1fb6d59-aebb-4dd0-59a8-08da0b425c15 X-MS-TrafficTypeDiagnostic: DM8PR10MB5462:EE_ X-Oracle-Tenancy: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xESGMhFcWSu4CZdjkuYjPRk3mADQ5mtFHTuGlgQNspc6nW6vH//p+g6KRUN2xyuT8jHojDgKRe4uUaTq53vOm52kdzrlZxeY0O1h8dWCb+PPOLBpYqMv/OBUVyXZt6UoqXDDgXKTqtJtwi1OiLmD6ClfAazTo4iTtC0QIBB4l0QOStuy91Wp5KprCTpLNyqwYD/KVGiGxEOLKL5YtZVRLFJqp14KSQkKDCMYKzRnMokebrHwn/VlfJXtgdfdRAUzy3+UbtG5Qiv6+wl+vhZuUjxTsST8rHCnmnJ9OfASPGmCt99q7zX+c3TK6bHRnuLixjpjLSI1dQdOvtvU4Mj3pEhnSBCt95GJGtx7QWOteR+CIxGybd5Ua9yKg3t71IFzf4afzHkh2If+H78ycvta2MUGaKH1E6iOeBOqXPV88E7laUhR/G/h0cs+XV3NpS9iPZ+BFTpdqDSYmE8RNDkA9FeAa2w1s/Qyt/+H2F67qupzj1r+Qd1ON7yC+aRZIfjWi/3dt9Z8qYyJfAFbY3NRgvCPzN13/B3z3XnsAqohUwYWAABUhs0KfDEnQ5qTQ/uqhRWZmk0CA+JXji3AOxBW3zv1+OqQ+ACLdaS9hi1BUYI= X-MS-Exchange-CrossTenant-Network-Message-Id: d1fb6d59-aebb-4dd0-59a8-08da0b425c15 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fjg2nBujdSPc2GEU2wpI2lZ5dmc3VWxVTLTi+03MJkEsMDluitCL0caZF1tQIUOj0va+dH45xp2zfBvDF8OW7zLEmOh8Tm9kqINy1sl7x1o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5462 X-MS-Exchange-CrossPremises-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-Mapi-Admin-Submission: X-MS-Exchange-CrossPremises-MessageSource: StoreDriver X-MS-Exchange-CrossPremises-BCC: Dan Carpenter X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 62.8.65.185 X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:SKI; SKIP:0; X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: DM8PR10MB5462.namprd10.prod.outlook.com X-Proofpoint-GUID: 1M6XKkMJgA5oypUDWyAbEhUkXhTaFFUi X-Proofpoint-ORIG-GUID: 1M6XKkMJgA5oypUDWyAbEhUkXhTaFFUi Reporting-Meta: AAG5jAG3e6h7BS/gM1AJazPowO47eCr4o1djqIJRSOE/4x7pINhhuVSssosdlqdQ z9+/y9qDdL04I320jFEs7WEP1F7R/iY0wyidIiGI7Y8DfYMcj+xFhalUYs6+3ak7 tloWRERY8Ej5ZOcXoslpaOkl16KwGn3RZPNJoI2ru2cZvJxoqs5Jmc6HjoeZc/6j 1ImcTr5NdeDferm1zrJXx3zl/lpHePWqKTrmLvsfeMWKMHlA2OlSgg9XqYTMK/ze dpi93l67VhCzg3NMShdfFnmf6byqJF3A6E05KsNlAlOzIspwNqvqUHWGHX1TDti2 Gda6GUTSwfMhKhzTjrFuKyMQRcLDdtP96ySN2BA99+Phv8z7I0ADrFXkqj2lSLT0 vOLE7DyB7xq998ybKBsdsWjc0cPpCRdip1bW0YxnH9W7PGDM9hszGXosxtPZj/H7 NftwxUh9yQ3+6R5oGGKF8RTlINduERKcgZPo2FcT+sGu0HA01opdXMHVWpnSmUE1 weKmDLwJe4LajHgWmF3JT6bMQ3AcLBKW+gvjpdtZsrS7CA== On Mon, Mar 21, 2022 at 02:34:34PM +0100, Jakob Koschel wrote: > >> @@ -556,11 +556,11 @@ static void *lockres_seq_start(struct seq_file *m, loff_t *pos) > >> } > >> } > >> > >> - list_for_each_entry(res, track_list, tracking) { > >> - if (&res->tracking == &dlm->tracking_list) > >> - res = NULL; > >> - else > >> - dlm_lockres_get(res); > >> + list_for_each_entry(iter, track_list, tracking) { > >> + if (&iter->tracking != &dlm->tracking_list) { This is an open coded version of: if (!list_entry_is_head(iter, &dlm->tracking_list, tracking)) { Ideally someone would come through with enough confidence to just delete it but the second best option is to just make it readable... regards, dan carpenter > >> + dlm_lockres_get(iter); > >> + res = iter; > >> + } > >> break; > >> } _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF485C433EF for ; Mon, 21 Mar 2022 13:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348401AbiCUOAT (ORCPT ); Mon, 21 Mar 2022 10:00:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348468AbiCUN5M (ORCPT ); Mon, 21 Mar 2022 09:57:12 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C294174BAB for ; Mon, 21 Mar 2022 06:55:17 -0700 (PDT) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCwOZf001109; Mon, 21 Mar 2022 13:54:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=Tt22W1rifVaLx1x3OAsAABHITtxbe6bpdWkKNftHfqWpnuiTETDsmM+4p3hz1yHllt74 RjLB9ooha9YjE4vYpJNmgeAghYDiz6Ryd48ieTbvQ+nfD4dGPH+m//WKlPzkOmtIBsKW qUFSdWPAXVaAc1+vWV+zimBi/AomWxzmyegLl5Mt3Sld/1pFGrWMFamIlTzH1Ya5+tKE K5Y6Pcvqr7Qa1qT36G5vqSz0COayDfCy18NDXIYfItEXHm/DSlBrmSuOaRJzHUjKB4rl 3NFzPNUqQGk5CXMDHLwQdttdpOQBF9fhJiQFZ8Zl+s018PFU10wOE69fwKPjCQbKglVe jw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew5s0kc67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 13:54:51 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LDpcAt021337; Mon, 21 Mar 2022 13:54:50 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by userp3020.oracle.com with ESMTP id 3exawgs34e-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 13:54:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KezjEzy75aszvbHCwLqzV/gz6bbRyZ6mGckfcrZOByb8bq8vpe2KiVApM7b3zkaiZQyySbFrwE5anlsNVxWxSAyoAJQlCuDrs63bpDLxLIn495oF4Uttexl96YC2+5NC2+eEtuS8rHpEUiiXTvGrcuYF6v50c4GpuVCzhQRoKY63wA6yNhvsc1AD0tXDprEUAFdHbJmXwD2evyNjWnMll6FwS0sH8GSzwU8DE/+vwDDfo32CfKKfgF4mEsYDbvDGtvZfOYv81h4/4tHP32mo6yWPBg/GlhQc4+3WBtHKMRcoE3g/zABXD6P+wqzhnpyDWczOa9zrS1neDDbT/rpb+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=ZBSkungWaVUzCUjYxPc0ZfkTzdYXcl0ek1f1+xqMUfd2KHFXs2HXsK/L1C17st3dUpY6P+0XUQ1ADEMyf+fAIH/UBVnMuOPXXoDTC6LYLaVOtziZHIzEn0sjcD8yDnPHCV2cYwG4iYN73KHpdZ9Hi8gi4uU3+REkine+2YW7qROTNE66kV2i2T4TzyDisfxfzqiBnLnMNr1ZFngQmxeYO2Hl9wAseaLWXUSSdpyJQUx34KZkXfg4jbsMgY6V/l4YTkA4IA/MqSGFd5+tXLAc3Iyz4dracbZJdRDkRSfDJRqcc/XDYjqYbK6sZO0pw4wDzB7UIa5SY2yqK+++i/PUZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LojAHNHQAO2wcQ8UjhROsifyzn9vDUjoeJySsg8W6tA=; b=g+JnQCnJ1cbAN42IBGpHvOxZ6duyG2fUnYEVy/gNj+lvx/aT+adPjO+m0SaOqzy62h6iVzGEnexHV3+sRuvTAmuIsikIY+bLGB+GTZb7UZ9x74UEpiQLL4vVxZIPHwILgpgaF4kZkxOaf0eWJhZ/Lv+OaQRNOzawgpHr1f3rcro= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DM8PR10MB5462.namprd10.prod.outlook.com (2603:10b6:8:26::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 13:54:47 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c%7]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 13:54:47 +0000 Date: Mon, 21 Mar 2022 16:54:35 +0300 From: Dan Carpenter To: Jakob Koschel Cc: Joseph Qi , Mark Fasheh , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com, Joel Becker , Andrew Morton , Geert Uytterhoeven , Masahiro Yamada , Miguel Ojeda , Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Subject: Re: [PATCH] ocfs2: fix check if list iterator did find an element Message-ID: <20220321135435.GL336@kadam> References: <20220319203106.2541700-1-jakobkoschel@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MR1P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::12) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1fb6d59-aebb-4dd0-59a8-08da0b425c15 X-MS-TrafficTypeDiagnostic: DM8PR10MB5462:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6ZhRQhgLo7qmneEuIp1ILXvkWpHUhB7iK0Wa9vuIS/3q5fAKZ7LDahjOQpNoo8UBXgUc+KVVYdd08OqzcCxE2C2xNRfOEQ+BczsZxudnii2O6YE+JMZIgJccvE97bkJhOedvz50anZRPfyGvomn5hFnx0HQSqmWQXrBqHP12WfWZ54feq0Uy3fNobO6T0JH8Sk8J/YcAO/OnJFfQgBDdJjbDpBCXlIZ5WPEyCjjJupvh1qZuWpbQ2MmyV61uEqgHaep4v9ftb7LJYexBO4qjnd/45bBTeb6FIw9KYrYbsspJVVkZdIuUumX2Kq/fg/TabGtvvkWPjUJ+md0k1AkDnSlWl+08JTmoBiqJn3FSojUuaaI22KLxSmIR8VYaK6c1B4+xY6oKTeTs0yW7fPoT7UMBjRAxLKmO3VBiTFZjnOHChsrJxEPz35vpCtKZidzcH76DVVHX1EY5DQt1qpMjFtH6NSYZhscOoKqciSzV7ZNPeb+frlbQBrpvyCn81+AlymRZUPzL8yvV0UF88guD4gYihZBhDMekaPwdaaVsqhveqJSwv/jndMLwstAZ8p/okEybcxSopfJzBZG62sX6iM1+2SpkJdTl0p+xq3EeBCErpJ6W7qqyWoVykjWfMMpTfRFWWMxV4AnTko6klqEuusEhX2XUjvaj3/FGMdiFTSH0uLNM5eYhtoY6QlSTntz3VidgqICrqU1+1V/tZV9rMg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(6486002)(508600001)(38350700002)(316002)(6916009)(38100700002)(54906003)(83380400001)(66556008)(9686003)(6512007)(6506007)(33716001)(6666004)(26005)(186003)(1076003)(52116002)(33656002)(8676002)(66476007)(66946007)(4326008)(86362001)(44832011)(7416002)(8936002)(4744005)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nv/11lVbF0/3RGPflPIzMAZC050S83HXckdna7h6QpdAjBc3ofW1XHEm9YCQ?= =?us-ascii?Q?9wEbMj3e+H8bT8EftTBNesyfyzMCx4mK80tQMMkJU9VH/hkaFK9qJ314H51o?= =?us-ascii?Q?CrK/43xbdTe30bubGxOTvlAzNDdNmhYRuOQuY+EuY8e84M6vWTQa0jnxOOUM?= =?us-ascii?Q?SDMd3ZmNdMFCvlt/5DDnmXWe3XrfRpuf1GdQNAIs/9GqfkUZVzV2a5qq+AfV?= =?us-ascii?Q?8vtEl66HIgvEi9ztV7ItyTZ+qNRUKhvwxSZQb9U5WbN8klXsNAU9ScYr2D7u?= =?us-ascii?Q?vyfNZFcBryLahwqliKfO1+2XtX+zEE6pZ3qlxrJNtxjckQl4oXgnj8t/6pv9?= =?us-ascii?Q?y2dzLmdSp4jFpDq7KEo03CY/mn2DJUARGQweA1WajqfEaPuF9i9cdVxvNqTF?= =?us-ascii?Q?qDc7l5YrihezLnamb205lSzuHKzp7hpjhV+8U5pfc5cZJsasxJWZVqbjjaWH?= =?us-ascii?Q?0N4ZIZ5PhBOAIaVBbB/5IMAuZnPWwExtP3cAzRoMunlEjaJwNplt0llpdYih?= =?us-ascii?Q?EmbZPXO1rZoy7sQEc+svQKzrXqrlW+TmPOHuRO57Hvw9+TH+IK50fsUpdWzl?= =?us-ascii?Q?KDguYc8fY4a1wOloM9HeWv3xpXNmG0K53Tx/+kaHwHxoAOXIho7eqfbD/VSb?= =?us-ascii?Q?uX4BFmdPf6ge/eRtGrClIxilPUDzu5+77UvtA/4XpqMJSUnzfnwULfiE1Wg0?= =?us-ascii?Q?oPPK7U0Q7U9KGTLx9mB/rGxRqWD0ShydBv+2Qs428d4O31aV/NO/0RiGtKln?= =?us-ascii?Q?3AX/a+M8oWj3LPsJ209sEhQOsA9zFvrwdiqLFrOBf9Xb/J3mP9LLub7tn7AG?= =?us-ascii?Q?MyLsCL/vy7YK2M/T3iZYp8TX49kdV7jtkj9zz7HgcQ4JbDgnWMOl2SugM1gM?= =?us-ascii?Q?CfSzUQ3Ev7cI+yJopWxVrjFoLDPxuqzOTPGyl4170WdGIx6HSMgAZpv8sBgh?= =?us-ascii?Q?RBIm3wK1sPvA6sufc/8WQpqHexv84FS2ELqCEjsbeb/OTPyAvzIwsxnYV0A5?= =?us-ascii?Q?WR2TqyNHQeORFTn5ZLCtjHxDbEIdj9pRLZ6O7ZfrAbViHrlLC21aKPg174fi?= =?us-ascii?Q?tGjDeGX1MHZ8ThWU6W/mWq/rxy7DRH8f6e0EiQzRN3YyognwIMBkuIJhDaQ4?= =?us-ascii?Q?cV00oQf8oiDMoOnNIPAX8qBRfr8cEqPPqoTl3RUK9k3HzAw4pdtk8BFblQby?= =?us-ascii?Q?EaZ7BzEkuRO5Hn4FJcftAYG8HTNRsDtghiVdyQxx8PLrdoDtIiLgZkzEZEOy?= =?us-ascii?Q?vCgxU5rXq2uxPeLejdfMX7tbQ6ZR5s7UhLeLiMHXpuSZWubaoFfXXeeqJzNW?= =?us-ascii?Q?FOhSyffar6lvg8xI3tAnP4HSJI+T3r7DALkqCbyVaum5ByodPRuDzMXP69xB?= =?us-ascii?Q?INH0B7NOBRxUygRCfz0+x7bVmUmasyEPsSmGaqUMkyGOSDuStgOK/MlWG6ai?= =?us-ascii?Q?s6yd6sJgex1j/0ZDitui15WKdcJKPBti/IZhXkkm6jthIRtukNYUBw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1fb6d59-aebb-4dd0-59a8-08da0b425c15 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 13:54:46.9808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fjg2nBujdSPc2GEU2wpI2lZ5dmc3VWxVTLTi+03MJkEsMDluitCL0caZF1tQIUOj0va+dH45xp2zfBvDF8OW7zLEmOh8Tm9kqINy1sl7x1o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5462 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210089 X-Proofpoint-GUID: yjI8ed8unVZUfISI_wGoDTtO7T4Hdg7R X-Proofpoint-ORIG-GUID: yjI8ed8unVZUfISI_wGoDTtO7T4Hdg7R Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 02:34:34PM +0100, Jakob Koschel wrote: > >> @@ -556,11 +556,11 @@ static void *lockres_seq_start(struct seq_file *m, loff_t *pos) > >> } > >> } > >> > >> - list_for_each_entry(res, track_list, tracking) { > >> - if (&res->tracking == &dlm->tracking_list) > >> - res = NULL; > >> - else > >> - dlm_lockres_get(res); > >> + list_for_each_entry(iter, track_list, tracking) { > >> + if (&iter->tracking != &dlm->tracking_list) { This is an open coded version of: if (!list_entry_is_head(iter, &dlm->tracking_list, tracking)) { Ideally someone would come through with enough confidence to just delete it but the second best option is to just make it readable... regards, dan carpenter > >> + dlm_lockres_get(iter); > >> + res = iter; > >> + } > >> break; > >> }