From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B70C433FE for ; Mon, 21 Mar 2022 22:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231215AbiCUWz7 (ORCPT ); Mon, 21 Mar 2022 18:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbiCUWzl (ORCPT ); Mon, 21 Mar 2022 18:55:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64DDB4546DA; Mon, 21 Mar 2022 15:37:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 116EE612DC; Mon, 21 Mar 2022 21:53:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56720C340F7; Mon, 21 Mar 2022 21:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647899592; bh=d/cY7PKqDZsO7roqJnKo+pFXp8Zl8yqMxxZoCi2Jn6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EnVv/j1oVm0zHUpwOQ+DN/Dqna6JR6HAyCaNIu/f7QVjxF8/I+cqBTmRjGZPZdpMq 1i2qv8aEszG4M4qTEvOstXxLGl7VjSh6bXBufdfz/ev+aTBtShfIoWOzYKN3buO+vK u5priAQsFVXrHUDto+w/pVgarZsp9yh5bvUQL5JgyZG0b2vfgJRh82NQPjPZ5Xh0/4 L/rm9KMRnsFhAydrr4UhwlAMXsl3cpS2I73m8WmYLgjqfeieia4Ca7E+7amguUxF/t V5opRIDirV3koV19MVrdL4A5cO8Ls4eOW6AZOXTAzAtvrzSrr8jqsnCXdRLtqBzyKA Ah9eD8h5VpE+g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haimin Zhang , TCS Robot , Steffen Klassert , Sasha Levin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 2/4] af_key: add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register Date: Mon, 21 Mar 2022 17:53:03 -0400 Message-Id: <20220321215308.490358-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220321215308.490358-1-sashal@kernel.org> References: <20220321215308.490358-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haimin Zhang [ Upstream commit 9a564bccb78a76740ea9d75a259942df8143d02c ] Add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register to initialize the buffer of supp_skb to fix a kernel-info-leak issue. 1) Function pfkey_register calls compose_sadb_supported to request a sk_buff. 2) compose_sadb_supported calls alloc_sbk to allocate a sk_buff, but it doesn't zero it. 3) If auth_len is greater 0, then compose_sadb_supported treats the memory as a struct sadb_supported and begins to initialize. But it just initializes the field sadb_supported_len and field sadb_supported_exttype without field sadb_supported_reserved. Reported-by: TCS Robot Signed-off-by: Haimin Zhang Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/key/af_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/key/af_key.c b/net/key/af_key.c index d1364b858fdf..bd9b5c573b5a 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c @@ -1703,7 +1703,7 @@ static int pfkey_register(struct sock *sk, struct sk_buff *skb, const struct sad xfrm_probe_algs(); - supp_skb = compose_sadb_supported(hdr, GFP_KERNEL); + supp_skb = compose_sadb_supported(hdr, GFP_KERNEL | __GFP_ZERO); if (!supp_skb) { if (hdr->sadb_msg_satype != SADB_SATYPE_UNSPEC) pfk->registered &= ~(1<sadb_msg_satype); -- 2.34.1