From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC778C433EF for ; Mon, 21 Mar 2022 22:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbiCUW5O (ORCPT ); Mon, 21 Mar 2022 18:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbiCUW4F (ORCPT ); Mon, 21 Mar 2022 18:56:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ECCF3AF759; Mon, 21 Mar 2022 15:37:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C2C26142E; Mon, 21 Mar 2022 21:53:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22875C340EE; Mon, 21 Mar 2022 21:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647899601; bh=N3X3GCqABivRcIbG+WVle9SGZOPOyUuweV3hUKeVqms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dAXehB/PXdK2ymGFI9UGy3c6/TBABafrcmYopah7FT5toEMzxQ8SIgjupLZ7HHceB PV4aPjSdUz8cBxHGYoSIZZ4u6vkNQS/oP5xCEX4GQ72JBntIFDrj/xcDagXxnj4SMU SlsA6RiMFCyBoBPCqHljUJdHWDN2gwfjGZnO+J1TaDdqNguKYAHeXR+yZGzVx5ZtAZ STMbRSzMcOdK3rOGO3Wy+InggfRx6uermHdMFSvMaw/J32+p9ReDDDkpnHi4bOT4Jp qdFd+8nO6V1xj7rO+13EP62GaSyFDiWLgWevwtTe2YAbD3YrzlI+JUoVLAzrtSsm8U StCOcdQQBeSoA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tadeusz Struk , syzbot+e223cf47ec8ae183f2a0@syzkaller.appspotmail.com, Willem de Bruijn , Jakub Kicinski , Sasha Levin , davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 2/3] net: ipv6: fix skb_over_panic in __ip6_append_data Date: Mon, 21 Mar 2022 17:53:15 -0400 Message-Id: <20220321215317.490418-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220321215317.490418-1-sashal@kernel.org> References: <20220321215317.490418-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tadeusz Struk [ Upstream commit 5e34af4142ffe68f01c8a9acae83300f8911e20c ] Syzbot found a kernel bug in the ipv6 stack: LINK: https://syzkaller.appspot.com/bug?id=205d6f11d72329ab8d62a610c44c5e7e25415580 The reproducer triggers it by sending a crafted message via sendmmsg() call, which triggers skb_over_panic, and crashes the kernel: skbuff: skb_over_panic: text:ffffffff84647fb4 len:65575 put:65575 head:ffff888109ff0000 data:ffff888109ff0088 tail:0x100af end:0xfec0 dev: Update the check that prevents an invalid packet with MTU equal to the fregment header size to eat up all the space for payload. The reproducer can be found here: LINK: https://syzkaller.appspot.com/text?tag=ReproC&x=1648c83fb00000 Reported-by: syzbot+e223cf47ec8ae183f2a0@syzkaller.appspotmail.com Signed-off-by: Tadeusz Struk Acked-by: Willem de Bruijn Link: https://lore.kernel.org/r/20220310232538.1044947-1-tadeusz.struk@linaro.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/ip6_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 918a9520d1f1..360679600957 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1429,8 +1429,8 @@ static int __ip6_append_data(struct sock *sk, sizeof(struct frag_hdr) : 0) + rt->rt6i_nfheader_len; - if (mtu < fragheaderlen || - ((mtu - fragheaderlen) & ~7) + fragheaderlen < sizeof(struct frag_hdr)) + if (mtu <= fragheaderlen || + ((mtu - fragheaderlen) & ~7) + fragheaderlen <= sizeof(struct frag_hdr)) goto emsgsize; maxfraglen = ((mtu - fragheaderlen) & ~7) + fragheaderlen - -- 2.34.1