From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
"Matthias Kaehlcke" <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>
Subject: Re: [PATCH v11 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs
Date: Tue, 22 Mar 2022 14:03:35 +0530 [thread overview]
Message-ID: <20220322083335.GK23316@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <1647932876-23249-4-git-send-email-quic_c_sanm@quicinc.com>
On Tue, Mar 22, 2022 at 12:37:54PM +0530, Sandeep Maheswaram wrote:
> Adding helper functions to enable,disable wake irqs to make
> the code simple and readable.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 58 ++++++++++++++++++++------------------------
> 1 file changed, 26 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 6cba990..7352124 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -296,50 +296,44 @@ static void dwc3_qcom_interconnect_exit(struct dwc3_qcom *qcom)
> icc_put(qcom->icc_path_apps);
> }
>
> +static void dwc3_qcom_enable_wakeup_irq(int irq)
> +{
> + if (!irq)
> + return;
> +
> + enable_irq(irq);
> + enable_irq_wake(irq);
> +}
> +
> +static void dwc3_qcom_disable_wakeup_irq(int irq)
> +{
> + if (!irq)
> + return;
> +
> + disable_irq_wake(irq);
> + disable_irq_nosync(irq);
> +}
> +
> static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom)
> {
> - if (qcom->hs_phy_irq) {
> - disable_irq_wake(qcom->hs_phy_irq);
> - disable_irq_nosync(qcom->hs_phy_irq);
> - }
> + dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq);
>
> - if (qcom->dp_hs_phy_irq) {
> - disable_irq_wake(qcom->dp_hs_phy_irq);
> - disable_irq_nosync(qcom->dp_hs_phy_irq);
> - }
> + dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq);
>
> - if (qcom->dm_hs_phy_irq) {
> - disable_irq_wake(qcom->dm_hs_phy_irq);
> - disable_irq_nosync(qcom->dm_hs_phy_irq);
> - }
> + dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq);
>
> - if (qcom->ss_phy_irq) {
> - disable_irq_wake(qcom->ss_phy_irq);
> - disable_irq_nosync(qcom->ss_phy_irq);
> - }
> + dwc3_qcom_disable_wakeup_irq(qcom->ss_phy_irq);
> }
>
> static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom)
> {
> - if (qcom->hs_phy_irq) {
> - enable_irq(qcom->hs_phy_irq);
> - enable_irq_wake(qcom->hs_phy_irq);
> - }
> + dwc3_qcom_enable_wakeup_irq(qcom->hs_phy_irq);
>
> - if (qcom->dp_hs_phy_irq) {
> - enable_irq(qcom->dp_hs_phy_irq);
> - enable_irq_wake(qcom->dp_hs_phy_irq);
> - }
> + dwc3_qcom_enable_wakeup_irq(qcom->dp_hs_phy_irq);
>
> - if (qcom->dm_hs_phy_irq) {
> - enable_irq(qcom->dm_hs_phy_irq);
> - enable_irq_wake(qcom->dm_hs_phy_irq);
> - }
> + dwc3_qcom_enable_wakeup_irq(qcom->dm_hs_phy_irq);
>
> - if (qcom->ss_phy_irq) {
> - enable_irq(qcom->ss_phy_irq);
> - enable_irq_wake(qcom->ss_phy_irq);
> - }
> + dwc3_qcom_enable_wakeup_irq(qcom->ss_phy_irq);
> }
>
> static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
Looks good to me.
Thanks,
Pavan
next prev parent reply other threads:[~2022-03-22 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 7:07 [PATCH v11 0/5] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-03-22 7:07 ` [PATCH v11 1/5] usb: dwc3: core: Add HS phy mode variable and phy poweroff flag Sandeep Maheswaram
2022-03-22 8:09 ` Pavan Kondeti
2022-03-22 8:42 ` Sandeep Maheswaram (Temp)
2022-03-22 7:07 ` [PATCH v11 2/5] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-03-22 8:32 ` Pavan Kondeti
2022-03-22 8:40 ` Pavan Kondeti
2022-04-05 9:25 ` Pavan Kondeti
2022-03-23 18:07 ` Matthias Kaehlcke
2022-03-24 4:54 ` Sandeep Maheswaram (Temp)
2022-03-30 4:03 ` Pavan Kondeti
2022-03-30 16:46 ` Matthias Kaehlcke
2022-03-31 3:14 ` Pavan Kondeti
2022-03-22 7:07 ` [PATCH v11 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-03-22 8:33 ` Pavan Kondeti [this message]
2022-03-22 7:07 ` [PATCH v11 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2022-03-22 8:36 ` Pavan Kondeti
2022-03-22 7:07 ` [PATCH v11 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-03-22 8:37 ` Pavan Kondeti
2022-03-22 9:18 ` Sandeep Maheswaram (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322083335.GK23316@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.