All of lore.kernel.org
 help / color / mirror / Atom feed
From: <alexandru.tachici@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <jic23@kernel.org>, Alexandru Tachici <alexandru.tachici@analog.com>
Subject: [PATCH v3 1/6] iio: adc: ad7124: Remove shift from scan_type
Date: Tue, 22 Mar 2022 12:50:24 +0200	[thread overview]
Message-ID: <20220322105029.86389-2-alexandru.tachici@analog.com> (raw)
In-Reply-To: <20220322105029.86389-1-alexandru.tachici@analog.com>

From: Alexandru Tachici <alexandru.tachici@analog.com>

The 24 bits data is stored in 32 bits in BE. There
is no need to shift it. This confuses user-space apps.

Fixes: b3af341bbd966 ("iio: adc: Add ad7124 support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
 drivers/iio/adc/ad7124.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 998a342d51a6..7249db2c4422 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -188,7 +188,6 @@ static const struct iio_chan_spec ad7124_channel_template = {
 		.sign = 'u',
 		.realbits = 24,
 		.storagebits = 32,
-		.shift = 8,
 		.endianness = IIO_BE,
 	},
 };
-- 
2.25.1


  reply	other threads:[~2022-03-22 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 10:50 [PATCH v3 0/6] iio: adc: ad_sigma_delta: Add sequencer support alexandru.tachici
2022-03-22 10:50 ` alexandru.tachici [this message]
2022-03-22 10:50 ` [PATCH v3 2/6] iio: adc: ad7124: Add update_scan_mode alexandru.tachici
2022-03-22 10:50 ` [PATCH v3 3/6] iio: adc: ad7192: " alexandru.tachici
2022-03-22 10:50 ` [PATCH v3 4/6] iio: adc: ad_sigma_delta: Add sequencer support alexandru.tachici
2022-03-22 10:50 ` [PATCH v3 5/6] iio: adc: ad7124: add " alexandru.tachici
2022-03-22 10:50 ` [PATCH v3 6/6] iio: adc: ad7192: " alexandru.tachici
2022-03-22 21:30 ` [PATCH v3 0/6] iio: adc: ad_sigma_delta: Add " Jonathan Cameron
2022-03-27 15:10   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322105029.86389-2-alexandru.tachici@analog.com \
    --to=alexandru.tachici@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.