From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4971EC433F5 for ; Tue, 22 Mar 2022 11:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234127AbiCVLZF (ORCPT ); Tue, 22 Mar 2022 07:25:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232938AbiCVLZE (ORCPT ); Tue, 22 Mar 2022 07:25:04 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20E051F623; Tue, 22 Mar 2022 04:23:36 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CE79568AFE; Tue, 22 Mar 2022 12:23:31 +0100 (CET) Date: Tue, 22 Mar 2022 12:23:31 +0100 From: Christoph Hellwig To: John Garry Cc: axboe@kernel.dk, damien.lemoal@opensource.wdc.com, bvanassche@acm.org, jejb@linux.ibm.com, martin.petersen@oracle.com, hch@lst.de, ming.lei@redhat.com, hare@suse.de, chenxiang66@hisilicon.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, beanhuo@micron.com Subject: Re: [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer Message-ID: <20220322112331.GD29270@lst.de> References: <1647945585-197349-1-git-send-email-john.garry@huawei.com> <1647945585-197349-5-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1647945585-197349-5-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Wouldn't it make more sense to have a new member in th Scsi_Host_template that gets called for these request early from ->queue_rq instead of the new request_queue and custome ops? FYI, I think reusing the block layer for all these command is a good idea but the way it is done here seems a bit ugly and not very maintainable. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF259C433F5 for ; Tue, 22 Mar 2022 11:23:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-208-JnJVYvvwP5uUfyU7baYF4Q-1; Tue, 22 Mar 2022 07:23:41 -0400 X-MC-Unique: JnJVYvvwP5uUfyU7baYF4Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B14743804504; Tue, 22 Mar 2022 11:23:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DBAB53D8; Tue, 22 Mar 2022 11:23:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2453F1949762; Tue, 22 Mar 2022 11:23:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7332C1947BBC for ; Tue, 22 Mar 2022 11:23:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 60C96401E86; Tue, 22 Mar 2022 11:23:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CAE1401E80 for ; Tue, 22 Mar 2022 11:23:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48BA080159B for ; Tue, 22 Mar 2022 11:23:38 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-DAB4WUV-P4aA4O99Gjf3MQ-1; Tue, 22 Mar 2022 07:23:36 -0400 X-MC-Unique: DAB4WUV-P4aA4O99Gjf3MQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id CE79568AFE; Tue, 22 Mar 2022 12:23:31 +0100 (CET) Date: Tue, 22 Mar 2022 12:23:31 +0100 From: Christoph Hellwig To: John Garry Message-ID: <20220322112331.GD29270@lst.de> References: <1647945585-197349-1-git-send-email-john.garry@huawei.com> <1647945585-197349-5-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 In-Reply-To: <1647945585-197349-5-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Subject: Re: [dm-devel] [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, bvanassche@acm.org, martin.petersen@oracle.com, chenxiang66@hisilicon.com, damien.lemoal@opensource.wdc.com, linux-kernel@vger.kernel.org, hch@lst.de, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, ming.lei@redhat.com, jejb@linux.ibm.com, beanhuo@micron.com Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Wouldn't it make more sense to have a new member in th Scsi_Host_template that gets called for these request early from ->queue_rq instead of the new request_queue and custome ops? FYI, I think reusing the block layer for all these command is a good idea but the way it is done here seems a bit ugly and not very maintainable. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel