All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, marek.behun@nic.cz
Subject: Re: [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors
Date: Tue, 22 Mar 2022 19:48:58 +0100	[thread overview]
Message-ID: <20220322184858.irr5p75tdu4mths3@pali> (raw)
In-Reply-To: <20220322105857.1107016-2-robert.marko@sartura.hr>

On Tuesday 22 March 2022 11:58:57 Robert Marko wrote:
> uDPU has a pair of NCT375 temperature sensors, which are TMP75C compatible
> as far as the driver is concerned.
> 
> The current LM75 compatible worked as all of the LM75 compatible sensors
> are backwards compatible with the original part, but it meant that lower
> resolution and incorrect sample rate was being used.
> 
> The "lm75" compatible has been deprecated anyway and is meant as fallback
> in order to keep older DTS-es working.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
> Changes in v2:
> * None
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index ac64949bb53e..1f534c0c65f7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -153,15 +153,15 @@ &i2c1 {
>  	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  
> -	lm75@48 {
> +	nct375@48 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x48>;
>  	};
>  
> -	lm75@49 {
> +	nct375@49 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x49>;
>  	};
>  };
> -- 
> 2.35.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, marek.behun@nic.cz
Subject: Re: [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors
Date: Tue, 22 Mar 2022 19:48:58 +0100	[thread overview]
Message-ID: <20220322184858.irr5p75tdu4mths3@pali> (raw)
In-Reply-To: <20220322105857.1107016-2-robert.marko@sartura.hr>

On Tuesday 22 March 2022 11:58:57 Robert Marko wrote:
> uDPU has a pair of NCT375 temperature sensors, which are TMP75C compatible
> as far as the driver is concerned.
> 
> The current LM75 compatible worked as all of the LM75 compatible sensors
> are backwards compatible with the original part, but it meant that lower
> resolution and incorrect sample rate was being used.
> 
> The "lm75" compatible has been deprecated anyway and is meant as fallback
> in order to keep older DTS-es working.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
> Changes in v2:
> * None
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index ac64949bb53e..1f534c0c65f7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -153,15 +153,15 @@ &i2c1 {
>  	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  
> -	lm75@48 {
> +	nct375@48 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x48>;
>  	};
>  
> -	lm75@49 {
> +	nct375@49 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x49>;
>  	};
>  };
> -- 
> 2.35.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-03-22 18:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 10:58 [PATCH v2 1/2] arm64: dts: uDPU: update partition table Robert Marko
2022-03-22 10:58 ` Robert Marko
2022-03-22 10:58 ` [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors Robert Marko
2022-03-22 10:58   ` Robert Marko
2022-03-22 12:19   ` Andrew Lunn
2022-03-22 12:19     ` Andrew Lunn
2022-03-22 18:48   ` Pali Rohár [this message]
2022-03-22 18:48     ` Pali Rohár
2022-03-22 12:20 ` [PATCH v2 1/2] arm64: dts: uDPU: update partition table Andrew Lunn
2022-03-22 12:20   ` Andrew Lunn
2022-03-22 18:47 ` Pali Rohár
2022-03-22 18:47   ` Pali Rohár
2022-05-09  8:47 ` Gregory CLEMENT
2022-05-09  8:47   ` Gregory CLEMENT
2022-05-10 13:56 ` Krzysztof Kozlowski
2022-05-10 13:56   ` Krzysztof Kozlowski
2022-05-10 15:17   ` Robert Marko
2022-05-10 15:17     ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322184858.irr5p75tdu4mths3@pali \
    --to=pali@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.