From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3074C43217 for ; Tue, 22 Mar 2022 19:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbiCVTJb (ORCPT ); Tue, 22 Mar 2022 15:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbiCVTJ3 (ORCPT ); Tue, 22 Mar 2022 15:09:29 -0400 Received: from meesny.iki.fi (meesny.iki.fi [IPv6:2001:67c:2b0:1c1::201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B56861A6; Tue, 22 Mar 2022 12:08:00 -0700 (PDT) Received: from darkstar.musicnaut.iki.fi (85-76-100-34-nat.elisa-mobile.fi [85.76.100.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by meesny.iki.fi (Postfix) with ESMTPSA id B3C5F20388; Tue, 22 Mar 2022 21:07:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=cX6LmeT38lN2NaF7Qsx5VX0GwklLy2du9kOpxTh3b4+Qw5wrtoKy5+CaPdFHVPF7PUQJV7 JP0eZNy7X0Jfbj3WAB5bQXsUGhmUeS+qIfMHxdWpTOM+QUCxar+jfmcf0+g1AFcQ1pCKkA q4bRX979489LLYULp2d8EW4EbP4qAGY= Date: Tue, 22 Mar 2022 21:07:53 +0200 From: Aaro Koskinen To: Janusz Krzysztofik Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220321215416.236250-1-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220322163646.GD297526@darkstar.musicnaut.iki.fi> ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1647976075; a=rsa-sha256; cv=none; b=X6jYN8e4edIdwhVqd08HooVar4l9k4zaeYIbPBffuNKwdkVOZqop0cLduutP177L6DWw1t z3md1/KyrpNc4Oj2NmcgYKgqs06xOi37+Q82NbgDQR7qRGbl7dmfLBEOUOb/ZvPz8Q9kzG iv9WWWKrxOwoKKPEYH88Tk0Gi1Jit1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=uVqGTgouIQJQ2R58scj6U0J2KM/YtrOq4hq0tSnqJjTw6VkH13Shbd3ZumElBWGBl6w/C+ SIBA6Ck0VAZhNiAy4cgvRL+DdTJJmixLaEk9B9FpqhWM/Nmc5koLsdctAdg9syFOac++N8 L8McGNzCb7F/2+k2v1U0gta89xs02Sw= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > In preparation for conversion of OMAP1 clocks to common clock framework, > > identify users of those clocks which don't call clk_prepare/unprepare() > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > of just clk_enable/disable(), as required by CCF implementation of clock > > API. > > > > v2: update still a few more OMAP specific drivers missed in v1, > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > can make more sense than merging prepare/unprepare with enable/disable. > > Something is still broken. When doing kexec (using CCF kernel), the > kexec'ed kernel now hangs early (on 770): [...] > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() <- omap1_clk_late_init()). A. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95188C433EF for ; Tue, 22 Mar 2022 19:08:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8C3811750; Tue, 22 Mar 2022 20:08:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8C3811750 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647976132; bh=9mBJfuS3kal7tF/1GOeEYNDJDxJmr4tXuu5mOfEHIlg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XBCLNEgIz2JGuu5UGwc0BBZYnaG+HufqKjWPcBL2yIk4lqohgcwgwqx0qVql+6bw3 NTaiMOLeAWmjxsR7M+URxfnWxrRIBXHRhAc/NOYXHBzuqcYyPba3HAdCU67ExE/6YI C37XZQwAbsct5Ye7k1PtO/yLX/EMtNveCePvE3Fw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 206ECF8012A; Tue, 22 Mar 2022 20:08:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6DA05F8016C; Tue, 22 Mar 2022 20:08:00 +0100 (CET) Received: from meesny.iki.fi (meesny.iki.fi [IPv6:2001:67c:2b0:1c1::201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D552CF800F5 for ; Tue, 22 Mar 2022 20:07:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D552CF800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b="cX6LmeT3" Received: from darkstar.musicnaut.iki.fi (85-76-100-34-nat.elisa-mobile.fi [85.76.100.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by meesny.iki.fi (Postfix) with ESMTPSA id B3C5F20388; Tue, 22 Mar 2022 21:07:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=cX6LmeT38lN2NaF7Qsx5VX0GwklLy2du9kOpxTh3b4+Qw5wrtoKy5+CaPdFHVPF7PUQJV7 JP0eZNy7X0Jfbj3WAB5bQXsUGhmUeS+qIfMHxdWpTOM+QUCxar+jfmcf0+g1AFcQ1pCKkA q4bRX979489LLYULp2d8EW4EbP4qAGY= Date: Tue, 22 Mar 2022 21:07:53 +0200 From: Aaro Koskinen To: Janusz Krzysztofik Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220321215416.236250-1-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220322163646.GD297526@darkstar.musicnaut.iki.fi> ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1647976075; a=rsa-sha256; cv=none; b=X6jYN8e4edIdwhVqd08HooVar4l9k4zaeYIbPBffuNKwdkVOZqop0cLduutP177L6DWw1t z3md1/KyrpNc4Oj2NmcgYKgqs06xOi37+Q82NbgDQR7qRGbl7dmfLBEOUOb/ZvPz8Q9kzG iv9WWWKrxOwoKKPEYH88Tk0Gi1Jit1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=uVqGTgouIQJQ2R58scj6U0J2KM/YtrOq4hq0tSnqJjTw6VkH13Shbd3ZumElBWGBl6w/C+ SIBA6Ck0VAZhNiAy4cgvRL+DdTJJmixLaEk9B9FpqhWM/Nmc5koLsdctAdg9syFOac++N8 L8McGNzCb7F/2+k2v1U0gta89xs02Sw= Cc: alsa-devel@alsa-project.org, Felipe Balbi , Paul Walmsley , Arnd Bergmann , Liam Girdwood , Tony Lindgren , Greg Kroah-Hartman , Helge Deller , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Alan Stern , Ulf Hansson , linux-omap@vger.kernel.org, Peter Ujfalusi , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > In preparation for conversion of OMAP1 clocks to common clock framework, > > identify users of those clocks which don't call clk_prepare/unprepare() > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > of just clk_enable/disable(), as required by CCF implementation of clock > > API. > > > > v2: update still a few more OMAP specific drivers missed in v1, > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > can make more sense than merging prepare/unprepare with enable/disable. > > Something is still broken. When doing kexec (using CCF kernel), the > kexec'ed kernel now hangs early (on 770): [...] > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() <- omap1_clk_late_init()). A. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C7AC433EF for ; Tue, 22 Mar 2022 19:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZMeZwjvAajgUZmZ24sFqUxJDQs9TJhmg2SB84VZKPPI=; b=zKlLxMelMoAXZj GU6HBINoXyDov5qLXtkRdgk8GAMw/qXnW8elwHhxQHrUajfQ7+Gx5W1LwvyYgvtIJLtV63O6JLVBt 5kvflB1kSGEOEJPiaTiXH6jt0U4qp2f4wUz/xRVBunxG7Bi2V/i8hRI13Jm2hEs1WJhUuxVeHTKHu DisPo6Hz4rpqIskC8s4YTuk40IqyqP6dMuDLFFQcB0jP4tPY/8oyHV8bkrG70faITZsD5MC5QWTY9 zOUUXcJNDO6Agx2yGKB9huTuIuH0Pd4KTmMzO0k/Z9Z8UYwpvcVCroYMJFKPdBpklgyX/x8CVOwZW nkOuxGGtADS6zp/xcc+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjrP-00BzYv-Uj; Tue, 22 Mar 2022 19:08:04 +0000 Received: from meesny.iki.fi ([2001:67c:2b0:1c1::201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjrM-00BzY5-Jx for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 19:08:02 +0000 Received: from darkstar.musicnaut.iki.fi (85-76-100-34-nat.elisa-mobile.fi [85.76.100.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by meesny.iki.fi (Postfix) with ESMTPSA id B3C5F20388; Tue, 22 Mar 2022 21:07:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=cX6LmeT38lN2NaF7Qsx5VX0GwklLy2du9kOpxTh3b4+Qw5wrtoKy5+CaPdFHVPF7PUQJV7 JP0eZNy7X0Jfbj3WAB5bQXsUGhmUeS+qIfMHxdWpTOM+QUCxar+jfmcf0+g1AFcQ1pCKkA q4bRX979489LLYULp2d8EW4EbP4qAGY= Date: Tue, 22 Mar 2022 21:07:53 +0200 From: Aaro Koskinen To: Janusz Krzysztofik Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220322190753.GF297526@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <20220321215416.236250-1-jmkrzyszt@gmail.com> <20220322163646.GD297526@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220322163646.GD297526@darkstar.musicnaut.iki.fi> ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1647976075; a=rsa-sha256; cv=none; b=X6jYN8e4edIdwhVqd08HooVar4l9k4zaeYIbPBffuNKwdkVOZqop0cLduutP177L6DWw1t z3md1/KyrpNc4Oj2NmcgYKgqs06xOi37+Q82NbgDQR7qRGbl7dmfLBEOUOb/ZvPz8Q9kzG iv9WWWKrxOwoKKPEYH88Tk0Gi1Jit1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1647976075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9zTS3DT6xcfZw/ju05KElVTkQiN1fQ/ztsa9TbNgG2s=; b=uVqGTgouIQJQ2R58scj6U0J2KM/YtrOq4hq0tSnqJjTw6VkH13Shbd3ZumElBWGBl6w/C+ SIBA6Ck0VAZhNiAy4cgvRL+DdTJJmixLaEk9B9FpqhWM/Nmc5koLsdctAdg9syFOac++N8 L8McGNzCb7F/2+k2v1U0gta89xs02Sw= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_120800_851596_6E1FB53E X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > On Mon, Mar 21, 2022 at 10:54:16PM +0100, Janusz Krzysztofik wrote: > > In preparation for conversion of OMAP1 clocks to common clock framework, > > identify users of those clocks which don't call clk_prepare/unprepare() > > and update them to call clk_prepare_enable/clk_disable_unprepare() instead > > of just clk_enable/disable(), as required by CCF implementation of clock > > API. > > > > v2: update still a few more OMAP specific drivers missed in v1, > > - call clk_prepare/unprepare() just after/before clk_get/put() where it > > can make more sense than merging prepare/unprepare with enable/disable. > > Something is still broken. When doing kexec (using CCF kernel), the > kexec'ed kernel now hangs early (on 770): [...] > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() <- omap1_clk_late_init()). A. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel