From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2A176453 for ; Tue, 22 Mar 2022 21:40:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B83CC340EC; Tue, 22 Mar 2022 21:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985205; bh=KKk2x1Qh9+LAcEVgwchDKX9W0sw8zLTq+JS0aVNeOxg=; h=Date:To:From:In-Reply-To:Subject:From; b=r4KU2W6OIDfP8YxqZqSkQ8QSLurC76UrkRQKj7L8F88PlEG8ANvcjMsbZQ8Oolvpv KgS7YIJnQ4wAvsy7FoEESCMmmqQaVCeIvx6Ac9Z5IweQp4xld0l0KhvqdJCMdkB7QF vrsMq4f6msQrXimeMG3r347fUNumRxlfnZZR7dQ8= Date: Tue, 22 Mar 2022 14:40:04 -0700 To: hughd@google.com,linmiaohe@huawei.com,akpm@linux-foundation.org,patches@lists.linux.dev,linux-mm@kvack.org,mm-commits@vger.kernel.org,torvalds@linux-foundation.org,akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 031/227] mm: shmem: use helper macro __ATTR_RW Message-Id: <20220322214005.7B83CC340EC@smtp.kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: From: Miaohe Lin Subject: mm: shmem: use helper macro __ATTR_RW Use helper macro __ATTR_RW to define shmem_enabled_attr to make code more clear. Minor readability improvement. Link: https://lkml.kernel.org/r/20220312082252.55586-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/shmem.c~mm-shmem-use-helper-macro-__attr_rw +++ a/mm/shmem.c @@ -3965,8 +3965,7 @@ static ssize_t shmem_enabled_store(struc return count; } -struct kobj_attribute shmem_enabled_attr = - __ATTR(shmem_enabled, 0644, shmem_enabled_show, shmem_enabled_store); +struct kobj_attribute shmem_enabled_attr = __ATTR_RW(shmem_enabled); #endif /* CONFIG_TRANSPARENT_HUGEPAGE && CONFIG_SYSFS */ #else /* !CONFIG_SHMEM */ _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A0C433EF for ; Tue, 22 Mar 2022 21:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235997AbiCVVlg (ORCPT ); Tue, 22 Mar 2022 17:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235964AbiCVVle (ORCPT ); Tue, 22 Mar 2022 17:41:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 876D91E7 for ; Tue, 22 Mar 2022 14:40:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25AE060A66 for ; Tue, 22 Mar 2022 21:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B83CC340EC; Tue, 22 Mar 2022 21:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985205; bh=KKk2x1Qh9+LAcEVgwchDKX9W0sw8zLTq+JS0aVNeOxg=; h=Date:To:From:In-Reply-To:Subject:From; b=r4KU2W6OIDfP8YxqZqSkQ8QSLurC76UrkRQKj7L8F88PlEG8ANvcjMsbZQ8Oolvpv KgS7YIJnQ4wAvsy7FoEESCMmmqQaVCeIvx6Ac9Z5IweQp4xld0l0KhvqdJCMdkB7QF vrsMq4f6msQrXimeMG3r347fUNumRxlfnZZR7dQ8= Date: Tue, 22 Mar 2022 14:40:04 -0700 To: hughd@google.com, linmiaohe@huawei.com, akpm@linux-foundation.org, patches@lists.linux.dev, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 031/227] mm: shmem: use helper macro __ATTR_RW Message-Id: <20220322214005.7B83CC340EC@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Miaohe Lin Subject: mm: shmem: use helper macro __ATTR_RW Use helper macro __ATTR_RW to define shmem_enabled_attr to make code more clear. Minor readability improvement. Link: https://lkml.kernel.org/r/20220312082252.55586-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/shmem.c~mm-shmem-use-helper-macro-__attr_rw +++ a/mm/shmem.c @@ -3965,8 +3965,7 @@ static ssize_t shmem_enabled_store(struc return count; } -struct kobj_attribute shmem_enabled_attr = - __ATTR(shmem_enabled, 0644, shmem_enabled_show, shmem_enabled_store); +struct kobj_attribute shmem_enabled_attr = __ATTR_RW(shmem_enabled); #endif /* CONFIG_TRANSPARENT_HUGEPAGE && CONFIG_SYSFS */ #else /* !CONFIG_SHMEM */ _