From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76D7C433EF for ; Tue, 22 Mar 2022 22:13:46 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web09.1915.1647987225773894038 for ; Tue, 22 Mar 2022 15:13:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id B975040C3E; Tue, 22 Mar 2022 22:13:44 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1TwJpGWbJubp; Tue, 22 Mar 2022 22:13:44 +0000 (UTC) Received: from mail.denix.org (pool-100-15-86-127.washdc.fios.verizon.net [100.15.86.127]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 7A7BA40B13; Tue, 22 Mar 2022 22:13:38 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 37B79174837; Tue, 22 Mar 2022 18:13:38 -0400 (EDT) Date: Tue, 22 Mar 2022 18:13:38 -0400 From: Denys Dmytriyenko To: detheridge@ti.com Cc: nm@ti.com, reatmon@ti.com, Yogesh Siraswar , Praneeth Bajjuri , Denys Dmytriyenko , meta-arago@lists.yoctoproject.org Subject: Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2 Message-ID: <20220322221338.GT23554@denix.org> References: <20220322193554.24404-1-reatmon@ti.com> <20220322193554.24404-3-reatmon@ti.com> <20220322204955.kj74x5e6lx4qtghr@borrowing> <4adcaba5-e45d-451a-75a5-3cc8d52ce8fc@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4adcaba5-e45d-451a-75a5-3cc8d52ce8fc@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 22 Mar 2022 22:13:46 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/13718 On Tue, Mar 22, 2022 at 03:58:04PM -0500, Etheridge, Darren via lists.yoctoproject.org wrote: > > > On 3/22/2022 3:49 PM, Nishanth Menon via lists.yoctoproject.org wrote: > >On 14:35-20220322, Ryan Eatmon via lists.yoctoproject.org wrote: > >>From: Krunal Bhargav > >> > >>Signed-off-by: Krunal Bhargav > >>Signed-off-by: Ryan Eatmon > >>--- > >> .../conf/distro/include/arago-prefs.inc | 12 ++++++------ > >> 1 file changed, 6 insertions(+), 6 deletions(-) > >> > >>diff --git a/meta-arago-distro/conf/distro/include/arago-prefs.inc b/meta-arago-distro/conf/distro/include/arago-prefs.inc > >>index a356c76c..7bc2ba52 100644 > >>--- a/meta-arago-distro/conf/distro/include/arago-prefs.inc > >>+++ b/meta-arago-distro/conf/distro/include/arago-prefs.inc > >>@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" > >> PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um" > >> PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km" > >>-# J7 has a Rogue GPU core > >>-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs" > >>-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs" > >>-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs" > >>-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs" > >>-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver" > >>+# K3 TI Platforms has a Rogue GPU core > >>+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs" > >>+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs" > >>+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs" > >>+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs" > >>+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver" > > > >How does this apply to k3 and leave non-k3 alone? Also, am65x for example is > >sgx. > > > > That is a very good point. This will mess up SGX platforms. I > wish we had k3_ as the prefix for the name here for all the k3 > platforms. There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX... > So I guess the only solution is leave all the _j7 as they were > > and add: > +PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs" > +PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs" > +PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs" > +PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs" > +PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver" And there's no "am62" defined, but "am62xx" :) > Is there anything cleverer? > > >> # This is required when using keystone devices with graphical support > >> # such as Qt5 > >>-- > >>2.17.1 -- Regards, Denys Dmytriyenko PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964 Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964