From: Anton Eidelman <anton.eidelman@gmail.com> To: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com Cc: ushankar@purestorage.com, Anton Eidelman <anton@lightbitslabs.com> Subject: [PATCH v2 0/1] nvme/mpath: fix hang when disk goes live over reconnect Date: Tue, 22 Mar 2022 21:55:50 -0600 [thread overview] Message-ID: <20220323035551.1524128-1-anton@lightbitslabs.com> (raw) In-Reply-To: <20210918215729.388968-1-anton@lightbitslabs.com> Revising the original v1 patch submitted on Sep 18, 2021, which deferred nvme_read_ana_log() until nvme_start_ctrl() and raised concerns since the former might fail, while the latter does not currently return an error. I did not see appropriate to introduce error handling in the nvme_start_ctrl() call-sites. Instead, this patch keeps the nvme_read_ana_log() in its original place inside nvme_mpath_init_identify(), but defers updating of the existing ns path state until the ctrl IO queues are enabled in nvme_start_ctrl(). This way the handling of failures to retrieve the ANA log remains intact, while the mpath update is deferred until it's safe to do. Anton Eidelman (1): nvme/mpath: fix hang when disk goes live over reconnect drivers/nvme/host/core.c | 1 + drivers/nvme/host/multipath.c | 12 +++++++++++- drivers/nvme/host/nvme.h | 4 ++++ 3 files changed, 16 insertions(+), 1 deletion(-) -- 2.25.1
next prev parent reply other threads:[~2022-03-23 3:56 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-18 21:57 [PATCH] " Anton Eidelman 2021-09-19 10:19 ` Sagi Grimberg 2021-09-19 23:05 ` Anton Eidelman 2021-09-20 7:55 ` Sagi Grimberg 2021-09-20 6:35 ` Christoph Hellwig 2021-09-20 14:53 ` Anton Eidelman 2021-09-21 7:15 ` Christoph Hellwig 2021-10-04 16:46 ` Anton Eidelman 2021-10-04 16:57 ` Christoph Hellwig 2021-10-05 12:38 ` Sagi Grimberg [not found] ` <368499da-c117-e8b7-7b1b-46894e1e0b48@grimberg.me> 2021-10-19 15:13 ` Anton Eidelman 2022-03-23 3:55 ` Anton Eidelman [this message] 2022-03-23 3:55 ` [PATCH v2 1/1] " Anton Eidelman 2022-03-23 9:23 ` Sagi Grimberg 2022-03-23 14:45 ` [PATCH v3 0/1] " Anton Eidelman 2022-03-23 14:45 ` [PATCH v3 1/1] " Anton Eidelman 2022-03-23 14:55 ` Sagi Grimberg 2022-03-23 15:22 ` Christoph Hellwig 2022-03-24 19:05 ` [PATCH v4 0/1] " Anton Eidelman 2022-03-24 19:05 ` [PATCH v4 1/1] " Anton Eidelman 2022-03-24 21:06 ` Sagi Grimberg 2022-03-25 6:36 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220323035551.1524128-1-anton@lightbitslabs.com \ --to=anton.eidelman@gmail.com \ --cc=anton@lightbitslabs.com \ --cc=axboe@fb.com \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ --cc=ushankar@purestorage.com \ --subject='Re: [PATCH v2 0/1] nvme/mpath: fix hang when disk goes live over reconnect' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.