All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: "Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 5/5] ppc/pnv: Remove usless checks in set_irq handlers
Date: Wed, 23 Mar 2022 08:28:46 +0100	[thread overview]
Message-ID: <20220323072846.1780212-6-clg@kaod.org> (raw)
In-Reply-To: <20220323072846.1780212-1-clg@kaod.org>

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/pnv_psi.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
index 950ecca40573..98045ed3d249 100644
--- a/hw/ppc/pnv_psi.c
+++ b/hw/ppc/pnv_psi.c
@@ -219,11 +219,6 @@ static void pnv_psi_power8_set_irq(void *opaque, int irq, int state)
     uint32_t src;
     bool masked;
 
-    if (irq > PSIHB_IRQ_EXTERNAL) {
-        qemu_log_mask(LOG_GUEST_ERROR, "PSI: Unsupported irq %d\n", irq);
-        return;
-    }
-
     xivr_reg = xivr_regs[irq];
     stat_reg = stat_regs[irq];
 
@@ -813,11 +808,6 @@ static void pnv_psi_power9_set_irq(void *opaque, int irq, int state)
     PnvPsi *psi = opaque;
     uint64_t irq_method = psi->regs[PSIHB_REG(PSIHB9_INTERRUPT_CONTROL)];
 
-    if (irq > PSIHB9_NUM_IRQS) {
-        qemu_log_mask(LOG_GUEST_ERROR, "PSI: Unsupported irq %d\n", irq);
-        return;
-    }
-
     if (irq_method & PSIHB9_IRQ_METHOD) {
         qemu_log_mask(LOG_GUEST_ERROR, "PSI: LSI IRQ method no supported\n");
         return;
-- 
2.34.1



  parent reply	other threads:[~2022-03-23  7:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23  7:28 [PATCH 0/5] ppc/pnv: Introduce GPIO lines to drive the PSIHB device Cédric Le Goater
2022-03-23  7:28 ` [PATCH 1/5] ppc/pnv: Fix PSI IRQ definition Cédric Le Goater
2022-03-23  7:28 ` [PATCH 2/5] ppc/pnv: Remove PnvLpcController::psi link Cédric Le Goater
2022-03-23  7:28 ` [PATCH 3/5] ppc/pnv: Remove PnvOCC::psi link Cédric Le Goater
2022-03-23  7:28 ` [PATCH 4/5] ppc/pnv: Remove PnvPsiClas::irq_set Cédric Le Goater
2022-03-23  7:28 ` Cédric Le Goater [this message]
2022-03-24 18:02   ` [PATCH 5/5] ppc/pnv: Remove usless checks in set_irq handlers Daniel Henrique Barboza
2022-03-24 18:02 ` [PATCH 0/5] ppc/pnv: Introduce GPIO lines to drive the PSIHB device Daniel Henrique Barboza
2022-04-20 19:11 ` Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323072846.1780212-6-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=fbarrat@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.