[PATCH] net: mpls: fix memdup.cocci warning

From: "GONG, Ruiqi" <gongruiqi1@huawei.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Benjamin Poirier <bpoirier@nvidia.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Wang Weiyang <wangweiyang2@huawei.com>,
	"Xiu Jianfeng" <xiujianfeng@huawei.com>
Subject: [PATCH] net: mpls: fix memdup.cocci warning
Date: Wed, 23 Mar 2022 16:07:06 +0800	[thread overview]
Message-ID: <20220323080706.212531-1-gongruiqi1@huawei.com> (raw)

Simply use kmemdup instead of explicitly allocating and copying memory.

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 7d4741eacdef ("net: mpls: Fix notifications when deleting a device")
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---
 net/mpls/af_mpls.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index d6fdc5782d33..35b5f806fdda 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1527,10 +1527,9 @@ static int mpls_ifdown(struct net_device *dev, int event)
 					rt->rt_nh_size;
 				struct mpls_route *orig = rt;
 
-				rt = kmalloc(size, GFP_KERNEL);
+				rt = kmemdup(orig, size, GFP_KERNEL);
 				if (!rt)
 					return -ENOMEM;
-				memcpy(rt, orig, size);
 			}
 		}
 
-- 
2.17.1

