From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Stephen Boyd" <swboyd@chromium.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Taniya Das" <tdas@codeaurora.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Prasad Malisetty <quic_pmaliset@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: [PATCH v1 0/5] PCI: qcom: rework pipe_clk/pipe_clk_src handling
Date: Wed, 23 Mar 2022 11:50:05 +0300 [thread overview]
Message-ID: <20220323085010.1753493-1-dmitry.baryshkov@linaro.org> (raw)
PCIe pipe clk (and some other clocks) must be parked to the "safe"
source (bi_tcxo) when corresponding GDSC is turned off and on again.
Currently this is handcoded in the PCIe driver by reparenting the
gcc_pipe_N_clk_src clock.
Instead of doing it manually, follow the approach used by
clk_rcg2_shared_ops and implement this parking in the enable() and
disable() clock operations for respective pipe clocks.
Changes since RFC:
- Rework clk-regmap-mux fields. Specify safe parent as P_* value rather
than specifying the register value directly
- Expand commit message to the first patch to specially mention that
it is required only on newer generations of Qualcomm chipsets.
Dmitry Baryshkov (5):
clk: qcom: regmap-mux: add pipe clk implementation
clk: qcom: gcc-sm8450: use new clk_regmap_mux_safe_ops for PCIe pipe
clocks
clk: qcom: gcc-sc7280: use new clk_regmap_mux_safe_ops for PCIe pipe
clocks
PCI: qcom: Remove unnecessary pipe_clk handling
PCI: qcom: Drop manual pipe_clk_src handling
drivers/clk/qcom/clk-regmap-mux.c | 78 +++++++++++++++++++++++
drivers/clk/qcom/clk-regmap-mux.h | 3 +
drivers/clk/qcom/gcc-sc7280.c | 6 +-
drivers/clk/qcom/gcc-sm8450.c | 6 +-
drivers/pci/controller/dwc/pcie-qcom.c | 87 +-------------------------
5 files changed, 92 insertions(+), 88 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-23 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 8:50 Dmitry Baryshkov [this message]
2022-03-23 8:50 ` [PATCH v1 1/5] clk: qcom: regmap-mux: add pipe clk implementation Dmitry Baryshkov
2022-04-08 11:15 ` Lorenzo Pieralisi
2022-04-12 18:45 ` Bjorn Andersson
2022-04-13 8:16 ` Johan Hovold
2022-04-13 9:56 ` Lorenzo Pieralisi
2022-04-12 18:32 ` Bjorn Andersson
2022-03-23 8:50 ` [PATCH v1 2/5] clk: qcom: gcc-sm8450: use new clk_regmap_mux_safe_ops for PCIe pipe clocks Dmitry Baryshkov
2022-03-23 8:50 ` [PATCH v1 3/5] clk: qcom: gcc-sc7280: " Dmitry Baryshkov
2022-03-23 8:50 ` [PATCH v1 4/5] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-04-01 10:17 ` Johan Hovold
2022-03-23 8:50 ` [PATCH v1 5/5] PCI: qcom: Drop manual pipe_clk_src handling Dmitry Baryshkov
2022-03-30 12:56 ` [PATCH v1 0/5] PCI: qcom: rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
2022-04-04 5:03 ` Prasad Malisetty (Temp) (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323085010.1753493-1-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@baylibre.com \
--cc=quic_pmaliset@quicinc.com \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.