All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jules Maselbas <jmaselbas@kalray.eu>
To: linux-usb@vger.kernel.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	Minas Harutyunyan <hminas@synopsys.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Amelie DELAUNAY <amelie.delaunay@foss.st.com>,
	Yann Sionneau <ysionneau@kalray.eu>,
	Michael Grzeschik <mgr@pengutronix.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH v2 0/3] Cleanup the call ordering of phy_init and phy_power_on
Date: Wed, 23 Mar 2022 12:07:05 +0100	[thread overview]
Message-ID: <20220323110708.8254-1-jmaselbas@kalray.eu> (raw)

Hi,

Last year Ahmad asked what is the correct order when calling phy_init
and phy_power_on. Since then, I didn't see the situation improve much
and I am once again toying around with usb phy driver.

The following two patches were in my tree for a year... Last year i
previously tried to change the call order in the dwc2 driver but this
requires the relevent phy to be also compatible with the "new" ordering.
The stm32-usbphyc driver wasn't compatible, I am not sure if that is
still is the case.

For now simply add documentation, hopefully correct, but I am not an
expert on actual phy sementics or usage in the kernel. And add warning
when the order is not what's expected.

Best,

---
changes in v2:
  - Update the documentation syntax for returned value

Jules Maselbas (3):
  phy: core: Add documentation of phy operation order
  phy: core: Update documentation syntax
  phy: core: Warn when phy_power_on is called before phy_init

 drivers/phy/phy-core.c | 44 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 3 deletions(-)

-- 
2.17.1


             reply	other threads:[~2022-03-23 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 11:07 Jules Maselbas [this message]
2022-03-23 11:07 ` [PATCH v2 1/3] phy: core: Add documentation of phy operation order Jules Maselbas
2022-03-23 11:07 ` [PATCH v2 2/3] phy: core: Update documentation syntax Jules Maselbas
2022-03-23 11:07 ` [PATCH v2 3/3] phy: core: Warn when phy_power_on is called before phy_init Jules Maselbas
2022-03-23 11:13   ` Ahmad Fatoum
2022-03-23 11:21     ` Jules Maselbas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323110708.8254-1-jmaselbas@kalray.eu \
    --to=jmaselbas@kalray.eu \
    --cc=a.fatoum@pengutronix.de \
    --cc=amelie.delaunay@foss.st.com \
    --cc=arnd@arndb.de \
    --cc=hminas@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgr@pengutronix.de \
    --cc=rdunlap@infradead.org \
    --cc=ysionneau@kalray.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.