From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4436C433F5 for ; Thu, 24 Mar 2022 06:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345584AbiCXGSE (ORCPT ); Thu, 24 Mar 2022 02:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343775AbiCXGR6 (ORCPT ); Thu, 24 Mar 2022 02:17:58 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D0069681A; Wed, 23 Mar 2022 23:16:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2F2DA68B05; Thu, 24 Mar 2022 07:16:21 +0100 (CET) Date: Thu, 24 Mar 2022 07:16:20 +0100 From: Christoph Hellwig To: Sven Peter Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hector Martin , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220324061620.GA12330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220321165049.35985-7-sven@svenpeter.dev> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +//#define DEBUG This should not leak into the driverṡ > +#include As far as I can tell this driver does not support metadata or PI, so why is this include needed? > +/* NVM Express NVM Command Set Specification, Revision 1.0a, Figure 18 */ > +#define NVME_OPCODE_DATA_XFER_HOST_TO_CTRL BIT(0) > +#define NVME_OPCODE_DATA_XFER_CTRL_TO_HOST BIT(1) Please just use the nvme_is_write helper where you are using these. > +static int apple_nvme_sart_dma_setup(void *cookie, struct apple_rtkit_shmem *bfr, Please avoid > 80 character lines. > +static void apple_nvme_free_ctrl(struct nvme_ctrl *ctrl) > +{ > +} So where are the apple specific resources free? ->free_ctrl is the callback from the struct device release callback, so without one the resource release can't be tried to the device release. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BE3CC433EF for ; Thu, 24 Mar 2022 06:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sBDB5OSBz/uv3CCEjwhgRfROxAGI1g6O79SDQaiVD8s=; b=UD6KJNXmVJ59y9 4JkEI6oNwcP5QYMEG0K9GZQiKunDybVSSBW3SssQksKByChJKBmaALWw9SlcY+lwf7DP66MHYGlqi Qqs9/8J/nGxGQTL1mhix1f+IVFv9r4L+dzt7GFrTXuQ83oWUabnEcO7djQQN40qcPauvJBj0k5pWe k4GE58/IS/3e3aolbKKF1EySk/Khly4bmaAtWLP9EtJoWONzAdeFNEie03QgVIzasjvLJ5bsQF4e8 yd7YQn92LD5Lx7mzmiKfsgpqkCnTMCRX4/1SSFehOdptAlLmyIkO68WUxFq74XdTm1+kljksrpPFJ rhRWbt4pf+F2XJkd2fnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXGlo-00Fmxq-8l; Thu, 24 Mar 2022 06:16:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXGlk-00FmxF-QH; Thu, 24 Mar 2022 06:16:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2F2DA68B05; Thu, 24 Mar 2022 07:16:21 +0100 (CET) Date: Thu, 24 Mar 2022 07:16:20 +0100 From: Christoph Hellwig To: Sven Peter Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hector Martin , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220324061620.GA12330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321165049.35985-7-sven@svenpeter.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_231625_021456_B73A01BD X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiArCj4gKy8vI2RlZmluZSBERUJVRwoKVGhpcyBzaG91bGQgbm90IGxlYWsgaW50byB0aGUgZHJp dmVy4bmhCgo+ICsjaW5jbHVkZSA8bGludXgvYmxrLWludGVncml0eS5oPgoKQXMgZmFyIGFzIEkg Y2FuIHRlbGwgdGhpcyBkcml2ZXIgZG9lcyBub3Qgc3VwcG9ydCBtZXRhZGF0YSBvciBQSSwKc28g d2h5IGlzIHRoaXMgaW5jbHVkZSBuZWVkZWQ/Cgo+ICsvKiBOVk0gRXhwcmVzcyBOVk0gQ29tbWFu ZCBTZXQgU3BlY2lmaWNhdGlvbiwgUmV2aXNpb24gMS4wYSwgRmlndXJlIDE4ICovCj4gKyNkZWZp bmUgTlZNRV9PUENPREVfREFUQV9YRkVSX0hPU1RfVE9fQ1RSTCBCSVQoMCkKPiArI2RlZmluZSBO Vk1FX09QQ09ERV9EQVRBX1hGRVJfQ1RSTF9UT19IT1NUIEJJVCgxKQoKUGxlYXNlIGp1c3QgdXNl IHRoZSBudm1lX2lzX3dyaXRlIGhlbHBlciB3aGVyZSB5b3UgYXJlIHVzaW5nIHRoZXNlLgoKPiAr c3RhdGljIGludCBhcHBsZV9udm1lX3NhcnRfZG1hX3NldHVwKHZvaWQgKmNvb2tpZSwgc3RydWN0 IGFwcGxlX3J0a2l0X3NobWVtICpiZnIsCgpQbGVhc2UgYXZvaWQgPiA4MCBjaGFyYWN0ZXIgbGlu ZXMuCgo+ICtzdGF0aWMgdm9pZCBhcHBsZV9udm1lX2ZyZWVfY3RybChzdHJ1Y3QgbnZtZV9jdHJs ICpjdHJsKQo+ICt7Cj4gK30KClNvIHdoZXJlIGFyZSB0aGUgYXBwbGUgc3BlY2lmaWMgcmVzb3Vy Y2VzIGZyZWU/ICAtPmZyZWVfY3RybCBpcwp0aGUgY2FsbGJhY2sgZnJvbSB0aGUgc3RydWN0IGRl dmljZSByZWxlYXNlIGNhbGxiYWNrLCBzbyB3aXRob3V0Cm9uZSB0aGUgcmVzb3VyY2UgcmVsZWFz ZSBjYW4ndCBiZSB0cmllZCB0byB0aGUgZGV2aWNlIHJlbGVhc2UuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==